* [PATCH] test/event: fix incorrect target event queue
@ 2024-08-21 20:37 pbhagavatula
2024-08-22 8:01 ` Amit Prakash Shukla
0 siblings, 1 reply; 3+ messages in thread
From: pbhagavatula @ 2024-08-21 20:37 UTC (permalink / raw)
To: jerinj, Amit Prakash Shukla; +Cc: dev, Pavan Nikhilesh
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
In OP_FWD mode, if internal port is supported, the target event queue
should be the TEST_APP_EV_QUEUE_ID.
Fixes: a276e7c8fbb3 ("test/event: add DMA adapter auto-test")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
app/test/test_event_dma_adapter.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/app/test/test_event_dma_adapter.c b/app/test/test_event_dma_adapter.c
index 3b39521153bb..9988d4fc7bc5 100644
--- a/app/test/test_event_dma_adapter.c
+++ b/app/test/test_event_dma_adapter.c
@@ -271,7 +271,10 @@ test_op_forward_mode(void)
ev[i].event = 0;
ev[i].op = RTE_EVENT_OP_NEW;
ev[i].event_type = RTE_EVENT_TYPE_DMADEV;
- ev[i].queue_id = TEST_DMA_EV_QUEUE_ID;
+ if (params.internal_port_op_fwd)
+ ev[i].queue_id = TEST_APP_EV_QUEUE_ID;
+ else
+ ev[i].queue_id = TEST_DMA_EV_QUEUE_ID;
ev[i].sched_type = RTE_SCHED_TYPE_ATOMIC;
ev[i].flow_id = 0xAABB;
ev[i].event_ptr = op;
--
2.45.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] test/event: fix incorrect target event queue
2024-08-21 20:37 [PATCH] test/event: fix incorrect target event queue pbhagavatula
@ 2024-08-22 8:01 ` Amit Prakash Shukla
2024-09-18 8:13 ` Jerin Jacob
0 siblings, 1 reply; 3+ messages in thread
From: Amit Prakash Shukla @ 2024-08-22 8:01 UTC (permalink / raw)
To: Pavan Nikhilesh Bhagavatula, Jerin Jacob; +Cc: dev, Pavan Nikhilesh Bhagavatula
> -----Original Message-----
> From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> Sent: Thursday, August 22, 2024 2:08 AM
> To: Jerin Jacob <jerinj@marvell.com>; Amit Prakash Shukla
> <amitprakashs@marvell.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>
> Subject: [PATCH] test/event: fix incorrect target event queue
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> In OP_FWD mode, if internal port is supported, the target event queue should
> be the TEST_APP_EV_QUEUE_ID.
>
> Fixes: a276e7c8fbb3 ("test/event: add DMA adapter auto-test")
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> app/test/test_event_dma_adapter.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Tested-by: Amit Prakash Shukla <amitprakashs@marvell.com>
Acked-by: Amit Prakash Shukla <amitprakashs@marvell.com>
Thanks.
>
> diff --git a/app/test/test_event_dma_adapter.c
> b/app/test/test_event_dma_adapter.c
> index 3b39521153bb..9988d4fc7bc5 100644
> --- a/app/test/test_event_dma_adapter.c
> +++ b/app/test/test_event_dma_adapter.c
> @@ -271,7 +271,10 @@ test_op_forward_mode(void)
> ev[i].event = 0;
> ev[i].op = RTE_EVENT_OP_NEW;
> ev[i].event_type = RTE_EVENT_TYPE_DMADEV;
> - ev[i].queue_id = TEST_DMA_EV_QUEUE_ID;
> + if (params.internal_port_op_fwd)
> + ev[i].queue_id = TEST_APP_EV_QUEUE_ID;
> + else
> + ev[i].queue_id = TEST_DMA_EV_QUEUE_ID;
> ev[i].sched_type = RTE_SCHED_TYPE_ATOMIC;
> ev[i].flow_id = 0xAABB;
> ev[i].event_ptr = op;
> --
> 2.45.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] test/event: fix incorrect target event queue
2024-08-22 8:01 ` Amit Prakash Shukla
@ 2024-09-18 8:13 ` Jerin Jacob
0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2024-09-18 8:13 UTC (permalink / raw)
To: Amit Prakash Shukla; +Cc: Pavan Nikhilesh Bhagavatula, Jerin Jacob, dev
On Thu, Aug 22, 2024 at 1:31 PM Amit Prakash Shukla
<amitprakashs@marvell.com> wrote:
>
> > -----Original Message-----
> > From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> > Sent: Thursday, August 22, 2024 2:08 AM
> > To: Jerin Jacob <jerinj@marvell.com>; Amit Prakash Shukla
> > <amitprakashs@marvell.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula
> > <pbhagavatula@marvell.com>
> > Subject: [PATCH] test/event: fix incorrect target event queue
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > In OP_FWD mode, if internal port is supported, the target event queue should
> > be the TEST_APP_EV_QUEUE_ID.
> >
> > Fixes: a276e7c8fbb3 ("test/event: add DMA adapter auto-test")
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > ---
> > app/test/test_event_dma_adapter.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Tested-by: Amit Prakash Shukla <amitprakashs@marvell.com>
> Acked-by: Amit Prakash Shukla <amitprakashs@marvell.com>
Applied to dpdk-next-eventdev/for-main. Thanks
> Thanks.
>
> >
> > diff --git a/app/test/test_event_dma_adapter.c
> > b/app/test/test_event_dma_adapter.c
> > index 3b39521153bb..9988d4fc7bc5 100644
> > --- a/app/test/test_event_dma_adapter.c
> > +++ b/app/test/test_event_dma_adapter.c
> > @@ -271,7 +271,10 @@ test_op_forward_mode(void)
> > ev[i].event = 0;
> > ev[i].op = RTE_EVENT_OP_NEW;
> > ev[i].event_type = RTE_EVENT_TYPE_DMADEV;
> > - ev[i].queue_id = TEST_DMA_EV_QUEUE_ID;
> > + if (params.internal_port_op_fwd)
> > + ev[i].queue_id = TEST_APP_EV_QUEUE_ID;
> > + else
> > + ev[i].queue_id = TEST_DMA_EV_QUEUE_ID;
> > ev[i].sched_type = RTE_SCHED_TYPE_ATOMIC;
> > ev[i].flow_id = 0xAABB;
> > ev[i].event_ptr = op;
> > --
> > 2.45.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-18 8:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-21 20:37 [PATCH] test/event: fix incorrect target event queue pbhagavatula
2024-08-22 8:01 ` Amit Prakash Shukla
2024-09-18 8:13 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).