From: Jerin Jacob <jerinjacobk@gmail.com>
To: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dpdk-dev <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>
Subject: Re: [PATCH] net/cnxk: fix uninitialized scalar variable
Date: Thu, 5 May 2022 14:07:45 +0530 [thread overview]
Message-ID: <CALBAE1MP-vY1PNzVn2Kn-A42OQh=LjYO77op9Tg_-oNJvrzLyQ@mail.gmail.com> (raw)
In-Reply-To: <20220424161818.1680637-1-gmuthukrishn@marvell.com>
On Sun, Apr 24, 2022 at 9:48 PM Gowrishankar Muthukrishnan
<gmuthukrishn@marvell.com> wrote:
>
> Fix uninitialized scalar variable reported in coverity scan.
>
> Coverity issue: 371876, 371877
> Fixes: 39dc567c195 ("net/cnxk: add Tx burst for CN9K")
>
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Squashed similar patch
https://patchwork.dpdk.org/project/dpdk/patch/20220424162239.1680904-1-gmuthukrishn@marvell.com/
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
> ---
> drivers/net/cnxk/cn9k_tx.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/cnxk/cn9k_tx.h b/drivers/net/cnxk/cn9k_tx.h
> index f55cd4bdf2..a0611a67c9 100644
> --- a/drivers/net/cnxk/cn9k_tx.h
> +++ b/drivers/net/cnxk/cn9k_tx.h
> @@ -526,7 +526,7 @@ cn9k_nix_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts,
> {
> struct cn9k_eth_txq *txq = tx_queue;
> const rte_iova_t io_addr = txq->io_addr;
> - uint64_t lso_tun_fmt, mark_fmt = 0;
> + uint64_t lso_tun_fmt = 0, mark_fmt = 0;
> void *lmt_addr = txq->lmt_addr;
> uint8_t mark_flag = 0;
> uint16_t i;
> @@ -574,7 +574,7 @@ cn9k_nix_xmit_pkts_mseg(void *tx_queue, struct rte_mbuf **tx_pkts,
> {
> struct cn9k_eth_txq *txq = tx_queue;
> const rte_iova_t io_addr = txq->io_addr;
> - uint64_t lso_tun_fmt, mark_fmt = 0;
> + uint64_t lso_tun_fmt = 0, mark_fmt = 0;
> void *lmt_addr = txq->lmt_addr;
> uint8_t mark_flag = 0;
> uint16_t segdw;
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-05-05 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-24 16:18 Gowrishankar Muthukrishnan
2022-05-05 8:37 ` Jerin Jacob [this message]
2022-04-24 16:22 Gowrishankar Muthukrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1MP-vY1PNzVn2Kn-A42OQh=LjYO77op9Tg_-oNJvrzLyQ@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=gmuthukrishn@marvell.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).