* [PATCH] doc: announce vhost changes to support asymmetric operation
@ 2024-07-22 14:56 Gowrishankar Muthukrishnan
2024-07-23 18:30 ` Jerin Jacob
0 siblings, 1 reply; 3+ messages in thread
From: Gowrishankar Muthukrishnan @ 2024-07-22 14:56 UTC (permalink / raw)
To: dev, Anoob Joseph, bruce.richardson, ciara.power, jerinj,
fanzhang.oss, arkadiuszx.kusztal, kai.ji, jack.bond-preston,
david.marchand, hemant.agrawal, pablo.de.lara.guarch,
fiona.trahe, declan.doherty, matan, ruifeng.wang,
abhinandan.gujjar, maxime.coquelin, chenbox,
sunilprakashrao.uttarwar, andrew.boyer, ajit.khaparde,
raveendra.padasalagi, vikas.gupta, zhangfei.gao, g.singh,
jianjay.zhou, lee.daly
Cc: Gowrishankar Muthukrishnan
Announce vhost ABI changes to modify few functions to support
asymmetric crypto operation.
Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
--
RFC:
https://patches.dpdk.org/project/dpdk/patch/20230928095300.1353-4-gmuthukrishn@marvell.com/
---
doc/guides/rel_notes/deprecation.rst | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 6948641ff6..2f5c2c5a34 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -147,3 +147,10 @@ Deprecation Notices
will be deprecated and subsequently removed in DPDK 24.11 release.
Before this, the new port library API (functions rte_swx_port_*)
will gradually transition from experimental to stable status.
+
+* vhost: The function ``rte_vhost_crypto_create`` will accept a new parameter
+ to specify rte_mempool for asymmetric crypto session. The function
+ ``rte_vhost_crypto_finalize_requests`` will accept two new parameters,
+ where the first one is to specify vhost device id and other one is to specify
+ the virtio queue index. These two modifications are required to support
+ asymmetric crypto operation in vhost crypto and will break ABI.
--
2.21.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] doc: announce vhost changes to support asymmetric operation
2024-07-22 14:56 [PATCH] doc: announce vhost changes to support asymmetric operation Gowrishankar Muthukrishnan
@ 2024-07-23 18:30 ` Jerin Jacob
2024-07-25 9:29 ` [EXTERNAL] " Gowrishankar Muthukrishnan
0 siblings, 1 reply; 3+ messages in thread
From: Jerin Jacob @ 2024-07-23 18:30 UTC (permalink / raw)
To: Gowrishankar Muthukrishnan
Cc: dev, Anoob Joseph, bruce.richardson, ciara.power, jerinj,
fanzhang.oss, arkadiuszx.kusztal, kai.ji, jack.bond-preston,
david.marchand, hemant.agrawal, pablo.de.lara.guarch,
fiona.trahe, declan.doherty, matan, ruifeng.wang,
abhinandan.gujjar, maxime.coquelin, chenbox,
sunilprakashrao.uttarwar, andrew.boyer, ajit.khaparde,
raveendra.padasalagi, vikas.gupta, zhangfei.gao, g.singh,
jianjay.zhou, lee.daly
On Mon, Jul 22, 2024 at 8:33 PM Gowrishankar Muthukrishnan
<gmuthukrishn@marvell.com> wrote:
>
> Announce vhost ABI changes to modify few functions to support
> asymmetric crypto operation.
>
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> --
> RFC:
> https://patches.dpdk.org/project/dpdk/patch/20230928095300.1353-4-gmuthukrishn@marvell.com/
Looks like in this case adding new arguments to function. Could you
check ABI versing helps here? It seems like it can be easy manged with
ABI versioning.
https://doc.dpdk.org/guides/contributing/abi_versioning.html
> ---
> doc/guides/rel_notes/deprecation.rst | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 6948641ff6..2f5c2c5a34 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -147,3 +147,10 @@ Deprecation Notices
> will be deprecated and subsequently removed in DPDK 24.11 release.
> Before this, the new port library API (functions rte_swx_port_*)
> will gradually transition from experimental to stable status.
> +
> +* vhost: The function ``rte_vhost_crypto_create`` will accept a new parameter
> + to specify rte_mempool for asymmetric crypto session. The function
> + ``rte_vhost_crypto_finalize_requests`` will accept two new parameters,
> + where the first one is to specify vhost device id and other one is to specify
> + the virtio queue index. These two modifications are required to support
> + asymmetric crypto operation in vhost crypto and will break ABI.
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXTERNAL] Re: [PATCH] doc: announce vhost changes to support asymmetric operation
2024-07-23 18:30 ` Jerin Jacob
@ 2024-07-25 9:29 ` Gowrishankar Muthukrishnan
0 siblings, 0 replies; 3+ messages in thread
From: Gowrishankar Muthukrishnan @ 2024-07-25 9:29 UTC (permalink / raw)
To: Jerin Jacob
Cc: dev, Anoob Joseph, bruce.richardson, ciara.power, Jerin Jacob,
fanzhang.oss, arkadiuszx.kusztal, kai.ji, jack.bond-preston,
david.marchand, hemant.agrawal, pablo.de.lara.guarch,
fiona.trahe, declan.doherty, matan, ruifeng.wang,
abhinandan.gujjar, maxime.coquelin, chenbox,
sunilprakashrao.uttarwar, andrew.boyer, ajit.khaparde,
raveendra.padasalagi, vikas.gupta, zhangfei.gao, g.singh,
jianjay.zhou, lee.daly
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
Sure Jerin. I’ll drop this proposal as ABI versioning could help. Thanks.
Looks like in this case adding new arguments to function. Could you
check ABI versing helps here? It seems like it can be easy manged with
ABI versioning.
[-- Attachment #2: Type: text/html, Size: 2978 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-25 9:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-22 14:56 [PATCH] doc: announce vhost changes to support asymmetric operation Gowrishankar Muthukrishnan
2024-07-23 18:30 ` Jerin Jacob
2024-07-25 9:29 ` [EXTERNAL] " Gowrishankar Muthukrishnan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).