From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F1BA4569A; Tue, 23 Jul 2024 20:30:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7294742EE3; Tue, 23 Jul 2024 20:30:50 +0200 (CEST) Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by mails.dpdk.org (Postfix) with ESMTP id C44E5402E7 for ; Tue, 23 Jul 2024 20:30:45 +0200 (CEST) Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-447eb65d366so31089311cf.1 for ; Tue, 23 Jul 2024 11:30:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721759445; x=1722364245; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JiZ6KaFcZyhHDbFLnOr2+N2iIofFEMo7ooJ1Y5Y1+fc=; b=err/uVetKQyfEHAM4QlZvYpgQg23rT3Svq/rhYkXuHt57G81H15luqWXkizz7dxW2o zS4oQCvAC/GRixiF9VFCxoQPwhs2ibDuOIrsLVmjvwRx2TLwZYYRImaOwm0q/ycoq7Gq DxCBK70+956qPJUpLbsNAJTK+4P1qJoQXb648t5KNHgKbVjxO8jMBO8fXGry75/I0uiN fM7cyFD3jVg1LgHmnNdSdA58yB00i1hD5X58CXCuB9eKtOe0dlCKOWTfNwX/LfEYxNcy fIJlRaW7OHKHK0OSR8syZkmhJ63+qihzNvMozkkRhJYZAiCOIA+r9mPJ35Ja7C4+IrnK qXyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721759445; x=1722364245; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JiZ6KaFcZyhHDbFLnOr2+N2iIofFEMo7ooJ1Y5Y1+fc=; b=vrNzEKUgWYI1FENUbqy7kNvhDj7lk7hHlNTEENiX2XVGMwYZOQmMKg7xFboNu9hTGB PQ/Qp2Lt1EYVWdCBagF8pVYSUwNM17dgHFxFWKsxSk95N/Kf6fzu7JdPF5hk8UjgToX0 jOr/wENW+uEq8MzWXlUSbhzUdspBEnFzOYnI+7q7gVrfk14UC5tz2vViUmN1kHtc5d2Z iGRq4Hifd9f4zuvYQzfPXPSLBkR9B939jtf8LjqBSWZaXQNQKY3OKeTdUso62ExNs4nc QnsPDaTy+qhtCEldhT20ofXkp4zhSaNBXrI8a2S35OkuquCrvDJKFq9OfVa/WvWPY5Og eN3Q== X-Gm-Message-State: AOJu0YznwVkIrLbGonk0hSzRTAV0xOhHSHzk48edCJLcTMqqvE9ypt0l +guxgHiWd5RbwxOhHoRmGwbQVujZokqZmN77kKysWnTUG/sdaQTxS1aY307Gci915s5CccOX6I5 eft9A9ZwFkQwvBDp8vXug3Nf9yx0= X-Google-Smtp-Source: AGHT+IEy+9uH+nj4TVdLY1aYb+HZ/4uh9MD/DHfAiWQdsdufj9esfALtmTil4elUP8SynDu4rO34s9NeUgqUPZKoLHo= X-Received: by 2002:ac8:5e08:0:b0:445:50f:b586 with SMTP id d75a77b69052e-44fd4120b81mr6883481cf.35.1721759444641; Tue, 23 Jul 2024 11:30:44 -0700 (PDT) MIME-Version: 1.0 References: <20240722145646.1219-1-gmuthukrishn@marvell.com> In-Reply-To: <20240722145646.1219-1-gmuthukrishn@marvell.com> From: Jerin Jacob Date: Wed, 24 Jul 2024 00:00:18 +0530 Message-ID: Subject: Re: [PATCH] doc: announce vhost changes to support asymmetric operation To: Gowrishankar Muthukrishnan Cc: dev@dpdk.org, Anoob Joseph , bruce.richardson@intel.com, ciara.power@intel.com, jerinj@marvell.com, fanzhang.oss@gmail.com, arkadiuszx.kusztal@intel.com, kai.ji@intel.com, jack.bond-preston@foss.arm.com, david.marchand@redhat.com, hemant.agrawal@nxp.com, pablo.de.lara.guarch@intel.com, fiona.trahe@intel.com, declan.doherty@intel.com, matan@nvidia.com, ruifeng.wang@arm.com, abhinandan.gujjar@intel.com, maxime.coquelin@redhat.com, chenbox@nvidia.com, sunilprakashrao.uttarwar@amd.com, andrew.boyer@amd.com, ajit.khaparde@broadcom.com, raveendra.padasalagi@broadcom.com, vikas.gupta@broadcom.com, zhangfei.gao@linaro.org, g.singh@nxp.com, jianjay.zhou@huawei.com, lee.daly@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 22, 2024 at 8:33=E2=80=AFPM Gowrishankar Muthukrishnan wrote: > > Announce vhost ABI changes to modify few functions to support > asymmetric crypto operation. > > Signed-off-by: Gowrishankar Muthukrishnan > -- > RFC: > https://patches.dpdk.org/project/dpdk/patch/20230928095300.1353-4-gmuth= ukrishn@marvell.com/ Looks like in this case adding new arguments to function. Could you check ABI versing helps here? It seems like it can be easy manged with ABI versioning. https://doc.dpdk.org/guides/contributing/abi_versioning.html > --- > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/= deprecation.rst > index 6948641ff6..2f5c2c5a34 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -147,3 +147,10 @@ Deprecation Notices > will be deprecated and subsequently removed in DPDK 24.11 release. > Before this, the new port library API (functions rte_swx_port_*) > will gradually transition from experimental to stable status. > + > +* vhost: The function ``rte_vhost_crypto_create`` will accept a new para= meter > + to specify rte_mempool for asymmetric crypto session. The function > + ``rte_vhost_crypto_finalize_requests`` will accept two new parameters, > + where the first one is to specify vhost device id and other one is to = specify > + the virtio queue index. These two modifications are required to suppor= t > + asymmetric crypto operation in vhost crypto and will break ABI. > -- > 2.21.0 >