From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 791E9A2EDB for ; Tue, 1 Oct 2019 16:26:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EBE974C99; Tue, 1 Oct 2019 16:26:18 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 21FDE4C90 for ; Tue, 1 Oct 2019 16:26:18 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id c6so48267220ioo.13 for ; Tue, 01 Oct 2019 07:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ibtnIkse2wwW8sXnYXjRTtMYxBcd83t+p9aJ8EJU9eI=; b=RK4C899FW9/ocQ0+Mg8SMOuVOWTEw0Nyih3IOTL3Y3IQRaTsEFODobiv7K8UHSY9Sm uctMiHbJ7DNItzviYf6WNCoi4OGqCo8YFnCKp0iYk6PFzyHrJHHlNoo5ymkMAc+6yvy7 j45JhDlnDZ6QyiSFlQXoVCs2M/lNb3KDlmKNn501zI2ZozlApU5uzw4jqY4O/y7T7csI ks9VXQm+3bsQ1XRLVLJTKpdRORdxxCSW6UC9u2HIXbzAaSCgoopSqLfensU6hr4/N5Gd faJgfta9vOfzkkAZEErOMSum4pj0Jlj4l7sKZ/mhwwr6HvvyUjIZs/nXvIqOkjW+AnCk FgIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ibtnIkse2wwW8sXnYXjRTtMYxBcd83t+p9aJ8EJU9eI=; b=Ru/AjMA3aLxtiAsbydLeotzGvAMTpK4jm8vOT8wTULdTaSSPV2MHU2a2SksocRzut+ dd7t20bk6IMSdOkkWrMZWrT23jn6lRt9AGERF2XjpC11jtjXjc+gXQU8vnkaOwjc0nIn CEZ5Cg/g2ZFj1LYuOxrj/gQyGCMyDyuHYM3X3fYNgeiX9zwJeNON0gv/0Hue3kEvDhEE 3JcU7/SbYnTDiIWsAKXmsNmm18KRntdkI2MwWqy796eYfAcKDVlp540lbdcanfb+sc7Z tZXmnwbJZm9okI+gM6B09GT1mP30OnUstD3yviAPW9Q6nFaaST3VO82KroAdMPIvBlAa DRWQ== X-Gm-Message-State: APjAAAU+lV+C0TwCMOxzIpDID2JBWFIHdyFYXA4iwSTEgj/iAJRBKF48 caQHAjd4HbikOGo8wpgx9gO4M9noOixpqtRl7sw= X-Google-Smtp-Source: APXvYqyXfxUG6qfcgKqnIULRHS+BKV2VQ9A7a3fsWISlwR4rqtWc2GJrndfL9MGjUgJjcQjQWb03v6S+KqBk/zz64Z4= X-Received: by 2002:a5d:8143:: with SMTP id f3mr21385234ioo.294.1569939977377; Tue, 01 Oct 2019 07:26:17 -0700 (PDT) MIME-Version: 1.0 References: <30b29c553a1ae4faafbd2018ec3a6701b71d266a.1569846991.git.gaetan.rivet@6wind.com> <20190930115333.5302e457@hermes.lan> <20191001091013.xxtzjblepbleqren@bidouze.vm.6wind.com> <20191001140948.r35w2tpvx3fg6xiw@bidouze.vm.6wind.com> In-Reply-To: <20191001140948.r35w2tpvx3fg6xiw@bidouze.vm.6wind.com> From: Jerin Jacob Date: Tue, 1 Oct 2019 19:56:06 +0530 Message-ID: To: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= Cc: Stephen Hemminger , dpdk-dev , Slava Ovsiienko , Ferruh Yigit , Anatoly Burakov , Thomas Monjalon , Jerin Jacob Kollanukkaran , David Marchand Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v1] eal: add manual probing option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 1, 2019 at 7:39 PM Ga=C3=ABtan Rivet w= rote: > > On Tue, Oct 01, 2019 at 03:19:42PM +0530, Jerin Jacob wrote: > > On Tue, Oct 1, 2019 at 2:40 PM Ga=C4=97tan Rivet wrote: > > > > > > On Mon, Sep 30, 2019 at 11:53:33AM -0700, Stephen Hemminger wrote: > > > > On Mon, 30 Sep 2019 14:51:03 +0200 > > > > Gaetan Rivet wrote: > > > > > > > > > Add a new EAL option enabling manual probing in the EAL. > > > > > This command line option will configure the EAL so that buses > > > > > will not trigger their probe step on their own. > > > > > > > > > > Applications are then expected to hotplug devices as they see fit= . > > > > > > > > > > Devices declared on the command line by the user (using -w and --= vdev), > > > > > will be probed using the hotplug API, in the order they are decla= red. > > > > > > > > > > This has the effect of offering a way for users to control probe = order > > > > > of their devices, for drivers requiring it. > > > > > > > > > > Signed-off-by: Gaetan Rivet > > > > > > > > I have no problems with the patch, but it would help if there was b= etter > > > > way to handle device naming policy in DPDK. Applications that depen= d on > > > > particular port number are prone to get broken by changes in surrou= nding > > > > OS or hardware environment. Just like Linux applications that are b= uilt > > > > to depend on "eth0"; which is unfortunately all too common. > > > > > > Hello Stephen, > > > > > > This patch is a way to avoid having the PCI bus defining the probe or= der > > > with the current hardware environment. It seems to be a step in the > > > right direction for the issue you identify. > > > > > > There is a tight coupling between device names and driver matches for > > > the vdev bus, but that seems difficult to avoid. > > > > > > Do you see other EAL APIs fostering an over reliance of downstream > > > systems on device names? > > > > > > I pushed a few months back a way to iterate / match devices by their > > > properties. If you identify other pain points, this could certainly b= e > > > improved as well. > > > > > > And this mode will be kicked in only when "--manual-probe" selected on > > eal arguments. > > So it won't change the behavior of the existing applications. > > If I read you correctly, if hardware independence is the proper way to fu= nction, > we should switch entirely to it. > > I agree, but that means rewriting entirely the probe step of rte_bus. > This patch is a incremental step, I preferred to keep risks low. +1 > > It is not clear from your remark whether you are considering this > limitation a good or a bad thing however :) I am considering it as a good step. > Can you be a bit more explicit? > > -- > Ga=C4=97tan Rivet > 6WIND