From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7B34A0C43; Wed, 20 Oct 2021 18:21:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74358410E9; Wed, 20 Oct 2021 18:21:48 +0200 (CEST) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by mails.dpdk.org (Postfix) with ESMTP id C8C4740E2D for ; Wed, 20 Oct 2021 18:21:47 +0200 (CEST) Received: by mail-io1-f45.google.com with SMTP id x1so25325329iof.7; Wed, 20 Oct 2021 09:21:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vek/c2y28wSoKXDY400t01IxAiQFmCECpq+Pw1DbQ48=; b=neSpR/Pcn7t3nvyU2wj+yK9USTM7bFevVsP/Eg7thCYwFXr60CsxGOMKfEUKuIDT+q 03w9XgHBi0+EIaRjTcPYmHXzeJRV1boS8Fyaag44v1qQji7ab9lH4zr1lCGDRdv2Hmu/ zNjvNrfeuX9mBI6jOC+XUny+78dDjR+cuz4016MJJMTp0aK8C0zlH4S4YeGtCpkPpQnY WBsTN+2eqgINi2iNu0F43nwi0ZYYBzYb6kEDw+qgDhsysY0PHneIChv1GlUZowkMPYx0 zxvz84IFFZSSDY/rMoDzibnaBxJRTmFiseSOd9aloe5YZ1m9B30LMlEb8VO+SjRHlDeT MdhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vek/c2y28wSoKXDY400t01IxAiQFmCECpq+Pw1DbQ48=; b=u6oQeuD0KZLgxa2p5OVcKs0wFo/hDwKTZ/xWKmABkMjgHTU/Byu7kUnYmjVlN4HLMn m8QP7xrr9TfhUCSH4rhHGgEAZFtsHef9xHzpYqK8H/POZ3vNsoLP8FD38UVLUU7r0KwB DR8pCPCmqRUmXAzK2ChcAJwXVGRmwh0UOn53lZSAikBW/omrz06zxoQQyYDSw/d3AY74 LzwwaeXWC3yocy1fH9agE8wqVg1jnwZ4OKfVKuOOlO27IkwZ/ps2PBvFAR9hEVuOmluS F7v1vL+3FD+FRKL1mpbgP/rqLR3zv+QDxgP8LgFKgj+ZjLWvNHhPDdnptWj7WbqulPN8 AhCg== X-Gm-Message-State: AOAM533XLkXngtYhX8gWMLAy45cOoYjFPvoWBXTMncHVKxWf9ygx1NSV /kTnEUg0fsx6tMErowlpk9o9tuvdnAWOGZVTcQ2LoFR9Ak/iHw== X-Google-Smtp-Source: ABdhPJxQ/crVRgh+1rNIZ61fKfgK7UAFSD/4y2C93OnTeeuselCwOlIia/E+XeOK7wlCbInsxXiUmfCh8bMleaRw068= X-Received: by 2002:a05:6638:1505:: with SMTP id b5mr193887jat.99.1634746907082; Wed, 20 Oct 2021 09:21:47 -0700 (PDT) MIME-Version: 1.0 References: <20210909125422.31144-2-harry.van.haaren@intel.com> <20211014145141.679372-1-harry.van.haaren@intel.com> <20211014145141.679372-4-harry.van.haaren@intel.com> In-Reply-To: From: Jerin Jacob Date: Wed, 20 Oct 2021 21:51:21 +0530 Message-ID: To: "Van Haaren, Harry" Cc: dpdk-dev , Jerin Jacob , "Pathak, Pravin" , "Shetty, Rashmi" , "Pathak@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 4/4] event/dlb2: optimize credit allocations using port hint flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 20, 2021 at 7:38 PM Van Haaren, Harry wrote: > > Hi Jerin, > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Wednesday, October 20, 2021 2:19 PM > > To: Van Haaren, Harry > > Cc: dpdk-dev ; Jerin Jacob ; Pathak, Pravin > > ; Shetty, Rashmi ; > > Pathak@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2 4/4] event/dlb2: optimize credit allocations > > using port hint flags > > > > On Thu, Oct 14, 2021 at 8:22 PM Harry van Haaren > > wrote: > > > > > > From: "Pathak, Pravin" > > > > There are the following issues > > > > 1) WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name > > mismatch: 'From: "Pathak, Pravin" ' != > > 'Signed-off-by: Pravin Pathak ' > > Signed off by line is correct, the "From" line is incorrect. > > > 2) > > Headline too long: > > event/dlb2: optimize credit allocations using port hint flags > > Suggest this headline (which brings under the 60 chars?) > > event/dlb2: optimize credit allocations with port hints > > > > Wrong tag: > > Signed-off-by: Pathak, Pravin > > > > Invalid patch(es) found - checked 4 patches > > check-git-log failed > > > > ### event/dlb2: optimize credit allocations using port hint flags > > > > WARNING:TYPO_SPELLING: 'Defaut' may be misspelled - perhaps 'Default'? > > #156: FILE: drivers/event/dlb2/dlb2_priv.h:27: > > +#define DLB2_SW_CREDIT_QUANTA_DEFAULT 32 /* Defaut = Worker */ > > ^^^^^^ > > I can fix item 2 on merge. > > > > Regarding the author name(1). Can I change to Pravin Pathak > > ? > > Yes, thanks. > > > Appreciate a quick reply. > > Thanks for review & response. Added Acked-by: Jerin Jacob to 1,2,3 patches in the series. Applied to dpdk-next-eventdev/for-main. Thanks. > >