From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 973D4A04DB; Wed, 12 Aug 2020 18:12:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 92E441C0B1; Wed, 12 Aug 2020 18:12:49 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id D80081C0AF for ; Wed, 12 Aug 2020 18:12:47 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id b16so3362910ioj.4 for ; Wed, 12 Aug 2020 09:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=oJWAGwK1SEP10jmpjuDBnQZNsOAEX1exV/Kw+GlFreI=; b=in2q0tTQhM/+NPX6+dxqBb+FZ2eZqDQoejrNBs0hYHle42ufUUtuOUMftbQe4hq7uQ YbMh4YJ8ZxFyUG4GjTnyMdUbrMYflXzL1GkJIMpXmNL4BsWiM1LGjECXmL/pk8W0TgI/ UIFexBu32BMeCTNf0Rza8TBvxSDl0qDemFJEN66syGMu4FJ7BYGgMujyF/6UF50RSXvt MfR66ze2IOKl/Ktv/gpgqLZXQCIGTPPRItoq0BYIoLdFYiMrGEHYFQcT+9svyloYTKZH XTRdmSONUoMesM0Tn4iUTGk0zgF+tdk77lL93HY+OMvC5ORtdYukJH4u8Ny5yRMfFzP1 tX1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=oJWAGwK1SEP10jmpjuDBnQZNsOAEX1exV/Kw+GlFreI=; b=euPXmWDxRjQb/c2ZK1ko4/p2gYd9dJYrGY8hNahqVUOz/ni/kRwC+GoNlgi6oV64mv L+IhZUaC80Cy6P9/IKhMlKMGgmk/LSMwWVwHUJN/Oq8uHuAkJZusw4EqNiMvfNe9x6xU gU1DdsUI0FgBJ7gEKwr9Z1s4ELCbVVluS/JvEqoXzOnmgQX1vqEEX2dZNcTbFBkGY7RJ PTloohERVm927DuPbmOO9Piqd8UpR7aiNwKMo4G/32U2IzEC+0NEZNqSrTD8+9BVsIub BnCDoMS2D/RgAlG9poxzAz+s4a1KcoJFO0cqYM26RE0UR7IwYA+tYXvwfYxbh/ymgs8v 1V8g== X-Gm-Message-State: AOAM533OVscUymoYJOCAd1nVkq1ShJumDueF+MhED+S80pYY35iE4DFa OYRkrrK+wFuc8zJEiChbfxXDoY6YpNGRfl3XLb0= X-Google-Smtp-Source: ABdhPJwhpaOIA8OgALvtFVj8l40DRHHrxEPF6RfcahN8SoLlOOjtwqV0lMwhI2F3DnwV3aB1AHmzGxx8DQ2GHAYraJ8= X-Received: by 2002:a05:6638:1313:: with SMTP id r19mr184718jad.60.1597248767180; Wed, 12 Aug 2020 09:12:47 -0700 (PDT) MIME-Version: 1.0 References: <20200807123009.21266-1-ciara.power@intel.com> <20200807123009.21266-3-ciara.power@intel.com> <20200807124536.GA302@bricha3-MOBL.ger.corp.intel.com> <20200807132343.GA306@bricha3-MOBL.ger.corp.intel.com> <20200807150553.ujvph5i5jzuu77ok@u256.net> <20200812155032.GH312@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200812155032.GH312@bricha3-MOBL.ger.corp.intel.com> From: Jerin Jacob Date: Wed, 12 Aug 2020 21:42:30 +0530 Message-ID: To: Bruce Richardson Cc: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= , Ferruh Yigit , Ciara Power , dpdk-dev , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 20.11 02/19] build: remove makefiles and mk directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 12, 2020 at 9:20 PM Bruce Richardson wrote: > > On Fri, Aug 07, 2020 at 05:05:53PM +0200, Ga=C4=97tan Rivet wrote: > > On 07/08/20 19:31 +0530, Jerin Jacob wrote: > > > On Fri, Aug 7, 2020 at 7:04 PM Ferruh Yigit = wrote: > > > > > > > > On 8/7/2020 2:23 PM, Bruce Richardson wrote: > > > > > On Fri, Aug 07, 2020 at 06:49:47PM +0530, Jerin Jacob wrote: > > > > >> On Fri, Aug 7, 2020 at 6:15 PM Bruce Richardson > > > > >> wrote: > > > > >>> > > > > >>> On Fri, Aug 07, 2020 at 01:29:52PM +0100, Ciara Power wrote: > > > > >>>> It was decided [1] to no longer support Make in DPDK, this pat= ch > > > > >>>> removes all Makefiles that do not make use of pkg-config, alon= g with > > > > >>>> the mk directory previously used by make. > > > > >>>> > > > > >>>> [1] https://mails.dpdk.org/archives/dev/2020-April/162839.html > > > > >>>> > > > > >>>> Signed-off-by: Ciara Power > > > > >>>> --- > > > > >>>> GNUmakefile | 17 - > > > > >>>> Makefile | 4 - > > > > >>> > > > > >>> Open question from me: > > > > >>> Do we want to leave a dummy top-level makefile that prints inst= ructions on > > > > >>> build with meson and ninja - or even runs a build using them if= they are > > > > >>> installed? > > > > >> > > > > >> Maybe we can keep "make tags" as well in top-level Makefile. > > > > > > > > > > Is it better to point people directly to the script? My concern a= bout > > > > > having a makefile is that it may confuse people as to how to buil= d DPDK. > > > > > On the other side, there is a convenience aspect to having a make= file, so > > > > > I'm open to being convinced either way. > > > > > > I was looking more of a convenience point of view. > > > Can we check how other meson based projects deal with similar problem= s? > > > > > > > > > > > > > > > > A dummy Makefile to print instructions may be helpful for people mi= ssed the > > > > change, I am for having it. > > > > > > > > But I am dubious on extending it, like for tags, although I found i= t useful I > > > > think we should integrate it to meson instead. > > > > > > I think, we can not integrate such stuff with meson. If we can with m= eson, > > > I agree we should take that path. > > > > +1 to provide basic and short instructions to use meson when someone > > tries to use make. > > > > On the other hand I think tag generation should not be part of the buil= d > > system. The only dependency of build-tags.sh on make is for `make > > showconfigs`, they can probably be listed without using make. > > > > The scripts seems standalone, why keep make to call it? The config > > target could be inferred if that's the issue? > > > We may not actually need to do anything if we don't want to, > other than put some info in the docs. > > https://mesonbuild.com/Release-notes-for-0-53-0.html#source-tags-targets > > After running "meson build", "ninja -C build ctags" creates a tags file i= n > the root directory of my git tree, which vim picks up and uses without > problems. Admittedly this is from meson 0.53 onwards, but I'm not sure ho= w > much extra effort we need to put in to support older versions for > developers. Anyone hacking the code is probably using up-to-date tools > anyway, one hopes! > > Jerin, can you perhaps check to see if there are any problems with the > meson-generated tags file or if we are missing anything major compared to > the script-generated one? I would hope that it's pretty complete and that > we can also drop our ctags script in future too, and avoid maintaining it= . I just checked rte_pause definition for x86 build, It is picking up x86, arm, ppc definition also. so meson doesn't have that kind of tag level support like the script. But I am OK to drop the script, if that's the path we are planning to take. No strong opinion. > > /Bruce