From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD6A0A04DF; Tue, 11 Aug 2020 20:28:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7EED11C026; Tue, 11 Aug 2020 20:28:04 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 46CF04C99 for ; Tue, 11 Aug 2020 20:28:03 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id q75so13896607iod.1 for ; Tue, 11 Aug 2020 11:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OPZ9yxp/OAmVyoEC08rCK0wZ2EsSDIDD1XG7ItuMjfA=; b=FCycoRnD15PM2lpZ8sKix+nFutka1JUzdOgiUn/OBzteOjFnCOk7l3rsiHsn/1psEy GO2QcIqrpSH+/eo3tOlP9yUaiqIFIBXJgDGUMcs6zPRrcMMHZ3K0OWaMFhVyq0W5V1df rZH0/N1Pt/Vv8P5z4VdSsyzaHqADIPGlLl414pY3Rn2ZN8Ho2Pqb2K4YwUwECdtEZLyJ a4ApXsaxB5cQI0eCw/Ie3ykXijXDKI0AV3Cwh7UpfGk3hqYbyaVcXc8IZ38SVpE6gR1p IvajCAu8d0yWoAc/jJkIcQWapbuNlnNhepp3AeL3sZ617Ya0EqgOUKfoQ+A2w4WJnbM6 8+CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OPZ9yxp/OAmVyoEC08rCK0wZ2EsSDIDD1XG7ItuMjfA=; b=R5HAASgUpdZeifNMgq3h6baOWw+mutj/ek4XCmGlbBIotX5AKisz59Hz6kob6ggSTo z8ucCNMvpn1dicT467BM5LuZPTvkjLe26TRqwZHhJmNgmjPB3xRHClpV2qoDc9axO+1s 0S2VOiO5p+Fqmo5NjAg4Cl3URgYqqwldZGlarvBdadOhR1xe5SDr4fbhm/bAoxchdgjV cShxz+M2MnzSkcOE98BQLd9xucIXReH/wkFRZpAVG7/Jr95n5mmXXJBO0RY/aDIQPe/8 LuLtnIeGKLy1BxfZIVtLrJgyunNJXjllreESEj7Rtw3tiJ15dDowz1bwWecgU5ouL2w5 IVPQ== X-Gm-Message-State: AOAM531kk95YL459t4spLd2r52zZpO/3jha09xHoyb7lsQJ7Ya6Yt/IX EMxWne8His9ocgHdkmZAvIPB94D+WwSJG6PfNAg= X-Google-Smtp-Source: ABdhPJwqJTWRFI0+8nAFNBg5HZWj3xjpdyh6RfCwTBqUMUR3Ke2isA/sUWKQbIYtnPOY0eW2a3ucKvN6sIT0WCBc3SI= X-Received: by 2002:a02:a04d:: with SMTP id f13mr27376334jah.112.1597170482625; Tue, 11 Aug 2020 11:28:02 -0700 (PDT) MIME-Version: 1.0 References: <1593232671-5690-0-git-send-email-timothy.mcdaniel@intel.com> <1596138614-17409-1-git-send-email-timothy.mcdaniel@intel.com> <1596138614-17409-7-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1596138614-17409-7-git-send-email-timothy.mcdaniel@intel.com> From: Jerin Jacob Date: Tue, 11 Aug 2020 23:57:46 +0530 Message-ID: To: "McDaniel, Timothy" Cc: Jerin Jacob , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , dpdk-dev , Gage Eads , "Van Haaren, Harry" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 06/27] event/dlb: add dynamic logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jul 31, 2020 at 1:24 AM McDaniel, Timothy wrote: > > From: "McDaniel, Timothy" Please avoid empty comments. > > Signed-off-by: McDaniel, Timothy > --- > drivers/event/dlb/dlb_log.h | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100644 drivers/event/dlb/dlb_log.h > > diff --git a/drivers/event/dlb/dlb_log.h b/drivers/event/dlb/dlb_log.h > new file mode 100644 > index 0000000..c69c9e5 > --- /dev/null > +++ b/drivers/event/dlb/dlb_log.h > @@ -0,0 +1,25 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2016-2020 Intel Corporation > + */ > + > +#ifndef _DLB_EVDEV_LOG_H_ > +#define _DLB_EVDEV_LOG_H_ > + > +extern int eventdev_dlb_log_level; RTE_LOG_REGISTER is missing. Use real dynamic logging. > + > +/* Dynamic logging */ > +#define DLB_LOG_IMPL(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, eventdev_dlb_log_level, "%s" fmt "\n", \ > + __func__, ##args) > + > +#define DLB_LOG_INFO(fmt, args...) \ > + DLB_LOG_IMPL(INFO, fmt, ## args) > + > +#define DLB_LOG_ERR(fmt, args...) \ > + DLB_LOG_IMPL(ERR, fmt, ## args) > + > +/* remove debug logs at compile time unless actually debugging */ > +#define DLB_LOG_DBG(fmt, args...) \ > + RTE_LOG_DP(DEBUG, PMD, fmt, ## args) > + > +#endif /* _DLB_EVDEV_LOG_H_ */ > -- > 1.7.10 >