From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A172A056A; Fri, 6 Mar 2020 14:38:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 23D391BFBB; Fri, 6 Mar 2020 14:38:10 +0100 (CET) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by dpdk.org (Postfix) with ESMTP id A735C2BA8 for ; Fri, 6 Mar 2020 14:38:08 +0100 (CET) Received: by mail-il1-f193.google.com with SMTP id b17so2060152iln.3 for ; Fri, 06 Mar 2020 05:38:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RAmxsxYovYmrC+CiLXLVai1hEeCWpBV5s5oZ7zgj2dU=; b=TDTXheemlLXFqUkvjnJq3uqFW+qTFKwX7gIt4k5Gf96foHyHzAAQt2jibIug1J7Maz cHs6qzMGJvryTzjMh9+O7gYzyQGcs+UGXSna3WlmxbM3OC4Ge37ClfZ0XDmZTNVBndt+ zumjTW8GVsy3K2W8zjsgKEd4/XGsVnlNwetCdkZq1VR0ebtQ1reZ+uNiBJAbsyfwXfQ8 bwCxPZRkGEfMclqZ5in0D1wSYVKu/DZI8/2M7HV5nQPoXSaAUza2UYRRA7CYD7eCup9h FNywKa8rxWLGS00USTxEVQQTXyswPIW3IPSoXOMmjfXhCIdMADThW9WVBdkaB2LUS+ez ikVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RAmxsxYovYmrC+CiLXLVai1hEeCWpBV5s5oZ7zgj2dU=; b=Ido28fRX3h+z0OGTZOoBI+5KF6GYNADlktBDdE5kZ4eIk/MV62dlWkn17KwwAzr4NN XE/8/bOkPCQHpucn8Mqzz+DDqxDt/WV9j8IsX4QOnWIqHkuwpDf1DF0wa1Nxuuaib2Sd RaAjhiZRnywH22fgH0Bqfx4pvO4ohGpmH3kduID2bSdYlBanwINwpltYEFoJM2tHpeKD UuxZffnDJyg7cPZ82X6JkRLiPOB1/MKgRW9ZbquoXv1eHEIFy4zVWqUGoB38XJOLwSRu N9EZ6EJrr7kiMXTnXPkTxJ/4Q4NbZL658l7FolBkASnS4pctN4u2Obdb6p2ibdZzB52/ U1XA== X-Gm-Message-State: ANhLgQ2j1Zs9zVmym+WqfR30/zfKkI5PRjO6Va8P7DHFmy6K5nY39yef /tyqq/pFO6mH/u/NfXQRdrX0JGcGMQwtSANTvIw= X-Google-Smtp-Source: ADFU+vuUF8eMGA7FAD1kVWmaIoRelgIjxfUaAVzEYdAEDyFrVETMrx7AW45puFm3sKoLgoaegEatcPLzLvUDZB8xIac= X-Received: by 2002:a05:6e02:606:: with SMTP id t6mr3199994ils.271.1583501887825; Fri, 06 Mar 2020 05:38:07 -0800 (PST) MIME-Version: 1.0 References: <1583114253-15345-1-git-send-email-xiangxia.m.yue@gmail.com> <1583501776-9958-1-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: <1583501776-9958-1-git-send-email-xiangxia.m.yue@gmail.com> From: Jerin Jacob Date: Fri, 6 Mar 2020 19:07:51 +0530 Message-ID: To: Tonghao Zhang Cc: dpdk-dev , Olivier Matz , Andrew Rybchenko , Gage Eads , "Artem V. Andreev" , Jerin Jacob , Nithin Dabilpuram , Vamsi Attunuru , Hemant Agrawal Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH dpdk-dev v3] mempool: sort the rte_mempool_ops by name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 6, 2020 at 7:06 PM wrote: > > From: Tonghao Zhang > > The order of mempool initiation affects mempool index in the > rte_mempool_ops_table. For example, when building APPs with: > > $ gcc -lrte_mempool_bucket -lrte_mempool_ring ... > > The "bucket" mempool will be registered firstly, and its index > in table is 0 while the index of "ring" mempool is 1. DPDK > uses the mk/rte.app.mk to build APPs, and others, for example, > Open vSwitch, use the libdpdk.a or libdpdk.so to build it. > The mempool lib linked in dpdk and Open vSwitch is different. > > The mempool can be used between primary and secondary process, > such as dpdk-pdump and pdump-pmd/Open vSwitch(pdump enabled). > There will be a crash because dpdk-pdump creates the "ring_mp_mc" > ring which index in table is 0, but the index of "bucket" ring > is 0 in Open vSwitch. If Open vSwitch use the index 0 to get > mempool ops and malloc memory from mempool. The crash will occur: > > bucket_dequeue (access null and crash) > rte_mempool_get_ops (should get "ring_mp_mc", > but get "bucket" mempool) > rte_mempool_ops_dequeue_bulk > ... > rte_pktmbuf_alloc > rte_pktmbuf_copy > pdump_copy > pdump_rx > rte_eth_rx_burst > > To avoid the crash, there are some solution: > * constructor priority: Different mempool uses different > priority in RTE_INIT, but it's not easy to maintain. > > * change mk/rte.app.mk: Change the order in mk/rte.app.mk to > be same as libdpdk.a/libdpdk.so, but when adding a new mempool > driver in future, we must make sure the order. > > * register mempool orderly: Sort the mempool when registering, > so the lib linked will not affect the index in mempool table. > > Signed-off-by: Tonghao Zhang > Acked-by: Olivier Matz Acked-by: Jerin Jacob > --- > v3: > * fix checkpatches.sh WARNING > * change "initiation -> initialization" > > v2: > * use the qsort to sort the mempool_ops. > * tested: https://travis-ci.com/ovn-open-virtual-networks/dpdk-next-net/builds/151894026 > --- > lib/librte_mempool/rte_mempool_ops.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/lib/librte_mempool/rte_mempool_ops.c b/lib/librte_mempool/rte_mempool_ops.c > index 22c5251..b0da096 100644 > --- a/lib/librte_mempool/rte_mempool_ops.c > +++ b/lib/librte_mempool/rte_mempool_ops.c > @@ -17,6 +17,15 @@ struct rte_mempool_ops_table rte_mempool_ops_table = { > .num_ops = 0 > }; > > +static int > +compare_mempool_ops(const void *a, const void *b) > +{ > + const struct rte_mempool_ops *m_a = a; > + const struct rte_mempool_ops *m_b = b; > + > + return strcmp(m_a->name, m_b->name); > +} > + > /* add a new ops struct in rte_mempool_ops_table, return its index. */ > int > rte_mempool_register_ops(const struct rte_mempool_ops *h) > @@ -63,6 +72,13 @@ struct rte_mempool_ops_table rte_mempool_ops_table = { > ops->get_info = h->get_info; > ops->dequeue_contig_blocks = h->dequeue_contig_blocks; > > + /* > + * sort the rte_mempool_ops by name. the order of the mempool > + * lib initialization will not affect rte_mempool_ops index. > + */ > + qsort(rte_mempool_ops_table.ops, rte_mempool_ops_table.num_ops, > + sizeof(rte_mempool_ops_table.ops[0]), compare_mempool_ops); > + > rte_spinlock_unlock(&rte_mempool_ops_table.sl); > > return ops_index; > -- > 1.8.3.1 >