From: Jerin Jacob <jerinjacobk@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Jerin Jacob <jerinj@marvell.com>
Subject: Re: [PATCH] app/test-eventdev: remove unnecessary memset
Date: Tue, 13 Sep 2022 19:24:28 +0530 [thread overview]
Message-ID: <CALBAE1MVVnde+F8TnfEq6capXmafaF7VPSoaiswB-7Szr6KUcg@mail.gmail.com> (raw)
In-Reply-To: <20220713152848.160523-1-stephen@networkplumber.org>
On Wed, Jul 13, 2022 at 8:59 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The function rte_event_dev_info_get already zeros the info structure.
> Therefore the test code doesn't need to do it.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks
> ---
> app/test-eventdev/test_order_common.c | 1 -
> app/test-eventdev/test_perf_atq.c | 1 -
> app/test-eventdev/test_perf_queue.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/app/test-eventdev/test_order_common.c b/app/test-eventdev/test_order_common.c
> index 603e7c9178bc..6f00f2448a24 100644
> --- a/app/test-eventdev/test_order_common.c
> +++ b/app/test-eventdev/test_order_common.c
> @@ -328,7 +328,6 @@ order_event_dev_port_setup(struct evt_test *test, struct evt_options *opt,
> struct test_order *t = evt_test_priv(test);
> struct rte_event_dev_info dev_info;
>
> - memset(&dev_info, 0, sizeof(struct rte_event_dev_info));
> ret = rte_event_dev_info_get(opt->dev_id, &dev_info);
> if (ret) {
> evt_err("failed to get eventdev info %d", opt->dev_id);
> diff --git a/app/test-eventdev/test_perf_atq.c b/app/test-eventdev/test_perf_atq.c
> index 5436a9b06cd8..8326f540459f 100644
> --- a/app/test-eventdev/test_perf_atq.c
> +++ b/app/test-eventdev/test_perf_atq.c
> @@ -212,7 +212,6 @@ perf_atq_eventdev_setup(struct evt_test *test, struct evt_options *opt)
>
> nb_queues = atq_nb_event_queues(opt);
>
> - memset(&dev_info, 0, sizeof(struct rte_event_dev_info));
> ret = rte_event_dev_info_get(opt->dev_id, &dev_info);
> if (ret) {
> evt_err("failed to get eventdev info %d", opt->dev_id);
> diff --git a/app/test-eventdev/test_perf_queue.c b/app/test-eventdev/test_perf_queue.c
> index 5ef2e5a3ef9c..814ab9f9bd86 100644
> --- a/app/test-eventdev/test_perf_queue.c
> +++ b/app/test-eventdev/test_perf_queue.c
> @@ -215,7 +215,6 @@ perf_queue_eventdev_setup(struct evt_test *test, struct evt_options *opt)
>
> nb_queues = perf_queue_nb_event_queues(opt);
>
> - memset(&dev_info, 0, sizeof(struct rte_event_dev_info));
> ret = rte_event_dev_info_get(opt->dev_id, &dev_info);
> if (ret) {
> evt_err("failed to get eventdev info %d", opt->dev_id);
> --
> 2.35.1
>
prev parent reply other threads:[~2022-09-13 13:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 15:28 Stephen Hemminger
2022-09-13 13:54 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1MVVnde+F8TnfEq6capXmafaF7VPSoaiswB-7Szr6KUcg@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).