From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84AA7A2F18 for ; Thu, 3 Oct 2019 14:47:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B10991C0B2; Thu, 3 Oct 2019 14:47:24 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 5E8751C0AA for ; Thu, 3 Oct 2019 14:47:23 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id n26so5105697ioj.8 for ; Thu, 03 Oct 2019 05:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=njp3f6MU18T4V6gNNnm2P/jhjEuJOHIk6KNV6Y73Mjo=; b=m/zFisavW4lSe4Nfm1IoGZR3skqtCsRtrMQyW3eHpqcWPZKDwDtwDNhAgnkwaGRoBV texFMCW8j7KufLkaBis7f5SMv9ok5BB2Ov1QTMcci1HKaFV5uvbLHJdYmSB5kobW9yYZ HQx0fvWeThDiu5pK55pGfs7KmDKKM/ke2/xCHZ9u2qv0CpFQIWNCjUUjiwL8tdWlcVg+ +304WBl8wFXpyGCalFCZ6Q+Cx30+p8Kg7iecQIGkV4FrHZdHQziPLH0/qpw9N5GpiI9r YyrkdNS1GmwaFy3PxDpm9Y9An3iBuHdKlfDSvE9HxaQTphcKmtljYdL0nVz6LCQkXZ9l L3eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=njp3f6MU18T4V6gNNnm2P/jhjEuJOHIk6KNV6Y73Mjo=; b=fx6OC90KwTk6EO4rJFVc9mp6ZvSKhtkBAmx0PIDWpAlO5IxDIce/nDxnB/i4o6p8Lc OVix/ZTx42EFzIYWYOFJ314k0SpzEL7SLzQuiX7bJu1iZXAL7zrAnG7/gHXizt8nXubj AQxedIhtTRG2eHaf86mBH7A8uDWIGyZjAjS7cKZSBja8ghaVKAXLCyt53hE6nzWMIWlV I7LhRie6K/3DG569mhfFyHX58HkYN1YNWgM/+jpVXJ+vL5kFZQhN/YdUbY9kB1Yxz0IV 6qzoygxsg2oykugQpeTHXqT3Z7LMuh+B5GVsdYSRH5zAI46CdPe6IC5I9E/Z4cJhDuz1 5ICQ== X-Gm-Message-State: APjAAAX19Xgc86AG8E6+zW1uJAjaRV3+xOhJjUvvKfphYCAVZkbt75+c S4dJ5HU24NmMHMoE0+PDPKmxbq81PCvMlLjWPKY= X-Google-Smtp-Source: APXvYqwd3rjO5+mth4C0MnW7EatPLLSI+IW6LaCtisPyA7FAdeu7RtycI0jbyQHVI9Xbm1vu9Is5iQ/dpq4+hm2Xm8E= X-Received: by 2002:a92:de42:: with SMTP id e2mr9579737ilr.271.1570106842543; Thu, 03 Oct 2019 05:47:22 -0700 (PDT) MIME-Version: 1.0 References: <20190924094209.3827-1-pbhagavatula@marvell.com> <20191002205754.11746-1-pbhagavatula@marvell.com> In-Reply-To: From: Jerin Jacob Date: Thu, 3 Oct 2019 18:17:11 +0530 Message-ID: To: Hemant Agrawal Cc: Pavan Nikhilesh , Jerin Jacob , "Richardson, Bruce" , Akhil Goyal , dpdk-dev , "Van Haaren, Harry" , "mattias.ronnblom@ericsson.com" , "liang.j.ma@intel.com" , "Gujjar, Abhinandan S" , "Rao, Nikhil" , "erik.g.carrillo@intel.com" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 00/10] example/l2fwd-event: introduce l2fwd-event example X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 3, 2019 at 6:10 PM Hemant Agrawal wrote: > > Hi Jerin, > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Thursday, October 3, 2019 4:04 PM > > To: Pavan Nikhilesh > > Cc: Jerin Jacob ; Richardson, Bruce > > ; Akhil Goyal ; dpdk- > > dev ; Van Haaren, Harry ; > > mattias.ronnblom@ericsson.com; liang.j.ma@intel.com; Gujjar, Abhinandan > > S ; Rao, Nikhil ; > > Hemant Agrawal ; erik.g.carrillo@intel.com > > Subject: Re: [dpdk-dev] [PATCH v5 00/10] example/l2fwd-event: introduce > > l2fwd-event example > > Importance: High > > > > On Thu, Oct 3, 2019 at 2:28 AM wrote: > > > > > > From: Pavan Nikhilesh > > > > > > This patchset adds a new application to demonstrate the usage of event > > > mode. The poll mode is also available to help with the transition. > > > > > > The following new command line parameters are added: > > > --mode: Dictates the mode of operation either poll or event. > > > --eventq_sync: Dictates event synchronization mode either atomic or > > > ordered. > > > > > > Based on event device capability the configuration is done as follows: > > > - A single event device is enabled. > > > - The number of event ports is equal to the number of worker > > > cores enabled in the core mask. Additional event ports might > > > be configured based on Rx/Tx adapter capability. > > > - The number of event queues is equal to the number of ethernet > > > ports. If Tx adapter doesn't have internal port capability then > > > an additional single link event queue is used to enqueue events > > > to Tx adapter. > > > - Each event port is linked to all existing event queues. > > > - Dedicated Rx/Tx adapters for each Ethernet port. > > > > > > v5 Changes: > > > - Redo poll mode datapath by removing all the static globals. > > > - Fix event queue configuration when required queues are not available. > > > - Fix Rx/Tx adapter creation based on portmask. > > > - Update release notes. > > > - Unroll macro used to generate event mode functions. > > > > > > > > > > Adding all eventdev maintainers. > > > > I have some minor comments on Documentation. Other than that, The series > > looks good to me in general. > > Anyone else planning to review this code. If yes, We will wait for merging this > > patch after RC1. > > If no, then we can merge in RC1 if no objection. > [Hemant] > On a high level this series looks good to us. However currently we are in the process of testing it. > Will you please wait for our ack? Currently we are trying to completed it before RC1 OK. Will for NXP's Ack. > > Regards, > Hemant >