From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59CD2A04F3; Tue, 7 Jan 2020 18:58:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A19041DA08; Tue, 7 Jan 2020 18:58:29 +0100 (CET) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id A51C51D9EB for ; Tue, 7 Jan 2020 18:58:28 +0100 (CET) Received: by mail-io1-f66.google.com with SMTP id d15so267744iog.3 for ; Tue, 07 Jan 2020 09:58:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E5Tm1QDFpMkcQtR8O/REGaCfwhJF6YlnUZJylvodQI4=; b=AKQnXpPfyDljNtOIUGnogdATt4S4RKZMu/ul4T/+owI1hnh3tU3T5Gcz0+nLBGbpHZ uJdlXMifhjJ5+4Yr/5IeQ1RdPEiULd86MRkMs4S8Eb77rz6OpR4ntaul6tINP7mn9Vfh fydyz8yOgqqSCWWtqH52hH1FLtnnOGSTyTQW0OR8Oi9JHbXAq5ToRlLrFfRTRijD44ef Ki4JiFK9Xt951KgM3yGM7lkgdWofOdEmed4x8I9Lfkm6/YdyuEjCmqyFIMgcFPxxjL57 bTwwgrFczN/e83yGS5BqBrU/h1K8BFubwlO11hMlLcFPgw8fSPc2KDtoxlWNLLhA0RJg jAog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E5Tm1QDFpMkcQtR8O/REGaCfwhJF6YlnUZJylvodQI4=; b=XpsM/0c96/ScR2zV1AOLtom5CnuKcMeTnAfHhYpEMQPsUFWfEZb4ZyPbzYmu8oqjjb xoNvi4ovazisxnmgj1BT/+HAFPaFfIP4Nmoyac+w7Xx/OCB/3yjJp+gU99okP2U5qiLz C5sJl5z3+ztu0QqFEOKMp1ZyCfE3mqjU7QvaIRqmlxaBw5nEsgv9UIUbKDGW4ys1cIXn MakirnBjRluFh59sXMUJdY7lI0QvrCKCfP4d1MujK9qA0Q9QkX3Oiy0JSPBhzWrtXkIy zQroxxKfCI19aSMMDh78bL97jYhPFYDlbntTzvNDSF0KePHpxhQrkETzDjK3+g8sTK9u pMyw== X-Gm-Message-State: APjAAAX+KxE9izVQ0H7U48+ceth7mJE7Xk8jYnGpedoqQL4OaGnT+3Vl wuT98sNqeBYfK8D795xj9uYONlAwZqC4u/O2NeZhtlTEpeA= X-Google-Smtp-Source: APXvYqwudQzWJ4kiXlboKFkbpRE3eshgelCYf3syiLzjHq+XvMd3t1D6qfyxXRVICnif73GroKdKWCOJNLsr+w8/69g= X-Received: by 2002:a6b:c742:: with SMTP id x63mr136505iof.162.1578419907873; Tue, 07 Jan 2020 09:58:27 -0800 (PST) MIME-Version: 1.0 References: <20200107174056.9397-1-stephen@networkplumber.org> In-Reply-To: <20200107174056.9397-1-stephen@networkplumber.org> From: Jerin Jacob Date: Tue, 7 Jan 2020 23:28:11 +0530 Message-ID: To: Stephen Hemminger Cc: dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] testpmd: call cleanup on exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 7, 2020 at 11:11 PM Stephen Hemminger wrote: > > The rte_eal_cleanup code is not exercised by testpmd which > is the most used DPDK test tool. Add a call at end of program. > > This helps exercise free and close paths which can > be checked with tools like valgrind. > > Signed-off-by: Stephen Hemminger > --- > app/test-pmd/testpmd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index b3746822366f..a94ad19c8f5a 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3570,5 +3570,6 @@ main(int argc, char** argv) > return 1; > } > > + rte_eal_cleanup(); > return 0; # How about changing to "return rte_eal_cleanup()" to provide OS the correct stats? # IMO, we need the same in other applications main() and signal handler too. > } > -- > 2.20.1 >