From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07404A00C2; Fri, 14 Oct 2022 19:37:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8E27400D4; Fri, 14 Oct 2022 19:37:02 +0200 (CEST) Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) by mails.dpdk.org (Postfix) with ESMTP id 4F6744003C for ; Fri, 14 Oct 2022 19:37:01 +0200 (CEST) Received: by mail-qk1-f182.google.com with SMTP id a18so2955008qko.0 for ; Fri, 14 Oct 2022 10:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XhV6jKQ9DtSLfKWKY0prXZbx8Jj10lXwI/oS5VKY9ZU=; b=MucuglgsMt2SOHW7GRhTr1jyJnTEDQRhw41MxBGLoOH9r27WHWXw9ho20DdK8j4NN1 ZnTzKYwUAAwsHlUAA07KZSLfMtt5DwMzZEhWJaeiEtaIb6tfbcglTajQLmJ4fECGHJPD vHRWKa/WHDW0wR1oelvyLDV5CR21WmVFl8r5q3wtvJHnoXz2Sbm+LnYS3WkqK0VASL5Q YVbF5VhX3oCZT2IK7hXyCkuTXbRTOBNqbAlFEhviDYwjPY0gDgsraG3PE0+Dp+3BAfzj +4hBR+AUUZsT51iUfnxlIKU8Ilk4GTLdrYjn8D6dhblZwCZWuPDcg0248MJVG0jrq91l qlag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XhV6jKQ9DtSLfKWKY0prXZbx8Jj10lXwI/oS5VKY9ZU=; b=e1KBBragiaxsnspJzFqOwH3UAbKiSxG+u6ej5ys6KNrAi2RU2ftaQuqk36xQs9POF+ ptASSFyT0AFF23xmfpQ9s1x9GifDF/Exl8HGQpE0ieVE3MbZE6r1Egk90cWKh6ysCbt9 PAlkgNgrIch/3ZwHDLYhoT+98UlMZLLJHTx1EsNYJWFRzfCiX3WWGvfB4SHh5DBGWaiy K9lQFpERCszNM3TELOE5LcTosRkn14jLRa8QgioxayICKqOXefD0LgiLIJNkcUy6pU1X nAikecUFbWdkHOCF7ZZ/K1NU4itR42JwuuDqxD0dwCOY1+XZWE75GPOvZKFEUtaTplaF zh1w== X-Gm-Message-State: ACrzQf3+5BY4VsgNPUw+s0fSV7wd3d0gG0IdKBCpJC5R9Ok6CcznjFRM p6Rgm3PpONkx3JFpcxvAAjv6+PqDvm3IlAmrQN0= X-Google-Smtp-Source: AMsMyM5SArR60/vCWe2kecUCJjMJ9U0DmRV6we+B68CWuWihtozJrvc+fhdfFyY7nJN1DzhvvShNqGoksAvpQKuevWk= X-Received: by 2002:a37:4454:0:b0:6e7:9bd0:bf53 with SMTP id r81-20020a374454000000b006e79bd0bf53mr4649696qka.616.1665769020587; Fri, 14 Oct 2022 10:37:00 -0700 (PDT) MIME-Version: 1.0 References: <20221010145406.118880-1-mattias.ronnblom@ericsson.com> <20221010145406.118880-3-mattias.ronnblom@ericsson.com> <0e613472-bac9-9189-f4a6-ba8bee0a1961@ericsson.com> In-Reply-To: <0e613472-bac9-9189-f4a6-ba8bee0a1961@ericsson.com> From: Jerin Jacob Date: Fri, 14 Oct 2022 23:06:34 +0530 Message-ID: Subject: Re: [PATCH 2/4] eventdev: have ethernet Rx adapter appropriately report idle To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: "Naga Harish K, S V" , "Jayatheerthan, Jay" , "Carrillo, Erik G" , "Gujjar, Abhinandan S" , Jerin Jacob , "dev@dpdk.org" , "Van Haaren, Harry" , "hofors@lysator.liu.se" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 13, 2022 at 3:23 PM Mattias R=C3=B6nnblom wrote: > > On 2022-10-13 03:32, Naga Harish K, S V wrote: > > > > > >> -----Original Message----- > >> From: Jayatheerthan, Jay > >> Sent: Tuesday, October 11, 2022 12:40 PM > >> To: mattias.ronnblom ; Carrillo, Erik G > >> ; Gujjar, Abhinandan S > >> ; Jerin Jacob ; Naga > >> Harish K, S V > >> Cc: dev@dpdk.org; Van Haaren, Harry ; > >> hofors@lysator.liu.se; mattias.ronnblom > >> Subject: RE: [PATCH 2/4] eventdev: have ethernet Rx adapter appropriat= ely > >> report idle > >> > >> @Harish, Could you review the patch ? > >> > >> -Jay > >> > >>> > >>> done: > >>> - rx_adapter->stats.rx_intr_packets +=3D nb_rx; > >>> + if (nb_rx > 0) { > > > > How are the performance numbers before and after this patch? > > Trying to understand the performance impact, as new condition is added = to the service function Datapath. > > > I haven't tested the RX and TX adapters separately, but if you run them > on the same core, I get the following result: > > Without patches, with stats disabled: 16,0 Mpps > Without patches, with stats enabled: 16,1 Mpps > With patches, with stats disabled: 16,1 Mpps > With patches, with stats enabled: 16,2 Mpps > > So these patches, with this particular hardware, compiler, and test > application, adding a tiny bit of additional logic actually make the > RX+TX adapter perform better. This is contrary to what you might expect, > and I'm sure YMMV. > > Enabling service core statistics (which boils down to a 2x rdtsc and > some cheap arithmetic in rte_service.c) actually make the RX+TX adapter > core perform better, both before and after this patchset. Also contrary > to what you might expect. > > The results are consistent across multiple runs. > > GCC 11.2.0 and AMD Zen 3 @ 3,7 GHz. Event device is DSW and I/O is the > ring Ethdev. @Naga Harish K, S V @Jayatheerthan, Jay @Gujjar, Abhinandan S @Erik Gabriel Carrillo Planning to take this series for rc2. If there are no other comments, I will merge the series then.