From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A62242BF4; Wed, 31 May 2023 15:25:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A32B40A89; Wed, 31 May 2023 15:25:08 +0200 (CEST) Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) by mails.dpdk.org (Postfix) with ESMTP id 7534040A82 for ; Wed, 31 May 2023 15:25:06 +0200 (CEST) Received: by mail-ua1-f49.google.com with SMTP id a1e0cc1a2514c-786f7e1ea2fso1550256241.3 for ; Wed, 31 May 2023 06:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685539506; x=1688131506; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Yyo4sAYOpEL7xTn2iwaHbBt2P1nvuLu44y7bqYD4YII=; b=AzbvitzCqUqwoV9ps7ZsTIE+gCe6q9JLX6TCGoNpGndevSMrINWN+K7ezAMQa3Mono oxE3hSH7TUTGGoxncDuYfDeK+cwqEVuELRO2x0hdROYNMPGuWpM7GC/OzEK9909aEgYK g4JaIoMQHFsBbQ3FEpN+/+TKfmMxtO/TsvJwtLsiLlbBuBB+X0okB7WJVUwcU2moGg3Z VC15GCfDWPtGvwBvBXkXHGk8X1nqOx12nRxWtZBLGCJyEalng1mds+WI74zQosRQJEAW vzN4pa8A6aRV0hrnuRP4YuGZ8KBc89AkCONXypZHZTAPe1UBv2G49IeDXqDmcC+zKzbq YY7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685539506; x=1688131506; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yyo4sAYOpEL7xTn2iwaHbBt2P1nvuLu44y7bqYD4YII=; b=GFK6p4mMkNR69hXhF8F8YEWNGnv8lMhjXBviF4P8/yJIc6H2YohkM3t7iX/aiZeeNb 4fiANCUBqvSLyL2eLyz/tRP4aHCK7BxwwdZexqs8LLhj+gnt2PtqOqYVl1iwUNHl6SwV me3c0Q6o1H5iLukP9YE2BWeuRfGHvzaXdUjHqWBAuI+ENl3mexRMIveYcWU7ce8CI+3y PQbbR0rzl8fEHP7tQzOJWbghdCdAatcO3DpXNMGeNkTTMxs3cW9Gana95RL2NVGT7xpr Rbq8TIp0aWpKE2WXoUM0ukCSkqHITYF1tD00brZazSSk722e4SdhSsIn6OpT2xRz9+wt NCiQ== X-Gm-Message-State: AC+VfDw4XUlFsxChxo+2Xr7+7ziGChCtb7LelBP0CNArzGcQ891gc1Ti Ib8AVtbB/ecYkFbqfXz4nJAv9y+hQy26AU5hgsc= X-Google-Smtp-Source: ACHHUZ4aWABD9svIcQRCIEOUmwESShxvXwhPPHOqOwh+SR0N5OxrD+VKcIl49rOANtepmSPW3AdAcAGLWGndIGDuBaE= X-Received: by 2002:a1f:bdd6:0:b0:456:d8da:caf5 with SMTP id n205-20020a1fbdd6000000b00456d8dacaf5mr1498206vkf.8.1685539505655; Wed, 31 May 2023 06:25:05 -0700 (PDT) MIME-Version: 1.0 References: <20230530115301.3472521-1-schalla@marvell.com> <20230531103233.3476875-1-schalla@marvell.com> In-Reply-To: From: Jerin Jacob Date: Wed, 31 May 2023 18:54:39 +0530 Message-ID: Subject: Re: [PATCH v2] event/cnxk: fix LMTST write for single event mode To: Pavan Nikhilesh Bhagavatula Cc: Srujana Challa , Shijith Thotton , Rahul Bhansali , Jerin Jacob Kollanukkaran , "dev@dpdk.org" , Nithin Kumar Dabilpuram Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 31, 2023 at 4:25=E2=80=AFPM Pavan Nikhilesh Bhagavatula wrote: > > > > > -----Original Message----- > > From: Srujana Challa > > Sent: Wednesday, May 31, 2023 4:03 PM > > To: Pavan Nikhilesh Bhagavatula ; Shijith > > Thotton ; Rahul Bhansali ; > > Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org; Srujana Challa ; Nithin Kumar > > Dabilpuram > > Subject: [PATCH v2] event/cnxk: fix LMTST write for single event mode > > > > LMTST area can be overwritten before read by HW between to consecutive > > steorl operations. Hence, add wmb() after steorl op to make sure > > the LMTST operation is complete. > > > > Fixes: 313e884a22fd ("event/cnxk: support Tx adapter fast path") > > Cc: pbhagavatula@marvell.com > > > > Signed-off-by: Srujana Challa > > Acked-by: Pavan Nikhilesh Applied to dpdk-next-net-mrvl/for-next-net. Thanks > > > --- > > drivers/event/cnxk/cn10k_tx_worker.h | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/event/cnxk/cn10k_tx_worker.h > > b/drivers/event/cnxk/cn10k_tx_worker.h > > index c18786a14c..81fe31c4b9 100644 > > --- a/drivers/event/cnxk/cn10k_tx_worker.h > > +++ b/drivers/event/cnxk/cn10k_tx_worker.h > > @@ -43,7 +43,6 @@ cn10k_sso_tx_one(struct cn10k_sso_hws *ws, struct > > rte_mbuf *m, uint64_t *cmd, > > const uint64_t *txq_data, const uint32_t flags) > > { > > uint8_t lnum =3D 0, loff =3D 0, shft =3D 0; > > - uint16_t ref_cnt =3D m->refcnt; > > struct cn10k_eth_txq *txq; > > uintptr_t laddr; > > uint16_t segdw; > > @@ -98,10 +97,9 @@ cn10k_sso_tx_one(struct cn10k_sso_hws *ws, struct > > rte_mbuf *m, uint64_t *cmd, > > > > roc_lmt_submit_steorl(lmt_id, pa); > > > > - if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F) { > > - if (ref_cnt > 1) > > - rte_io_wmb(); > > - } > > + /* Memory barrier to make sure lmtst store completes */ > > + rte_io_wmb(); > > + > > return 1; > > } > > > > -- > > 2.25.1 >