From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2118AA04FD; Tue, 14 Jan 2020 09:03:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30AD81C2A7; Tue, 14 Jan 2020 09:03:08 +0100 (CET) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 575321C2A5 for ; Tue, 14 Jan 2020 09:03:06 +0100 (CET) Received: by mail-io1-f67.google.com with SMTP id b10so12792278iof.11 for ; Tue, 14 Jan 2020 00:03:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t7MFXLAQvoP8caf/t/P7ukqT3kCTNjhlgsnj8vyOfmo=; b=cAuuLhR/Wp0DMLoMURL+N7xJ0f0hIUxRBL3ca+KWvc29+dDWKBxBTnZaMQlgZJJbZm 33nJwWVrCTJ0euMf1uKdoAJQf0x7xL1Qr/doqhjy/rbZ/Zbnljg0mvBemDmCKfMmXO9Q JJQ/porY4TbbUvB2WFr4Mz+3PdHTdbmkwJfoIwGw/IT95Lucx9kgXCwO33Xwaq7GqbsN SUkj4nlUx0aGE4vDNHqmwIBQ+A9x1BfbJPr5XZ4uq7dgob0tybIuIX/JnrB/XRa9UHAf pUlZBDTGXtzOisxmlOM5vKyyxDKySA/vt3pC3EumvwyxgwW6bzCpCAeJ/LKpzcIqsib8 Vqdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t7MFXLAQvoP8caf/t/P7ukqT3kCTNjhlgsnj8vyOfmo=; b=Px7YaZmfePkWDaRkKAQHhD2cij9u2GJ17dw9HH1Cx5bS44rNWd2UlopQTlHcmicGIJ kQA+f0/EX/btuIGDzDbkQvvS6oR5PVl6Tj5dqG0d8ToA67445Y8nkoTmfVsErovQdk8N sch96ctJwXD+0yfjGl3QxNt8B86iJtivtZeH3ZjF1YFNaWFpDqunRWgALFb5cVvERHev +0PI6NAlRHN0aDrPwxCxWB/j7MkBTi1HUHKhKeTzBQLOt3wQhIjo1xECju65/9feMBGI XYc952og4Ht+nnH3QlaNSGyCrEU3BLCf5gzVoo5VMsxdh78+fFJ1/0tqbZA6Eb3hCGfY xRag== X-Gm-Message-State: APjAAAVyCLHFaFY6pcqAtYJGyRyD4AB5Cn0+VjBVezXsFlp4u5l8TfmJ lKIQ9In9WOspwm0rQttu/PmwKfhsQrsUoiEB07I= X-Google-Smtp-Source: APXvYqwsdVNscaAfxri/hxD60Crxve+5926CXvjJbUIareguBwdwfx/PPX7X75m8qO1bTIy+EWysJTTMrVk/JZtGql4= X-Received: by 2002:a5e:8e4d:: with SMTP id r13mr14898928ioo.60.1578988985567; Tue, 14 Jan 2020 00:03:05 -0800 (PST) MIME-Version: 1.0 References: <20200113050303.3511-1-ndabilpuram@marvell.com> In-Reply-To: <20200113050303.3511-1-ndabilpuram@marvell.com> From: Jerin Jacob Date: Tue, 14 Jan 2020 13:32:49 +0530 Message-ID: To: Nithin Dabilpuram , Ferruh Yigit Cc: Jerin Jacob , Vamsi Attunuru , Kiran Kumar K , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] common/octeotx2: add support for C0 silicon version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jan 13, 2020 at 10:33 AM Nithin Dabilpuram wrote: > > Avoid using PCI subsystem device id for SoC revision > identification and just use PCI revision id to support C0 silicon. > This patch also reduces SQB threshold to 70% to have > sufficient buffer before we overflow SQ. > > Signed-off-by: Nithin Dabilpuram Fixed the typo in subject s/octeotx2/octeontx2/ Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > --- > drivers/common/octeontx2/otx2_common.h | 3 --- > drivers/common/octeontx2/otx2_dev.h | 6 +----- > drivers/net/octeontx2/otx2_ethdev.h | 2 +- > 3 files changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/common/octeontx2/otx2_common.h b/drivers/common/octeontx2/otx2_common.h > index f62c45d..c64d373 100644 > --- a/drivers/common/octeontx2/otx2_common.h > +++ b/drivers/common/octeontx2/otx2_common.h > @@ -124,9 +124,6 @@ extern int otx2_logtype_dpi; > #define PCI_DEVID_OCTEONTX2_RVU_SDP_PF 0xA0f6 > #define PCI_DEVID_OCTEONTX2_RVU_SDP_VF 0xA0f7 > > -/* Subsystem Device ID */ > -#define PCI_SUBSYS_DEVID_96XX_95XX 0xB200 > - > /* > * REVID for RVU PCIe devices. > * Bits 0..1: minor pass > diff --git a/drivers/common/octeontx2/otx2_dev.h b/drivers/common/octeontx2/otx2_dev.h > index 7d9839c..0b0a949 100644 > --- a/drivers/common/octeontx2/otx2_dev.h > +++ b/drivers/common/octeontx2/otx2_dev.h > @@ -103,11 +103,7 @@ otx2_dev_init(struct rte_pci_device *pci_dev, void *otx2_dev) > return rc; > } > > - if (pci_dev->id.subsystem_device_id == PCI_SUBSYS_DEVID_96XX_95XX) > - dev->hwcap = rev_id; > - else > - dev->hwcap = 0; > - > + dev->hwcap = rev_id; > return otx2_dev_priv_init(pci_dev, otx2_dev); > } > > diff --git a/drivers/net/octeontx2/otx2_ethdev.h b/drivers/net/octeontx2/otx2_ethdev.h > index 987e760..7f1d0f0 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.h > +++ b/drivers/net/octeontx2/otx2_ethdev.h > @@ -79,7 +79,7 @@ > #define NIX_RX_NB_SEG_MAX 6 > #define NIX_CQ_ENTRY_SZ 128 > #define NIX_CQ_ALIGN 512 > -#define NIX_SQB_LOWER_THRESH 90 > +#define NIX_SQB_LOWER_THRESH 70 > #define LMT_SLOT_MASK 0x7f > #define NIX_RX_DEFAULT_RING_SZ 4096 > > -- > 2.8.4 >