From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F1A9A034F; Wed, 13 May 2020 18:24:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 089A61D65B; Wed, 13 May 2020 18:24:57 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id A27971D62C; Wed, 13 May 2020 18:24:55 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id k6so18661485iob.3; Wed, 13 May 2020 09:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sAHma7Yy/fYqndHq8Q8MPOoHi3toQs4Q+uTLTP2rOo8=; b=iYLZUL+GYSvY6t1djwA/WGMWQ6RSphtWoRXZbT6Pqr6ia1wPX20nHd7TlrbJRN1syo /9h0hliVH/tj9nciFZJyWdRXXZ+Pw/rtaUSllCxdrHvGN2l52C3sGlQ4kkCnDgQeB/bx B+mD+8S2pS70TgLZmErEx4Kmd2U5VL5/63ZQ2gVD1IrQHO5O+0RX8rxXjgYyDxrniEZ7 GpyriBudK8gOdSnb3fYy067QcTOXfFsgF6G30nzwBltu+Gn27019Q7UR0o0tp7vqCb9N pQUe1WImDcHOUr4S+8bCyEddFDtVUWjSq89+9O01iiw/gB3JCOVwod/6SBFIBsmrog5e EhCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sAHma7Yy/fYqndHq8Q8MPOoHi3toQs4Q+uTLTP2rOo8=; b=p9goBM0ZCEsHEvhLEscLRxH9svApySgGfJZa77nWXWlBz6OX7lorZl+LCjT0SDao7Z WlviJfei1sczdw0aqj0bo8ikBf8vmFi/kh/A6SdC/bqdmdTYp8Sf53kxnVvsh38TbFAH gVyS4OVU0AZP0lU0BbzNNd32h6Ecxp4TGHrw8wesREs75/8rVkFUD+W9o8c7k987rgcF eotzT/DF75HNlIDqXTmsixOUvAV6l9rdWFXkQmGg470DamI3o2u4bKWuEs0lXx9ODRgR IB+UMnx/S/98c9FdJoWXAqWMnm+h5BRw18/MRLkAufN4bAgGG3RO5Z7IcgTucDiDUx+m 4HoQ== X-Gm-Message-State: AOAM530V19FebOFic2gExsS1Axw/AsScCgVsZeboGbuRAweDs9xH1SsN xT+eKWgS443+ay8+/8HY8HFuEogNbZPahOL7jAg= X-Google-Smtp-Source: ABdhPJyOaQsKy/MlQe720QmCljtStjKVrdTWbtZx1P2XwpYKdxiVKcn6zNnIqdb3DGgxevAIOW//HPgMWA604yF1PkE= X-Received: by 2002:a5e:c70b:: with SMTP id f11mr52689iop.94.1589387094806; Wed, 13 May 2020 09:24:54 -0700 (PDT) MIME-Version: 1.0 References: <20200512004624.11114-1-rmody@marvell.com> In-Reply-To: <20200512004624.11114-1-rmody@marvell.com> From: Jerin Jacob Date: Wed, 13 May 2020 21:54:38 +0530 Message-ID: To: Rasesh Mody Cc: dpdk-dev , Jerin Jacob , Ferruh Yigit , GR-Everest-DPDK-Dev , dpdk stable , Shahed Shaikh , Igor Russkikh Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/qede: fix link state configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 12, 2020 at 6:16 AM Rasesh Mody wrote: > > Move link state enable/disable to dev_start() and dev_stop() > respectively. This will ensure when devices are stopped, > link status will be appropriately shown as down. > > Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") I assume you need this patch for -rc3. Please rebase the patch to dpdk-next-net-mrvl and send v2. log: git am -3 /tmp/to_merge/net-qede-fix-link-state-configuration Applying: net/qede: fix link state configuration error: sha1 information is lacking or useless (drivers/net/qede/qede_ethdev.c). error: could not build fake ancestor Patch failed at 0001 net/qede: fix link state configuration hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". HEAD is now at a8b8a8631 node: fix arm64 build with old gcc git am failed /tmp/g//net-qede-fix-link-state-configuration Wed 13 May 2020 09:51:26 PM IST > Cc: stable@dpdk.org > > Signed-off-by: Shahed Shaikh > Signed-off-by: Rasesh Mody > Signed-off-by: Igor Russkikh > --- > drivers/net/qede/qede_ethdev.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c > index bcd8252d9..9a5847076 100644 > --- a/drivers/net/qede/qede_ethdev.c > +++ b/drivers/net/qede/qede_ethdev.c > @@ -1150,6 +1150,9 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev) > if (qede_activate_vport(eth_dev, true)) > goto err; > > + /* Bring-up the link */ > + qede_dev_set_link_state(eth_dev, true); > + > /* Update link status */ > qede_link_update(eth_dev, 0); > > @@ -1179,6 +1182,12 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev) > */ > qede_assign_rxtx_handlers(eth_dev, true); > > + /* Bring the link down */ > + qede_dev_set_link_state(eth_dev, false); > + > + /* Update link status */ > + qede_link_update(eth_dev, 0); > + > /* Disable vport */ > if (qede_activate_vport(eth_dev, false)) > return; > @@ -1563,8 +1572,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev) > eth_dev->data->nb_rx_queues = 0; > eth_dev->data->nb_tx_queues = 0; > > - /* Bring the link down */ > - qede_dev_set_link_state(eth_dev, false); > qdev->ops->common->slowpath_stop(edev); > qdev->ops->common->remove(edev); > rte_intr_disable(&pci_dev->intr_handle); > @@ -2671,9 +2678,6 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) > > eth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops : &qede_eth_dev_ops; > > - /* Bring-up the link */ > - qede_dev_set_link_state(eth_dev, true); > - > adapter->num_tx_queues = 0; > adapter->num_rx_queues = 0; > SLIST_INIT(&adapter->arfs_info.arfs_list_head); > -- > 2.18.0 >