Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

[Jerin Jacob <jerinjacobk@gmail.com>]

On Wed, Nov 17, 2021 at 4:56 PM Elena Agostini <eagostini@nvidia.com> wrote:
>
> > On Wed, Nov 17, 2021 at 4:38 PM Elena Agostini <eagostini@nvidia.com> wrote:
>
> > >
>
> > > > External email: Use caution opening links or attachments
>
> > >
>
> > > >
>
> > >
>
> > > >
>
> > >
>
> > > > On Wed, 17 Nov 2021 03:04:59 +0000
>
> > >
>
> > > > <eagostini@nvidia.com> wrote:
>
> > >
>
> > > >
>
> > >
>
> > > > > From: Elena Agostini <eagostini@nvidia.com>
>
> > >
>
> > > > >
>
> > >
>
> > > > > This patch introduces GPU memory in testpmd through the gpudev library.
>
> > >
>
> > > > > Testpmd can be used for network benchmarks when using GPU memory
>
> > >
>
> > > > > instead of regular CPU memory to send and receive packets.
>
> > >
>
> > > > > This option is currently limited to iofwd engine to ensure
>
> > >
>
> > > > > no workload is applied on packets not accessible from the CPU.
>
> > >
>
> > > > >
>
> > >
>
> > > > > The options chose is --mbuf-size so buffer split feature across
>
> > >
>
> > > > > different mempools can be enabled.
>
> > >
>
> > > > >
>
> > >
>
> > > > > Signed-off-by: Elena Agostini <eagostini@nvidia.com>
>
> > >
>
> > > >
>
> > >
>
> > > > Won't this create a hard dependency of test-pmd on gpudev?
>
> > >
>
> > > > I thought gpudev was supposed to be optional
>
> > >
>
> > >
>
> > >
>
> > > Sure, let me submit another patch to make it optional
>
> >
>
> > Why to add yet another compile time macro everywhere in testpmd and
>
> > make hard to maintain?
>
> > Adding iofwd kind of code is very simple to add test/test-gpudev and
>
> > all GPU specific options
>
> > can be added in test-gpudev. It also helps to review the patches as
>
> > test cases focus on
>
> > each device class.
>
>
>
> Test-gpudev is standalone unit test to ensure gpudev functions work correctly.
>
> In testpmd instead, there is a connection between gpudev and the network.

I understand that. We had the same case with eventdev, where it needs to
work with network. Testpmd is already complicated, IMO, we should
focus only ethdev
test cases on testpmd, test-gpudev can use ethdev API to enable
networking requirements for gpudev.