From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CC39EA0C41;
	Wed, 17 Nov 2021 12:31:31 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B841B426D4;
	Wed, 17 Nov 2021 12:31:31 +0100 (CET)
Received: from mail-io1-f53.google.com (mail-io1-f53.google.com
 [209.85.166.53]) by mails.dpdk.org (Postfix) with ESMTP id F299C426D3
 for <dev@dpdk.org>; Wed, 17 Nov 2021 12:31:29 +0100 (CET)
Received: by mail-io1-f53.google.com with SMTP id z26so2620219iod.10
 for <dev@dpdk.org>; Wed, 17 Nov 2021 03:31:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=ZdsoaF3jZutXxEPnefh4ljbwDDisqSur7B11d2vHbVA=;
 b=QGwJEdhAEtcZN+ukBcNXQ2wT4i7SugV9XOqEGU/HolEt5TxDXVFlWXXut5F9+XuS1q
 bxR6oc445gwl8BK3ZBUfrnG47C64Cutd9sfJFf54pwwGSEXCe/5VLXoew2TJPK4mMr9y
 94LrSYNR5E3JUB71Oz3TapBhUTikn0ZcluR7JluSNF70uj5pmPmKYkdsk8aygHBOzkGV
 JrlbzaAq8oyYnWcAYOr+x2A/i2rXXE6xCEw/QuCeBsYJsb/V5K4IFD6TdfgfXyQe+0CM
 BPN710gEdWQna/mzVf/clXkf3TUtxZMnZGlmv0xvyiYYa0c0wjIdfJtLpVpowisj5NxQ
 iR3w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=ZdsoaF3jZutXxEPnefh4ljbwDDisqSur7B11d2vHbVA=;
 b=baOHRo4VDY7rw75qDsN4FWGHaKiPHpo52yxNTW67E06zRn8y/jy2ABMBbEKXK4idY1
 XADg871o1c4NYCm4rsPSEIpb63R9ij+T+x5cQII4JpbN7UAWTTqM2EtDISW21tOlGl5N
 z0j+CmPyXV+05hgLbMYdfqaZIcJ3LoXLsrJOM7OC5quzyJ2s8Aban0V2sGnT83HfNT/r
 w4AyFJUwTvXVfypjaVLbr64k6j2UPRhUhMB15xjnmkgi4E08kurAo4F/9XUy2E6xUdm2
 r2QwwSuI8SNHrItyv+kGFj+3vfi7wxKAQRVz1VathxC/AiOztqsLLODoSri2XDDpbBId
 lkdQ==
X-Gm-Message-State: AOAM533SCprDOujwws+GrDv14e0TJUIgmKFvBPMMK6SyFvducH8BfHGj
 UC+y/CM95KufFn6fDiqWoRGtFwkSX2Sqempivyw=
X-Google-Smtp-Source: ABdhPJyYg6jns9rqhDHmELVC5wMmp/mcI9JSi4loJbLFcnM8Epc80ToY5W6vR/giW3w8/m1rKlG8ZUX0cbu1zFc2JVQ=
X-Received: by 2002:a05:6602:2b0c:: with SMTP id
 p12mr10720964iov.199.1637148689391; 
 Wed, 17 Nov 2021 03:31:29 -0800 (PST)
MIME-Version: 1.0
References: <20211029204909.21318-1-eagostini@nvidia.com>
 <20211117030459.8274-1-eagostini@nvidia.com>
 <20211117030459.8274-2-eagostini@nvidia.com>
 <20211116133449.7b7d21d1@hermes.local>
 <DM6PR12MB4107105D4D1BC0D854372904CD9A9@DM6PR12MB4107.namprd12.prod.outlook.com>
 <CALBAE1PYFuXuPk21Zk77E-sHx9-NWKn+NYOnZ2BpOLYx4ekQAg@mail.gmail.com>
 <DM6PR12MB4107585DFA949264D9C7A79ACD9A9@DM6PR12MB4107.namprd12.prod.outlook.com>
In-Reply-To: <DM6PR12MB4107585DFA949264D9C7A79ACD9A9@DM6PR12MB4107.namprd12.prod.outlook.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Wed, 17 Nov 2021 17:01:03 +0530
Message-ID: <CALBAE1MauW7yrMsRgOdRRXkx4kMrEGqqtW+czoGndTajQDPfwA@mail.gmail.com>
Subject: Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools
To: Elena Agostini <eagostini@nvidia.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, 
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 Stephen Hemminger <stephen@networkplumber.org>, 
 "dev@dpdk.org" <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, Nov 17, 2021 at 4:56 PM Elena Agostini <eagostini@nvidia.com> wrote:
>
> > On Wed, Nov 17, 2021 at 4:38 PM Elena Agostini <eagostini@nvidia.com> wrote:
>
> > >
>
> > > > External email: Use caution opening links or attachments
>
> > >
>
> > > >
>
> > >
>
> > > >
>
> > >
>
> > > > On Wed, 17 Nov 2021 03:04:59 +0000
>
> > >
>
> > > > <eagostini@nvidia.com> wrote:
>
> > >
>
> > > >
>
> > >
>
> > > > > From: Elena Agostini <eagostini@nvidia.com>
>
> > >
>
> > > > >
>
> > >
>
> > > > > This patch introduces GPU memory in testpmd through the gpudev library.
>
> > >
>
> > > > > Testpmd can be used for network benchmarks when using GPU memory
>
> > >
>
> > > > > instead of regular CPU memory to send and receive packets.
>
> > >
>
> > > > > This option is currently limited to iofwd engine to ensure
>
> > >
>
> > > > > no workload is applied on packets not accessible from the CPU.
>
> > >
>
> > > > >
>
> > >
>
> > > > > The options chose is --mbuf-size so buffer split feature across
>
> > >
>
> > > > > different mempools can be enabled.
>
> > >
>
> > > > >
>
> > >
>
> > > > > Signed-off-by: Elena Agostini <eagostini@nvidia.com>
>
> > >
>
> > > >
>
> > >
>
> > > > Won't this create a hard dependency of test-pmd on gpudev?
>
> > >
>
> > > > I thought gpudev was supposed to be optional
>
> > >
>
> > >
>
> > >
>
> > > Sure, let me submit another patch to make it optional
>
> >
>
> > Why to add yet another compile time macro everywhere in testpmd and
>
> > make hard to maintain?
>
> > Adding iofwd kind of code is very simple to add test/test-gpudev and
>
> > all GPU specific options
>
> > can be added in test-gpudev. It also helps to review the patches as
>
> > test cases focus on
>
> > each device class.
>
>
>
> Test-gpudev is standalone unit test to ensure gpudev functions work correctly.
>
> In testpmd instead, there is a connection between gpudev and the network.

I understand that. We had the same case with eventdev, where it needs to
work with network. Testpmd is already complicated, IMO, we should
focus only ethdev
test cases on testpmd, test-gpudev can use ethdev API to enable
networking requirements for gpudev.