From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCCE541DB6; Thu, 2 Mar 2023 18:06:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE7E740E09; Thu, 2 Mar 2023 18:06:12 +0100 (CET) Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by mails.dpdk.org (Postfix) with ESMTP id 8C756400D6 for ; Thu, 2 Mar 2023 18:06:11 +0100 (CET) Received: by mail-vs1-f42.google.com with SMTP id f23so22953180vsa.13 for ; Thu, 02 Mar 2023 09:06:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k1O0zewgWfgZEg1zpPaeuhS+rRXlrCCgCnaXsaQs0oc=; b=Kf74F5BgFyQTvwyLhd3l1V1IqiaV3pRpozVhpQttnQvIzVbijhzr8G1/pBJUzQiBaA xqlS9pbSRKSVVpi+S1h4JeFDaSYycEVJTP+uhGjlkSvg6DP9I2eHhWZERIRSLxKhtOxz Q4Db15rUurA8i87RJFgv0pYIy+vXulHxxcoR9lBVD2zYB/UKI9EKpNKcO0PRi4cv0Tth DgRQXEWj+ABNn7dKOrVOqSrOECTO+nz2ivVxYjYmrW6OR85WKnm/T9zrW+EV4QyRxpvQ uEKbNNzElJD4CsJSnm3J9VlG/lFnYJdyZMblWAz9GGrJaeLrCszsgvBI37mHWE5SNqIs Q0Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k1O0zewgWfgZEg1zpPaeuhS+rRXlrCCgCnaXsaQs0oc=; b=fTXACBqWYIv+tULMP8f3tMuIdLig5Hai5G0SRGkvli1tdp4QPstS3zs+QlRJDGAG+U /QlYOQ7u/ihDce3qj35Pmc1tJIYVEWZbCUyAcELGnJ4QKqBaK9MoD7bG1EGabx36IUOR BaApt3TosKI5+yNFzgEE0m0zuGeku7f7GX8ZDW98bQBMDB+bli5NoBQk4+Awz8/5LQrA rzXtDzHxP6mvgLkXdkJGf9OR5jP7zHp5ySGKXTsDYH2nuf87ppx6Wqh87mglC+rphLTw 817pwNy/5/+GQaPQAk8ETuu1Ffhgt6RhGBbPnLJClxY49LIcA5vpmVy7zUzT5UnZf2FQ xH6g== X-Gm-Message-State: AO0yUKVG3dU5+lmGx/RoFqiBKGtzBGlHvLKDFQ1o3TWqGPV1n5C/mRaw iWAt+AeSPDho9/uJhWxKgSFiZqXriIgr3qy4GFmIpaFcnmU= X-Google-Smtp-Source: AK7set/MAmM05Fdqm6wa3PLNSQAiuXVf+IFa9BCwTqLM7DlZOLht7hz/6pkJtHdarOSWItmuvDdiefjgk11ivit6H6o= X-Received: by 2002:a05:6102:21b6:b0:421:7f84:f3d9 with SMTP id i22-20020a05610221b600b004217f84f3d9mr1764639vsb.3.1677776770803; Thu, 02 Mar 2023 09:06:10 -0800 (PST) MIME-Version: 1.0 References: <20230221143627.219917-1-sedara@marvell.com> <20230221143627.219917-3-sedara@marvell.com> In-Reply-To: <20230221143627.219917-3-sedara@marvell.com> From: Jerin Jacob Date: Thu, 2 Mar 2023 22:35:44 +0530 Message-ID: Subject: Re: [PATCH v1 2/2] net/octeon_ep: support port kind To: Sathesh Edara Cc: sburla@marvell.com, jerinj@marvell.com, Radha Mohan Chintakuntla , Veerasenareddy Burru , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 21, 2023 at 8:07=E2=80=AFPM Sathesh Edara = wrote: > > Added port kind functionality. > > Signed-off-by: Sathesh Edara Series applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/net/octeon_ep/otx_ep_common.h | 1 + > drivers/net/octeon_ep/otx_ep_ethdev.c | 2 +- > drivers/net/octeon_ep/otx_ep_rxtx.c | 16 ++++++++-------- > 3 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/octeon_ep/otx_ep_common.h b/drivers/net/octeon_e= p/otx_ep_common.h > index 7eb50af75a..e4c92270d4 100644 > --- a/drivers/net/octeon_ep/otx_ep_common.h > +++ b/drivers/net/octeon_ep/otx_ep_common.h > @@ -32,6 +32,7 @@ > #define OTX_EP_PCI_RING_ALIGN 65536 > #define SDP_PKIND 40 > #define SDP_OTX2_PKIND 57 > +#define SDP_OTX2_PKIND_FS0 0 > > #define ORDERED_TAG 0 > #define ATOMIC_TAG 1 > diff --git a/drivers/net/octeon_ep/otx_ep_ethdev.c b/drivers/net/octeon_e= p/otx_ep_ethdev.c > index 0930efedce..f43db1e398 100644 > --- a/drivers/net/octeon_ep/otx_ep_ethdev.c > +++ b/drivers/net/octeon_ep/otx_ep_ethdev.c > @@ -495,7 +495,7 @@ otx_ep_eth_dev_init(struct rte_eth_dev *eth_dev) > > otx_epdev_init(otx_epvf); > if (pdev->id.device_id =3D=3D PCI_DEVID_CN9K_EP_NET_VF) > - otx_epvf->pkind =3D SDP_OTX2_PKIND; > + otx_epvf->pkind =3D SDP_OTX2_PKIND_FS0; > else > otx_epvf->pkind =3D SDP_PKIND; > otx_ep_info("using pkind %d\n", otx_epvf->pkind); > diff --git a/drivers/net/octeon_ep/otx_ep_rxtx.c b/drivers/net/octeon_ep/= otx_ep_rxtx.c > index 59df6ad857..6912ca2401 100644 > --- a/drivers/net/octeon_ep/otx_ep_rxtx.c > +++ b/drivers/net/octeon_ep/otx_ep_rxtx.c > @@ -17,7 +17,8 @@ > #include "otx_ep_rxtx.h" > > /* SDP_LENGTH_S specifies packet length and is of 8-byte size */ > -#define INFO_SIZE 8 > +#define OTX_EP_INFO_SIZE 8 > +#define OTX_EP_FSZ_FS0 0 > #define DROQ_REFILL_THRESHOLD 16 > > static void > @@ -678,7 +679,7 @@ otx2_ep_xmit_pkts(void *tx_queue, struct rte_mbuf **p= kts, uint16_t nb_pkts) > iqcmd2.irh.u64 =3D 0; > > /* ih invars */ > - iqcmd2.ih.s.fsz =3D OTX2_EP_FSZ; > + iqcmd2.ih.s.fsz =3D OTX_EP_FSZ_FS0; > iqcmd2.ih.s.pkind =3D otx_ep->pkind; /* The SDK decided PKIND val= ue */ > /* irh invars */ > iqcmd2.irh.s.opcode =3D OTX_EP_NW_PKT_OP; > @@ -875,12 +876,11 @@ otx_ep_droq_read_packet(struct otx_ep_device *otx_e= p, > > info->length =3D rte_bswap64(info->length); > /* Deduce the actual data size */ > - total_pkt_len =3D info->length + INFO_SIZE; > + total_pkt_len =3D info->length + OTX_EP_INFO_SIZE; > if (total_pkt_len <=3D droq->buffer_size) { > - info->length -=3D OTX_EP_RH_SIZE; > droq_pkt =3D droq->recv_buf_list[droq->read_idx]; > if (likely(droq_pkt !=3D NULL)) { > - droq_pkt->data_off +=3D OTX_EP_DROQ_INFO_SIZE; > + droq_pkt->data_off +=3D OTX_EP_INFO_SIZE; > /* otx_ep_dbg("OQ: pkt_len[%ld], buffer_size %d\n= ", > * (long)info->length, droq->buffer_size); > */ > @@ -917,11 +917,11 @@ otx_ep_droq_read_packet(struct otx_ep_device *otx_e= p, > droq_pkt->port =3D otx_ep->port_id; > if (!pkt_len) { > droq_pkt->data_off +=3D > - OTX_EP_DROQ_INFO_SIZE; > + OTX_EP_INFO_SIZE; > droq_pkt->pkt_len =3D > - cpy_len - OTX_EP_DROQ_INF= O_SIZE; > + cpy_len - OTX_EP_INFO_SIZ= E; > droq_pkt->data_len =3D > - cpy_len - OTX_EP_DROQ_INF= O_SIZE; > + cpy_len - OTX_EP_INFO_SIZ= E; > } else { > droq_pkt->pkt_len =3D cpy_len; > droq_pkt->data_len =3D cpy_len; > -- > 2.31.1 >