From: Jerin Jacob <jerinjacobk@gmail.com>
To: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dpdk-dev <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>
Subject: Re: [PATCH] net/cnxk: fix out of bounds access in cmd array
Date: Thu, 5 May 2022 14:10:08 +0530 [thread overview]
Message-ID: <CALBAE1MevgQkiiu8asP++PUbzmhnGxh9jjpadqT7s0s_KjEYpw@mail.gmail.com> (raw)
In-Reply-To: <20220424162326.1680962-1-gmuthukrishn@marvell.com>
On Sun, Apr 24, 2022 at 9:53 PM Gowrishankar Muthukrishnan
<gmuthukrishn@marvell.com> wrote:
>
> Fix out of bounds access in cmd array which was reported in coverity
> scan.
>
> Coverity issue: 375245, 375246, 375260, 375263, 375264, 375271, 375278,
> 375279, 375273, 375274, 375275, 375276, 375280, 375281,
> 375283, 375286
> Fixes: c5b97e98837 ("net/cnxk: add cn10k template Tx functions to build")
> Fixes: dd8c20eee47 ("net/cnxk: add cn9k template Tx functions to build")
>
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
> ---
> drivers/net/cnxk/cn10k_tx.h | 32 ++++++++++++++++----------------
> drivers/net/cnxk/cn9k_tx.h | 32 ++++++++++++++++----------------
> 2 files changed, 32 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h
> index 5d4003c5d4..85eba90334 100644
> --- a/drivers/net/cnxk/cn10k_tx.h
> +++ b/drivers/net/cnxk/cn10k_tx.h
> @@ -2728,18 +2728,18 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, uint64_t *ws,
>
> /* [T_SEC_F] [TSP] [TSO] [NOFF] [VLAN] [OL3OL4CSUM] [L3L4CSUM] */
> #define NIX_TX_FASTPATH_MODES_0_15 \
> - T(no_offload, 4, NIX_TX_OFFLOAD_NONE) \
> - T(l3l4csum, 4, L3L4CSUM_F) \
> - T(ol3ol4csum, 4, OL3OL4CSUM_F) \
> - T(ol3ol4csum_l3l4csum, 4, OL3OL4CSUM_F | L3L4CSUM_F) \
> + T(no_offload, 6, NIX_TX_OFFLOAD_NONE) \
> + T(l3l4csum, 6, L3L4CSUM_F) \
> + T(ol3ol4csum, 6, OL3OL4CSUM_F) \
> + T(ol3ol4csum_l3l4csum, 6, OL3OL4CSUM_F | L3L4CSUM_F) \
> T(vlan, 6, VLAN_F) \
> T(vlan_l3l4csum, 6, VLAN_F | L3L4CSUM_F) \
> T(vlan_ol3ol4csum, 6, VLAN_F | OL3OL4CSUM_F) \
> T(vlan_ol3ol4csum_l3l4csum, 6, VLAN_F | OL3OL4CSUM_F | L3L4CSUM_F) \
> - T(noff, 4, NOFF_F) \
> - T(noff_l3l4csum, 4, NOFF_F | L3L4CSUM_F) \
> - T(noff_ol3ol4csum, 4, NOFF_F | OL3OL4CSUM_F) \
> - T(noff_ol3ol4csum_l3l4csum, 4, NOFF_F | OL3OL4CSUM_F | L3L4CSUM_F) \
> + T(noff, 6, NOFF_F) \
> + T(noff_l3l4csum, 6, NOFF_F | L3L4CSUM_F) \
> + T(noff_ol3ol4csum, 6, NOFF_F | OL3OL4CSUM_F) \
> + T(noff_ol3ol4csum_l3l4csum, 6, NOFF_F | OL3OL4CSUM_F | L3L4CSUM_F) \
> T(noff_vlan, 6, NOFF_F | VLAN_F) \
> T(noff_vlan_l3l4csum, 6, NOFF_F | VLAN_F | L3L4CSUM_F) \
> T(noff_vlan_ol3ol4csum, 6, NOFF_F | VLAN_F | OL3OL4CSUM_F) \
> @@ -2813,19 +2813,19 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, uint64_t *ws,
> TSP_F | TSO_F | NOFF_F | VLAN_F | OL3OL4CSUM_F | L3L4CSUM_F)
>
> #define NIX_TX_FASTPATH_MODES_64_79 \
> - T(sec, 4, T_SEC_F) \
> - T(sec_l3l4csum, 4, T_SEC_F | L3L4CSUM_F) \
> - T(sec_ol3ol4csum, 4, T_SEC_F | OL3OL4CSUM_F) \
> - T(sec_ol3ol4csum_l3l4csum, 4, T_SEC_F | OL3OL4CSUM_F | L3L4CSUM_F) \
> + T(sec, 6, T_SEC_F) \
> + T(sec_l3l4csum, 6, T_SEC_F | L3L4CSUM_F) \
> + T(sec_ol3ol4csum, 6, T_SEC_F | OL3OL4CSUM_F) \
> + T(sec_ol3ol4csum_l3l4csum, 6, T_SEC_F | OL3OL4CSUM_F | L3L4CSUM_F) \
> T(sec_vlan, 6, T_SEC_F | VLAN_F) \
> T(sec_vlan_l3l4csum, 6, T_SEC_F | VLAN_F | L3L4CSUM_F) \
> T(sec_vlan_ol3ol4csum, 6, T_SEC_F | VLAN_F | OL3OL4CSUM_F) \
> T(sec_vlan_ol3ol4csum_l3l4csum, 6, \
> T_SEC_F | VLAN_F | OL3OL4CSUM_F | L3L4CSUM_F) \
> - T(sec_noff, 4, T_SEC_F | NOFF_F) \
> - T(sec_noff_l3l4csum, 4, T_SEC_F | NOFF_F | L3L4CSUM_F) \
> - T(sec_noff_ol3ol4csum, 4, T_SEC_F | NOFF_F | OL3OL4CSUM_F) \
> - T(sec_noff_ol3ol4csum_l3l4csum, 4, \
> + T(sec_noff, 6, T_SEC_F | NOFF_F) \
> + T(sec_noff_l3l4csum, 6, T_SEC_F | NOFF_F | L3L4CSUM_F) \
> + T(sec_noff_ol3ol4csum, 6, T_SEC_F | NOFF_F | OL3OL4CSUM_F) \
> + T(sec_noff_ol3ol4csum_l3l4csum, 6, \
> T_SEC_F | NOFF_F | OL3OL4CSUM_F | L3L4CSUM_F) \
> T(sec_noff_vlan, 6, T_SEC_F | NOFF_F | VLAN_F) \
> T(sec_noff_vlan_l3l4csum, 6, T_SEC_F | NOFF_F | VLAN_F | L3L4CSUM_F) \
> diff --git a/drivers/net/cnxk/cn9k_tx.h b/drivers/net/cnxk/cn9k_tx.h
> index a0611a67c9..6ce81f5c96 100644
> --- a/drivers/net/cnxk/cn9k_tx.h
> +++ b/drivers/net/cnxk/cn9k_tx.h
> @@ -1903,18 +1903,18 @@ cn9k_nix_xmit_pkts_vector(void *tx_queue, struct rte_mbuf **tx_pkts,
>
> /* [T_SEC_F] [TSP] [TSO] [NOFF] [VLAN] [OL3OL4CSUM] [L3L4CSUM] */
> #define NIX_TX_FASTPATH_MODES_0_15 \
> - T(no_offload, 4, NIX_TX_OFFLOAD_NONE) \
> - T(l3l4csum, 4, L3L4CSUM_F) \
> - T(ol3ol4csum, 4, OL3OL4CSUM_F) \
> - T(ol3ol4csum_l3l4csum, 4, OL3OL4CSUM_F | L3L4CSUM_F) \
> + T(no_offload, 6, NIX_TX_OFFLOAD_NONE) \
> + T(l3l4csum, 6, L3L4CSUM_F) \
> + T(ol3ol4csum, 6, OL3OL4CSUM_F) \
> + T(ol3ol4csum_l3l4csum, 6, OL3OL4CSUM_F | L3L4CSUM_F) \
> T(vlan, 6, VLAN_F) \
> T(vlan_l3l4csum, 6, VLAN_F | L3L4CSUM_F) \
> T(vlan_ol3ol4csum, 6, VLAN_F | OL3OL4CSUM_F) \
> T(vlan_ol3ol4csum_l3l4csum, 6, VLAN_F | OL3OL4CSUM_F | L3L4CSUM_F) \
> - T(noff, 4, NOFF_F) \
> - T(noff_l3l4csum, 4, NOFF_F | L3L4CSUM_F) \
> - T(noff_ol3ol4csum, 4, NOFF_F | OL3OL4CSUM_F) \
> - T(noff_ol3ol4csum_l3l4csum, 4, NOFF_F | OL3OL4CSUM_F | L3L4CSUM_F) \
> + T(noff, 6, NOFF_F) \
> + T(noff_l3l4csum, 6, NOFF_F | L3L4CSUM_F) \
> + T(noff_ol3ol4csum, 6, NOFF_F | OL3OL4CSUM_F) \
> + T(noff_ol3ol4csum_l3l4csum, 6, NOFF_F | OL3OL4CSUM_F | L3L4CSUM_F) \
> T(noff_vlan, 6, NOFF_F | VLAN_F) \
> T(noff_vlan_l3l4csum, 6, NOFF_F | VLAN_F | L3L4CSUM_F) \
> T(noff_vlan_ol3ol4csum, 6, NOFF_F | VLAN_F | OL3OL4CSUM_F) \
> @@ -1988,19 +1988,19 @@ cn9k_nix_xmit_pkts_vector(void *tx_queue, struct rte_mbuf **tx_pkts,
> TSP_F | TSO_F | NOFF_F | VLAN_F | OL3OL4CSUM_F | L3L4CSUM_F)
>
> #define NIX_TX_FASTPATH_MODES_64_79 \
> - T(sec, 4, T_SEC_F) \
> - T(sec_l3l4csum, 4, T_SEC_F | L3L4CSUM_F) \
> - T(sec_ol3ol4csum, 4, T_SEC_F | OL3OL4CSUM_F) \
> - T(sec_ol3ol4csum_l3l4csum, 4, T_SEC_F | OL3OL4CSUM_F | L3L4CSUM_F) \
> + T(sec, 6, T_SEC_F) \
> + T(sec_l3l4csum, 6, T_SEC_F | L3L4CSUM_F) \
> + T(sec_ol3ol4csum, 6, T_SEC_F | OL3OL4CSUM_F) \
> + T(sec_ol3ol4csum_l3l4csum, 6, T_SEC_F | OL3OL4CSUM_F | L3L4CSUM_F) \
> T(sec_vlan, 6, T_SEC_F | VLAN_F) \
> T(sec_vlan_l3l4csum, 6, T_SEC_F | VLAN_F | L3L4CSUM_F) \
> T(sec_vlan_ol3ol4csum, 6, T_SEC_F | VLAN_F | OL3OL4CSUM_F) \
> T(sec_vlan_ol3ol4csum_l3l4csum, 6, \
> T_SEC_F | VLAN_F | OL3OL4CSUM_F | L3L4CSUM_F) \
> - T(sec_noff, 4, T_SEC_F | NOFF_F) \
> - T(sec_noff_l3l4csum, 4, T_SEC_F | NOFF_F | L3L4CSUM_F) \
> - T(sec_noff_ol3ol4csum, 4, T_SEC_F | NOFF_F | OL3OL4CSUM_F) \
> - T(sec_noff_ol3ol4csum_l3l4csum, 4, \
> + T(sec_noff, 6, T_SEC_F | NOFF_F) \
> + T(sec_noff_l3l4csum, 6, T_SEC_F | NOFF_F | L3L4CSUM_F) \
> + T(sec_noff_ol3ol4csum, 6, T_SEC_F | NOFF_F | OL3OL4CSUM_F) \
> + T(sec_noff_ol3ol4csum_l3l4csum, 6, \
> T_SEC_F | NOFF_F | OL3OL4CSUM_F | L3L4CSUM_F) \
> T(sec_noff_vlan, 6, T_SEC_F | NOFF_F | VLAN_F) \
> T(sec_noff_vlan_l3l4csum, 6, T_SEC_F | NOFF_F | VLAN_F | L3L4CSUM_F) \
> --
> 2.25.1
>
prev parent reply other threads:[~2022-05-05 8:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-24 16:23 Gowrishankar Muthukrishnan
2022-05-05 8:40 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1MevgQkiiu8asP++PUbzmhnGxh9jjpadqT7s0s_KjEYpw@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=gmuthukrishn@marvell.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).