From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08C3DA0598; Sat, 18 Apr 2020 12:05:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D93751E92D; Sat, 18 Apr 2020 12:05:29 +0200 (CEST) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id 247331C29D for ; Sat, 18 Apr 2020 12:05:29 +0200 (CEST) Received: by mail-il1-f194.google.com with SMTP id s10so3996427iln.11 for ; Sat, 18 Apr 2020 03:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1vmft9WKNlZg/crcuOoHu2QUSBI4IVaZlwOxtNbeH18=; b=Gq8QPUTkMw8SOBkMGXpaAqnC0YPyBd5KwE/gCnRHqonP0CII6KRwFkTEZFssNbrGky 5NcaJEK+Q8WEAPjd8Qro2irh8KkP+08sPGDoxyXiLp4X+HVQddUY2pZrseFGmwsBtdZ+ 7uJmxY7+Rfc+1AJPJ9DFgaJJ2cri5e0Stw+e0XmJo9Hsf9fHnsHTe+lfGjq85bWes429 BvlwQfTiZfvX3Vt4rJUPx2ikSL2xKg0ZiE7XzDIBAxYovYMmDHPopefOh1WjBEcstAtJ zSjKs0ZZ7SeV+Q2iOMlnOr2JadLY9D3OFyFNAjbK3jXQUFuuJuxL9aT/HZ6HxFtZp+4E P9nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1vmft9WKNlZg/crcuOoHu2QUSBI4IVaZlwOxtNbeH18=; b=qAYluZNgHNxKISVDESvE/6Fnka3MAAMagXpraIu1F1jwdmGexsUC1W2ZGS0wONVvXe AsKF1Uxo55B2ea7/dO/gnR0+fkIeIt82Oeb8ievCay/0mL93TSh8UUgzWfHK5WrOCNet Qb2BMChhcVrbED2FeWGgPQJSb1a48kEOUYoCsUB7Lgkb1UnXzkbxm93tA1zPTWOzVl4c JwHYdRyKHCTpNB/swEMKL7X19MYDwvgeVY5lw7lF+Buqs84fmM84iXdM+Y3hGKpSsizQ 2VllspV95q4OCLS6Ekuca2/pirOGfeH1KAbu+3e9sDKP8pbyfhrSsF5fKkTH7rBcgMyD NpWg== X-Gm-Message-State: AGi0Puag35SvSkAaNrAcWRq4V+pThBbE/FlinkVIhDkFTHOSEZPHCDB5 iVm9/jVvHbeMvYLTh8uvJzc7iElG8i1Vqi0fMeg= X-Google-Smtp-Source: APiQypL5Z6//CaMOPgcVJWoMCV0e6hcoCde/0O7fEBCoyVIMHFOYXLhZ9tCyTnOvgcDnCSi9CFydUWLZ4j3aV8U8zNQ= X-Received: by 2002:a92:9edb:: with SMTP id s88mr7455226ilk.294.1587204328342; Sat, 18 Apr 2020 03:05:28 -0700 (PDT) MIME-Version: 1.0 References: <20200417215739.23180-1-l.wojciechow@partner.samsung.com> <20200417215739.23180-5-l.wojciechow@partner.samsung.com> <4136788.dT8XKq9c71@thomas> In-Reply-To: <4136788.dT8XKq9c71@thomas> From: Jerin Jacob Date: Sat, 18 Apr 2020 15:35:12 +0530 Message-ID: To: Thomas Monjalon Cc: Lukasz Wojciechowski , Nikhil Rao , Erik Gabriel Carrillo , Jerin Jacob Kollanukkaran , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] [PATCH v1 04/17] eventdev: replace library debug flag with global one X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Apr 18, 2020 at 3:23 PM Thomas Monjalon wrote: > > 18/04/2020 11:41, Jerin Jacob Kollanukkaran: > > From: Lukasz Wojciechowski > > > Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_EVENTDEV_DEBUG. > > > The old define is completely removed from source code and config. > > > > > > May I know the rational for this change? > > You know the rationale, it was discussed several times in Technical Board: If I already know the rationale, Why should I ask in ml? > we are limiting the number of compilation options, and meson config does > not propose them. > > > Other subsystem like ethdev still have CONFIG_RTE_LIBRTE_ETHDEV_DEBUG=n. > > No, look at the other patches in the series. > > > If we decide to make RTE_DEBUG then please submit the patch for all subsystem > > across the DPDK. > > Yes, this is what Lukasz did. I missed the series. I just thought it is a single email due to email filters. My bad. > > >