From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86A754296D; Mon, 17 Apr 2023 14:52:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A03040DFB; Mon, 17 Apr 2023 14:52:29 +0200 (CEST) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id 364FD40698 for ; Mon, 17 Apr 2023 14:52:28 +0200 (CEST) Received: by mail-pg1-f172.google.com with SMTP id r17so11481287pgr.1 for ; Mon, 17 Apr 2023 05:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681735947; x=1684327947; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QvOfMDexHQW2AphWaHh3WtllzXrnQ23yylbxVD1QMAs=; b=D86WV2IrNoLa9anpbfH9OMPO99Xg1LGEH5KuLEAhEeeNBnRDxES7mNhl3FsD++EpqV pWqukVIxAPoZsHBRuSlAU9wen/UidlmWgvD+GHXi5PgV22nqpHb/p+b1q0Bi1ZAkDbux ftghSbd6HWfG8UO4gjIR1HggLSx42IC9sBTm8LUnPiuTj1oN0onoe7D8bG+RNO/CMPbV pi/1XG1ugTF4zJh3tY7gUknT3RPB/z+KdHcWoQjciMvKLJUx+FtnbbSLaxncMmy/m1uc tjqCeObUJ2j8zwcul15brJpmo6YuhZiz343dulcYyGtZwfQRGKBoaKbFeO0COMs+J61T hNPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681735947; x=1684327947; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QvOfMDexHQW2AphWaHh3WtllzXrnQ23yylbxVD1QMAs=; b=P6cFcpXSmHOaTalDpCQpm8noC8BIV7H/ZFzXJH2+37VWYIvC2NzYfIbuDU34eZ5IO3 SPlck6D16X+PMYo/IabFGQS+h5pfmVd5AyY62IZzrF53MPNzbBy0g9f0h1WAgP4q34v8 xY2//Gwuh59uq9UwyxxicCGzdibBkjJSEz7SsUoKmsGXD+X2c9uI9V0dbBreuJ1pH+Kt qp7ys5Ztw6NytepzcZ0Ct7xLS3xayFygih7j+Arr9i03TrkAj9/b3WY6IImLFrhm4vQL 2yEforNCp7jPx2t+qGz4AZYBuzDuVU7a/yLAvF7r+QAquVOswDBFtVlrFVts4UPQ1m3V 6H1Q== X-Gm-Message-State: AAQBX9d1tYJei2nbLBGd4ZzevRgsEeovsMR3kLnenRpgWTKWUanvgeRW vXvGQrRv1N+31ovClVQ3oKTLlUX94AuMIDFugBQ= X-Google-Smtp-Source: AKy350asHsCOvOyVlJ3r2wZz8BTr6kHdhvAKjVJie5tNyLDsa5I2ByCqYoVk0NU7EtFVRED6rrrw50ySsWzNS3x12D0= X-Received: by 2002:a63:a0f:0:b0:51b:50f0:e487 with SMTP id 15-20020a630a0f000000b0051b50f0e487mr3101131pgk.9.1681735947168; Mon, 17 Apr 2023 05:52:27 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jerin Jacob Date: Mon, 17 Apr 2023 18:22:00 +0530 Message-ID: Subject: Re: Event device early back-pressure indication To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: Jerin Jacob Kollanukkaran , "timothy.mcdaniel@intel.com" , Hemant Agrawal , Harry van Haaren , "dev@dpdk.org" , =?UTF-8?B?U3ZhbnRlIErDpHJ2c3Ryw6V0?= , Heng Wang , Stefan Sundkvist , Peter Nilsson , Maria Lingemark Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 13, 2023 at 12:24=E2=80=AFPM Mattias R=C3=B6nnblom wrote: > > > void > rte_event_return_new_credits(...); > > Thoughts? I see the following cons on this approach. # Adding multiple APIs in fast path to driver layer may not performance effective solution. # At least for cnxk HW, credits are for device, not per port. So cnxk HW implementation can not use this scheme. Alternative solution could be, adding new flag for rte_enqueue_new_burst(), where drivers waits until credit is available to reduce the application overhead and support in different HW implementations if this use case critical. #define RTE_EVENT_FLAG_WAIT_TILL_CREDIT_AVILABLE (UINT32_C(1) << 0) > > Best regards, > Mattias