From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C58C9A2EFC for ; Tue, 15 Oct 2019 18:19:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 384C01ED69; Tue, 15 Oct 2019 18:19:38 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id E05E61ED42 for ; Tue, 15 Oct 2019 18:19:36 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id n26so47181638ioj.8 for ; Tue, 15 Oct 2019 09:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DrHVIrQCy9gFIpK5Ohw4prUafnTDvGiA7GRe/kVgQ2w=; b=Gzd4f8UzoJn+HVni21uk6AYq2+J8BHfwW4pJpWH9LaKC2ti0PScxIXFSf3BF80jNeq bHk/ttDnPjI0b7nnV8GOHDiZO2UzDHVquqoYYGaWjtKcyHW/prKMEjGylKfyh7ZsA3pW E6y5Py44sK50FUA2UkEl7nknCxtDj/CB1GjhVHDGCL8twAqowM/P7PuokoAiXQCpfbyu x6qv268n78n/MW+ocOuIYe8Ug9HGeNR8FUHVeTMfRWKnnXEpeqMhNqRlhC8dzzZJCiLS n0Kt8+/q89amwslH45nEG41vqTUOhOx7t13PEx9crxeTcJ/6plq3MNPCHJSmi5VK3Alb tCcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DrHVIrQCy9gFIpK5Ohw4prUafnTDvGiA7GRe/kVgQ2w=; b=AKP7tElfIhq6HtAK0bIVt6BmmYjNmV+OVCOCsY8BpToCnFkpaUCdT4G2lyje9ok9z6 ZXQkxET4P4bQuo06xu0ABs41N8NE2qV6zm7VpM5VWvOPS45MLK1ZNMQNCksZIN8EmAPw vd8uryyhk+A386gkHT5jsLFd6YvhsbLbe474tDuZRPE8ITKA1Vnx7YAQEQcIo8g2H0X8 vXUK50TQR1iv8N9lhFaS67PmuFG+b4Wr0eKOyrxSkJsU1xEVDA4gevH/OpNYTujtEZoA ourIHQ7y+GPsStoqY2Za1lqg5uv2ijrqNFj2AkE8FESgyeifq0yDMErWYRtWq1vYSxYA ynWA== X-Gm-Message-State: APjAAAWuz15XZb6DuApD3BRjaaa59bkDE/UpOGju1TK8TMiKl8qay4Ku gDxc/PLfqtec0HgBvBvny9D09IVnd0lVNuJOKzo= X-Google-Smtp-Source: APXvYqzr4eH/C2aVy+WYUOS23yu8qSoBoyhVb/H/b/GFgaKb8Wy0yJfjoV7iqgvzA3QfvH2W2E6825GSAHcRbPO1CLc= X-Received: by 2002:a92:c60f:: with SMTP id p15mr7012668ilm.162.1571156375947; Tue, 15 Oct 2019 09:19:35 -0700 (PDT) MIME-Version: 1.0 References: <20190730155726.26450-1-thomas@monjalon.net> <8145f03d-0911-91a8-73ee-9febe0c1dbec@linux.intel.com> <06588c18-4931-1328-fafe-73c4c02f5c17@intel.com> In-Reply-To: <06588c18-4931-1328-fafe-73c4c02f5c17@intel.com> From: Jerin Jacob Date: Tue, 15 Oct 2019 21:49:24 +0530 Message-ID: To: Ferruh Yigit Cc: Andrew Rybchenko , "Yigit, Ferruh" , Thomas Monjalon , John McNamara , Marko Kovacevic , Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , Beilei Xing , Qi Zhang , Wenzhuo Lu , Rosen Xu , Konstantin Ananyev , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , Rasesh Mody , Shahed Shaikh , dpdk-dev , David Marchand , Adrien Mazarguil Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 15, 2019 at 9:26 PM Ferruh Yigit wrote: > > On 10/15/2019 3:16 PM, Jerin Jacob wrote: > >>>>> @@ -36,13 +36,6 @@ VMDq = > >>>>> SR-IOV = > >>>>> DCB = > >>>>> VLAN filter = > >>>>> -Ethertype filter = > >>>>> -N-tuple filter = > >>>>> -SYN filter = > >>>>> -Tunnel filter = > >>>>> -Flexible filter = > >>>>> -Hash filter = > >>>>> -Flow director = > >>>>> Flow control = > >>>>> Flow API = > >>>>> Rate limitation = > >>>> I suggest adding these features back! > >>>> > >>>> "Flow director" and other filters are features that device/driver supports. > >>>> > >>>> And "Flow API" and "filter_ctrl" are methods used to implement these features. > >>>> Indeed they are only different APIs to get input from application/user. > >>>> > >>>> It doesn't really mean much to say "Flow API" is supported? So what is really > >>>> supported? It matters more what feature is supported. > >>>> > >>>> Since we are saying old method is deprecated, we can update the feature list of > >>>> drivers which implements filtering features using old method as not supported. > >>>> And that is the case with this patch since old APIs are marked as deprecated, > >>>> users can't use them to enable a filtering feature. > >>>> > >>>> Indeed I am for removing the "Flow API" from feature list, first it is not a > >>>> feature, second if it is only method to enable a filtering, and if filtering is > >>>> enabled in a driver, what is the point of redundant "Flow API" listing? > >>>> > >>>> I can make a quick patch if there is no objection, thanks. > >>> > >>> As I understand it was a decision to avoid details about flow API support > >>> in features matrix. Mainly because matrix would be really huge in > >>> attempt to represent it. The question is why filters/patterns mentioned > >>> above are better than others and should be mentioned. > >>> I'm not against adding some details, just want to understand criteria. > >>> Flexible and hash are definitely not well defined. > >>> What is flow director and which features should be supported to say yes? > >>> > > > >> > >> The criteria I have is what users will be interested about a device/driver. > >> > >> Will it be really huge to list filtering capabilities of the devices? I believe > >> we can group them into a few groups like above. > >> Or at least keep existing one and improve it by time and +1 to clarify them more > >> but that is something else. > >> > >> A device can have capabilities but it is not easy to find if that capability has > >> been enabled via DPDK, this kind of feature matrix works for it, and all > >> features together makes it much easier than digging datasheets and code. > >> > >> Saying that "Flow API" is enabled for a driver doesn't really gives any > >> information to the user if they are interested what kind of filtering features > >> are supported by that device/driver. > > > > I agree. I think, we need to enumerate rte flow patterns and actions > > supported by the PMD. > > Since there was no single place such documentation, we added the same > > in PMD documentation > > See 39.8. RTE Flow Support at https://doc.dpdk.org/guides/nics/octeontx2.html > > > > And IMO, We should not add deprecated features in the features matrix as > > new PMDs are not planning to implement the deprecated APIs. That > > makes, matrix looks > > new PMDs do not implement a lot of features, but in reality, those are > > deprecated and never planning to implement if even though HW supports it. > > > > +1 to not add deprecated features to the matrix, but those removed ones [1] are > not deprecated. Implementing them via "filter_ctrl" is deprecated. Below > features still can be implemented via "Flow API", that is why I am for adding > them back to default.ini. Got it. Instead of [1], Can we document it as in the form of rte_flow semantics(patterns and actions) so that for the end-user it is very clear. Reason being: # Expressing "Tunnel filter" or "N-tupe filter" or "Flexible filter" or "Flow director" etc is very vague in rte_flow semantics and function is not just limited with above-fixed functions # The new PMDs also can express the rte_flow aka "Flow API" support in the rte_flow semantics. > And announce them as supported per PMD only if they are implemented via Flow API. > > [1] > Ethertype filter = > N-tuple filter = > SYN filter = > Tunnel filter = > Flexible filter = > Hash filter = > Flow director =