From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69C49A04EF; Mon, 25 May 2020 07:53:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE5971D63A; Mon, 25 May 2020 07:53:50 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 3B0971D62C for ; Mon, 25 May 2020 07:53:49 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id q8so16178154iow.7 for ; Sun, 24 May 2020 22:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ss+EfMpuY+skmQdDHNGkJkjF3CP2MO4uZiUfb39VCsg=; b=vItWTqrpGWgSSTfObW2PFor2Io5Z6QCJeUfAmFR7VjrNMjfylA16G+1eP4KCZOwMHq 1DLUAESEZvTRiQshUrvD5KkNJX9D+mIOSZmuQRocuH34vP+XBFE2UScvrNAS3gg82S2c gIavyNHxWOh0ahLbWWNthyk89at/nsrUm83k+LrnzuWtwTyCHej+NS/BSGKqp2nNYbWM mV3Mdy5dIa0xorxmLuOnGnTU0y6BfySg8TqxaumEhXyP0KPwOnb3wl2fLZqdyUNrxve8 taB+DELyQ8A7nRUlmTO0PDzdBJoojveM7lM3FNPdHhaMgPsTndeK1sgJAlDlMKvsSc3z AhQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ss+EfMpuY+skmQdDHNGkJkjF3CP2MO4uZiUfb39VCsg=; b=iBmRZ5a9QTI7CC5LZGcjZ2ghj9fwFwhyEAsiOW18pXu+fMuqISokt2esL+I8rg8lyV A/qJm1PoTd971VC28fuByfgYHyT2/pLraidSdsxx1Ra704afk1+YFsvSB9il9/yZeGAl V6OmKEtv/s9I5lM6n0GJaU6AvCn17M6LvrOuo6FNfqk6JFvJJw2w4w5v9bfPQSPfhwcs +++d0K/YMOxe/7+xJ/EXZ59vUQaioorxOybXReqnkfSdlE5SEYUaIaCvNyIDxQGYnsa5 hYs6+XNQykvQhQA5lUU4H1h6/+an02fIQ7NVr8CzEG8xFWHlAP4WA08bPN2bB1NeHVWw Fm2Q== X-Gm-Message-State: AOAM530KgKp/bh3O88HKeRXDgIdxORbq4bDWGlwH2MDIuOmQlUr7s6zA bcX5jwwNK2LM7gLQROVgc2WJa50tF+p9jgjhMl8= X-Google-Smtp-Source: ABdhPJxgLGblRl/hS0W83Q3FtCGcEq4hhvMM6s1vEg22ifyX1emqez1tXCgd3DePe/ZSl+9R2+HV8MprmF7qiIhDD/k= X-Received: by 2002:a6b:f40b:: with SMTP id i11mr12071442iog.59.1590386028459; Sun, 24 May 2020 22:53:48 -0700 (PDT) MIME-Version: 1.0 References: <20200428235015.2820677-1-dmitry.kozliuk@gmail.com> <20200525003720.6410-1-dmitry.kozliuk@gmail.com> <20200525003720.6410-7-dmitry.kozliuk@gmail.com> In-Reply-To: <20200525003720.6410-7-dmitry.kozliuk@gmail.com> From: Jerin Jacob Date: Mon, 25 May 2020 11:23:32 +0530 Message-ID: To: Dmitry Kozlyuk Cc: dpdk-dev , Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Jerin Jacob , Sunil Kumar Kori , Olivier Matz , Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 06/11] trace: add size_t field emitter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 25, 2020 at 6:08 AM Dmitry Kozlyuk wrote: > > It is not guaranteed that sizeof(long) == sizeof(size_t). On Windows, > sizeof(long) == 4 and sizeof(size_t) == 8 for 64-bit programs. > Tracepoints using "long" field emitter are therefore invalid there. > Add dedicated field emitter for size_t and use it to store size_t values > in all existing tracepoints. > > Signed-off-by: Dmitry Kozlyuk > --- The Doxygen comment for the new emit function is missing. See https://github.com/DPDK/dpdk/blob/master/lib/librte_eal/include/rte_trace_point.h#L138 Other than the above nit, rest looks good to me.