From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE425A0577; Tue, 14 Apr 2020 17:31:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BDC6B1C1F0; Tue, 14 Apr 2020 17:31:29 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id D8AAA1C1EF; Tue, 14 Apr 2020 17:31:28 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id m4so13640986ioq.6; Tue, 14 Apr 2020 08:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8iI5TQXd5xfHWAwi+3G4C+AFIavCIsQGAW6Jqe5iKdw=; b=LSwLmVp0swHDk/vdU1IxBsgUMRoqlaVwvhhWx5QNQERu5yS4mzv8D+3HhPzZAikfNX 5CiBxiJZVcdndUhnocrSsGC4H2aUQPu8pQzJlU+PnQPq4MQy1IKoTUMTcQ4ezlT4vPpx XUaz129jUBtauyGtYbSj3Ryin6GF6+Dgx68QpyyaXwaE/Vx9AgsLY6sB7Ag3oOEmyP1j jQgKqYfRmgqvy3SXjE32xiF60s7R3621qY7S8FJa1X/Zzk3z8YMsnG/0tu3OjqdqlNnX YJCjA8Igw/dA1JwtzCWiAhv6uN1iwfiq1+22chUhJBKoh0O6ksGgTzLOapYGjbOsmahS ZPIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8iI5TQXd5xfHWAwi+3G4C+AFIavCIsQGAW6Jqe5iKdw=; b=GywsYLS02msozXa2xbpqNopLQd+UX4u2ga7VF/lgw5wRpXCUysDkMUWdVBrJGkNXQY 5vjoCR0b7EYZe1uoIClKbi6up4S43ekg59bQnrR0UckFSWIqIHFGRU/PkVe0xExxaiEQ jpPR0Hi6bnUEM3RH40YCYBIfwrzespYgmjmocWaH3Lnci6t9S1cmQV7ilGw03fnZeh7Y OzX1BmbpGxeckVBwm09gdVD/mHbTrEoqVcFuzm56apEc7RT/4x4HEgr/1T1KVMZKjHn4 xEwNGYm2FKjzTQ8xT4ySvzwouJZreyoTtBkyV7D47kqRA9XwNd/6t9esMVvRHmSixC9E eCEA== X-Gm-Message-State: AGi0PuZuH9YppmBbEKl0HFLtiYth4ii4JcHowLB6XGA+oM5Q73scPZI7 OMbYZDhAm/PeCX125aKys6KDGJILR3Pn3q9zhik= X-Google-Smtp-Source: APiQypJFY8K9iqZtMaRrboXbHn0Shpvc82FukONOUnpRrRtD60TuPclE2V+yyxxHDfEuy5mBHJimL/Bs07ysQ+ar2mQ= X-Received: by 2002:a5d:940d:: with SMTP id v13mr6331366ion.1.1586878287961; Tue, 14 Apr 2020 08:31:27 -0700 (PDT) MIME-Version: 1.0 References: <20200413134540.10992-1-nithind1988@gmail.com> In-Reply-To: <20200413134540.10992-1-nithind1988@gmail.com> From: Jerin Jacob Date: Tue, 14 Apr 2020 21:01:11 +0530 Message-ID: To: Nithin Dabilpuram Cc: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , dpdk-dev , Vamsi Attunuru , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix unnecessary error interrupts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 13, 2020 at 7:15 PM Nithin Dabilpuram wrote: > > From: Nithin Dabilpuram > > Disable CQ_DISABLED error interrupt in NIX_LF_ERR_INT > to fix spurious interrupts in event dev mode. Also skip > configuring RSS when RQ count is '0' because > RSS table initialization is done incorrectly due to > divide-by-zero error and it is leading to RQ_OOR error > in NIX_LF_ERR_INT. > > Fixes: 83ce2880e22e ("net/octeontx2: support RSS") > Cc: vattunuru@marvell.com > Cc: stable@dpdk.org > > Signed-off-by: Nithin Dabilpuram Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > --- > drivers/net/octeontx2/otx2_ethdev_irq.c | 7 +++++-- > drivers/net/octeontx2/otx2_rss.c | 2 +- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/octeontx2/otx2_ethdev_irq.c b/drivers/net/octeontx2/otx2_ethdev_irq.c > index 96b848a..b121488 100644 > --- a/drivers/net/octeontx2/otx2_ethdev_irq.c > +++ b/drivers/net/octeontx2/otx2_ethdev_irq.c > @@ -472,9 +472,12 @@ otx2_nix_err_intr_enb_dis(struct rte_eth_dev *eth_dev, bool enb) > { > struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev); > > - /* Enable all nix lf error interrupts except for RQ_DISABLED */ > + /* Enable all nix lf error interrupts except > + * RQ_DISABLED and CQ_DISABLED. > + */ > if (enb) > - otx2_write64(~BIT_ULL(11), dev->base + NIX_LF_ERR_INT_ENA_W1S); > + otx2_write64(~(BIT_ULL(11) | BIT_ULL(24)), > + dev->base + NIX_LF_ERR_INT_ENA_W1S); > else > otx2_write64(~0ull, dev->base + NIX_LF_ERR_INT_ENA_W1C); > } > diff --git a/drivers/net/octeontx2/otx2_rss.c b/drivers/net/octeontx2/otx2_rss.c > index a29441e..5e3f866 100644 > --- a/drivers/net/octeontx2/otx2_rss.c > +++ b/drivers/net/octeontx2/otx2_rss.c > @@ -358,7 +358,7 @@ otx2_nix_rss_config(struct rte_eth_dev *eth_dev) > int rc; > > /* Skip further configuration if selected mode is not RSS */ > - if (eth_dev->data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_RSS) > + if (eth_dev->data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_RSS || !qcnt) > return 0; > > /* Update default RSS key and cfg */ > -- > 2.8.4 >