Re: [dpdk-dev] [PATCH] test/event_crypto: add check for session init failure

[Jerin Jacob <jerinjacobk@gmail.com>]

On Thu, Sep 12, 2019 at 8:40 PM Gujjar, Abhinandan S
<abhinandan.gujjar@intel.com> wrote:
>
> Acked-by: abhinandan.gujjar@intel.com

Changed to Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
and
Applied to dpdk-next-eventdev/master. Thanks.


> > -----Original Message-----
> > From: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Sent: Friday, September 6, 2019 4:12 PM
> > To: dev@dpdk.org
> > Cc: jerinj@marvell.com; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> > Hemant Agrawal <hemant.agrawal@nxp.com>
> > Subject: [PATCH] test/event_crypto: add check for session init failure
> >
> > Mismatch in algo or sec capability can cause session to fail.
> > This patch handle it and return error timely.
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> >  app/test/test_event_crypto_adapter.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test/test_event_crypto_adapter.c
> > b/app/test/test_event_crypto_adapter.c
> > index 73655020d..e7bf80978 100644
> > --- a/app/test/test_event_crypto_adapter.c
> > +++ b/app/test/test_event_crypto_adapter.c
> > @@ -199,8 +199,9 @@ test_op_forward_mode(uint8_t session_less)
> >               TEST_ASSERT_NOT_NULL(sess, "Session creation failed\n");
> >
> >               /* Create Crypto session*/
> > -             rte_cryptodev_sym_session_init(TEST_CDEV_ID, sess,
> > +             ret = rte_cryptodev_sym_session_init(TEST_CDEV_ID, sess,
> >                               &cipher_xform, params.session_priv_mpool);
> > +             TEST_ASSERT_SUCCESS(ret, "Failed to init session\n");
> >
> >               ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID,
> >                                                       evdev, &cap);
> > @@ -398,8 +399,10 @@ test_op_new_mode(uint8_t session_less)
> >                       rte_cryptodev_sym_session_set_user_data(sess,
> >                                               &m_data, sizeof(m_data));
> >               }
> > -             rte_cryptodev_sym_session_init(TEST_CDEV_ID, sess,
> > +             ret = rte_cryptodev_sym_session_init(TEST_CDEV_ID, sess,
> >                               &cipher_xform, params.session_priv_mpool);
> > +             TEST_ASSERT_SUCCESS(ret, "Failed to init session\n");
> > +
> >               rte_crypto_op_attach_sym_session(op, sess);
> >       } else {
> >               struct rte_crypto_sym_xform *first_xform;
> > --
> > 2.17.1
>