From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5E9FA2EDB for ; Tue, 1 Oct 2019 07:56:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 37D452C2B; Tue, 1 Oct 2019 07:56:19 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id DE37B23D for ; Tue, 1 Oct 2019 07:56:17 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id n197so44746323iod.9 for ; Mon, 30 Sep 2019 22:56:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mcpNizkKjTWnMJb+txDgHHAWMVgTen/x0T0kC74f/F0=; b=vJ69xPAt7NWa0Fi5byRD1LnRy+A+sPC2MtiE+JXMAj36OwG7dd6qREDl+/Icwjk5kh 5LAOdyEYeeuPA32Fbvte43zE0UiOZKNSd7yzvDA2Luk+kvsRlAM1EGhxnG+Pyu9JD5g8 DOe3zST0Q/ReyqHFjOC63FscKqM00uhGyba2lWJ7tg7V3jv7Q7PEBqUx4koNMIOH1JxX n4w9H1n3qoLFMrL+MYbf6SLcS70ddK/jKxaVHEofTOXhxqyk6nnR1Cu0i9ewlrWZUXMc bHgyzvNcJRhU/yZY47nPFX1PJoqO8OG/O4AM62qiCV6nBtBI2dpksZuM59sqX17HvcFb 6qyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mcpNizkKjTWnMJb+txDgHHAWMVgTen/x0T0kC74f/F0=; b=WOQlJS1cpnL1LUnSp1gpvwHq17mRyYiC2Rqtu3O75TR+oaMfaGUftPSPaMgSm+lzJe iVUl3FOR+P2LZ0GU9cqnPtfwzDPjzVBeRdJslEptY0uDQ0Cu1kEUFwhQ6a9tQHrKwbLk nf019jsyDdEwVIV/zfUqHywezgIrqyVSGVlvJE2X3DBGj6AX7TNLSj2wmuNRx4FpKp4M 9OuSmIDJ/zJLIId2/pWnGDvhlwV3LvCaCS6TkCiFc3tAa4bhRST07jcm1wGmncswHGIG qoMv6Bh3samhQ55lrT9x7W4Z7PtvkY/OU7LRMii0Zh6D46A/1c4VxGencpYJAG+8MWOP wvrA== X-Gm-Message-State: APjAAAX9mkh/fXZpnJKsz/hyjHQIZHLOhZe9ygQg/FsazI0BUutwPZxI CvQg1Ml3iOX16uGNSleFZuDFlD/446G+jHMD17A= X-Google-Smtp-Source: APXvYqzKREXx0NsIspwUN7cLWcK4JVVVb2smcr+3vu3R8aIwEDXw5D3TAJQxG56tP0OEzpuoZnXb4dkqq8NINQXpA4g= X-Received: by 2002:a6b:6c15:: with SMTP id a21mr3350587ioh.60.1569909377082; Mon, 30 Sep 2019 22:56:17 -0700 (PDT) MIME-Version: 1.0 References: <20190909195404.4760-1-pallavi.kadam@intel.com> <20190926202924.6876-1-pallavi.kadam@intel.com> <20190926202924.6876-4-pallavi.kadam@intel.com> <1bebcec9-9d1a-0113-88a6-609e7c7dd518@intel.com> In-Reply-To: <1bebcec9-9d1a-0113-88a6-609e7c7dd518@intel.com> From: Jerin Jacob Date: Tue, 1 Oct 2019 11:26:05 +0530 Message-ID: To: Pallavi Kadam Cc: dpdk-dev , Thomas Monjalon , Harini.Ramakrishnan@microsoft.com, "Wiles, Keith" , "Richardson, Bruce" , "Menon, Ranjit" , "Kolar, Antara Ganesh" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 3/9] eal: add windows compatible header files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 30, 2019 at 11:19 PM Pallavi Kadam wrote: > > Hi Jerin, > > On 9/27/2019 12:58 AM, Jerin Jacob wrote: > > On Fri, Sep 27, 2019 at 2:24 AM Pallavi Kadam wrote: > > Adding dlfcn.h on Windows to support common code. > > Adding eal_filesystem.h to support functions and > path defines for files and directories on Windows. > > Adding getopt.h to support parsing options on Windows. > > Adding rte_vect.h as Windows fails to compile: > \common\include\arch\x86\rte_vect.h. > > Signed-off-by: Antara Ganesh Kolar > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > Reviewed-by: Keith Wiles > --- > diff --git a/lib/librte_eal/windows/eal/include/rte_vect.h b/lib/librte_eal/windows/eal/include/rte_vect.h > new file mode 100644 > index 000000000..630473e28 > --- /dev/null > +++ b/lib/librte_eal/windows/eal/include/rte_vect.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2019 Intel Corporation > + */ > + > +#pragma once > + > +#define __ICC 1600 > + > +#include "..\..\common\include\arch\x86\rte_vect.h" > > I understand there is a compilation error with generic rte_vect.h with > windows from the git commit. > But above hardcoding to x86 will create an issue for another arch. > Please fix the compilation > for generic rte_vect.h or introduce vect.h as OS-specific and have > implementation for Linux and FreeBSD. > > The error is due to conflict types in the compilers. Clang compiler and Windows SDK > > both declare _m_prefetchw() in x86intrin.h file which is included from generic rte_vect.h. > > Error is as below: > > C:\Program Files\LLVM\lib\clang\8.0.0\include\prfchwintrin.h:64:1: error: conflicting types for '_m_prefetchw' > > _m_prefetchw(void *__P) > > ^ > > C:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\um\winnt.h:3275:1: note: previous declaration is here > > _m_prefetchw ( > > ^ > > > Is it ok to include #ifdef for other architectures in the above file itself? If I understand it correctly, after completing the "make config" stage, ./lib/librte_eal/common/include/arch/x86/rte_vect.h will be mapped as build/include/rte_vect.h. The application will build/include/rte_vect.h and it internally include ./lib/librte_eal/common/include/generic/rte_vect.h. If ./lib/librte_eal/common/include/arch/x86/rte_vect.h has compilation issue, we can have #ifdef fix in arch/x86/rte_vect.h > > > > > -- > 2.18.0.windows.1 >