From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48C03A0524; Sat, 4 Jul 2020 16:22:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2682E1DB82; Sat, 4 Jul 2020 16:22:40 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id C39141DB5B for ; Sat, 4 Jul 2020 16:22:38 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id a12so35083087ion.13 for ; Sat, 04 Jul 2020 07:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZVDL4i3z36AY9rp0myFgVhf/aQz3LzgGSCZ2Hs5ZeZE=; b=NqEd5gXQ/1E4mb/nRI6ndDOb0rHBzOGCp6iYUq/MllDubauPLogrH1V4f7BWjgPq5b /SJfNhIZH/at004lbRVAJs/ubJY3DBHrypdUhniSnSaO5WnS5Xbe127wx0InaXvUnEZN V45JtDLzsBTLSyvlaiOZQLJwmW0cS+8+6y8dr5sY1MIMbdWkvt0FTDoRH4rAXty3Iftt 4gnPpjCJ0EHCvPbgjFn7f/mgQC56yMeBDaMrBzTcwOwknhiTGNdS1BEhnlIMth65FIZO QG6E4lrdr91K6xpN+SvR6jG7rbvZ0FOmoLRx2MofCwy2cM2ON35UQJGW78yztgD6iEWG h+EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZVDL4i3z36AY9rp0myFgVhf/aQz3LzgGSCZ2Hs5ZeZE=; b=SsWBQDH8kGooowLXVyxJOO6wiYE7xJXyTVcB1x230chtIub51ghFo5eEtCgjf6GBRF DRaFvviQUyR8DfFtR4oveI1uKj3bjfD22NJkSgbJbT5/Yzi8dIAPO9X3Rv8maeCvHkBf sCF/nUqRtqbacccHFk2FpB+5lxQxCntI+WR1Rf4Fqu+yIsfFc7eBPlJDHZ2fK6Yb9Zjp PVrPwrrOFmtWLESD9OwzrFrVcWRc57olvlQKXREFZEDxDUfgwEZi5Ba6WruLClzklKlE 2ISwsbeMtVQkXe0RVQLy5zAk2vM/HFbuNLwL1wa4dyVVMYaHFU5y7JUWIv2uXKMwIc0+ 6VpQ== X-Gm-Message-State: AOAM532fQMye2+rIAJTIQM42IpuQAb89cq+Qt8Aps9Fjm08Pv9JxN3ls ZWtL+p6jLvMQSdFz9XAEfDbBSoBR5qvbOqfInHM= X-Google-Smtp-Source: ABdhPJyLsfrdn+pwm5gyUSUs42W/i2Q7TSg9SkleSL+jePmXV2ffhcYhRajtqu30yTxd3RAIu4efxW/qi5Wx45UwZo8= X-Received: by 2002:a02:6a26:: with SMTP id l38mr44178090jac.60.1593872557930; Sat, 04 Jul 2020 07:22:37 -0700 (PDT) MIME-Version: 1.0 References: <20200701180507.2850094-1-thomas@monjalon.net> <20200702160911.3596412-1-thomas@monjalon.net> In-Reply-To: <20200702160911.3596412-1-thomas@monjalon.net> From: Jerin Jacob Date: Sat, 4 Jul 2020 19:52:21 +0530 Message-ID: To: Thomas Monjalon Cc: dpdk-dev , David Marchand , "Richardson, Bruce" , Nithin Dabilpuram , Jerin Jacob , Luca Boccassi , Sunil Pai G Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] build: remove special handling for node library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 2, 2020 at 9:39 PM Thomas Monjalon wrote: > > The node library had a need of being linked as a whole > to make some constructors effective. > Now that all libraries are linked with --whole-archive, > there is no need to have this library separate. > > Fixes: e2db26f76673 ("build: always link whole DPDK static libraries") > > Signed-off-by: Thomas Monjalon Tested the change with: echo "node_list_dump" | sudo ./build/app/test/dpdk-test -c 0x3 Tested-by: Jerin Jacob > --- > v2: write real commit log > --- > app/test/meson.build | 4 +--- > examples/meson.build | 4 +--- > lib/meson.build | 3 --- > meson.build | 1 - > 4 files changed, 2 insertions(+), 10 deletions(-) > > diff --git a/app/test/meson.build b/app/test/meson.build > index b224d6f2bb..da5f39f018 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -415,15 +415,13 @@ endforeach > test_dep_objs += cc.find_library('execinfo', required: false) > > link_libs = [] > -link_nodes = [] > if get_option('default_library') == 'static' > link_libs = dpdk_static_libraries + dpdk_drivers > - link_nodes = dpdk_graph_nodes > endif > > dpdk_test = executable('dpdk-test', > test_sources, > - link_whole: link_libs + link_nodes, > + link_whole: link_libs, > dependencies: test_dep_objs, > c_args: cflags, > install_rpath: driver_install_path, > diff --git a/examples/meson.build b/examples/meson.build > index 120eebf716..eb13e82101 100644 > --- a/examples/meson.build > +++ b/examples/meson.build > @@ -2,10 +2,8 @@ > # Copyright(c) 2017-2019 Intel Corporation > > link_whole_libs = [] > -node_libs = [] > if get_option('default_library') == 'static' > link_whole_libs = dpdk_static_libraries + dpdk_drivers > - node_libs = dpdk_graph_nodes > endif > > execinfo = cc.find_library('execinfo', required: false) > @@ -101,7 +99,7 @@ foreach example: examples > endif > executable('dpdk-' + name, sources, > include_directories: includes, > - link_whole: link_whole_libs + node_libs, > + link_whole: link_whole_libs, > link_args: dpdk_extra_ldflags, > c_args: cflags, > dependencies: dep_objs) > diff --git a/lib/meson.build b/lib/meson.build > index c1b9e1633f..8ca25172c3 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -202,9 +202,6 @@ foreach l:libraries > > dpdk_libraries = [shared_lib] + dpdk_libraries > dpdk_static_libraries = [static_lib] + dpdk_static_libraries > - if libname == 'rte_node' > - dpdk_graph_nodes = [static_lib] > - endif > endif # sources.length() > 0 > > set_variable('shared_rte_' + name, shared_dep) > diff --git a/meson.build b/meson.build > index d21adfd303..e8bb9c4c1e 100644 > --- a/meson.build > +++ b/meson.build > @@ -16,7 +16,6 @@ cc = meson.get_compiler('c') > dpdk_conf = configuration_data() > dpdk_libraries = [] > dpdk_static_libraries = [] > -dpdk_graph_nodes = [] > dpdk_driver_classes = [] > dpdk_drivers = [] > dpdk_extra_ldflags = [] > -- > 2.26.2 >