Re: [dpdk-dev] [PATCH v1] test/event: fix return value of timer test setup

[Jerin Jacob <jerinjacobk@gmail.com>]

On Fri, May 7, 2021 at 3:42 PM Shijith Thotton <sthotton@marvell.com> wrote:
>
> Test case setup should return -ENOTSUP, if it is not supported.
>
> Fixes: 7d761b07fcf6 ("test/event: add unit tests for periodic timer")
Cc: stable@dpdk.org


>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-eventdev/for-main. Thanks.

> ---
>  app/test/test_event_timer_adapter.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/app/test/test_event_timer_adapter.c b/app/test/test_event_timer_adapter.c
> index c36ab32ac..121c2d93e 100644
> --- a/app/test/test_event_timer_adapter.c
> +++ b/app/test/test_event_timer_adapter.c
> @@ -303,10 +303,8 @@ _timdev_setup(uint64_t max_tmo_ns, uint64_t bkt_tck_ns, uint64_t flags)
>                                 "failed to get adapter capabilities");
>
>         if (flags & RTE_EVENT_TIMER_ADAPTER_F_PERIODIC &&
> -           !(caps & RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC)) {
> -               printf("Adapter does not support periodic timers\n");
> -               return TEST_SKIPPED;
> -       }
> +           !(caps & RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC))
> +               return -ENOTSUP;
>
>         if (!(caps & RTE_EVENT_TIMER_ADAPTER_CAP_INTERNAL_PORT)) {
>                 timdev = rte_event_timer_adapter_create_ext(&config,
> --
> 2.25.1
>