From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FD39423B7; Thu, 12 Jan 2023 14:32:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0CDC842D22; Thu, 12 Jan 2023 14:32:49 +0100 (CET) Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) by mails.dpdk.org (Postfix) with ESMTP id 0412240E25; Thu, 12 Jan 2023 14:32:46 +0100 (CET) Received: by mail-ua1-f49.google.com with SMTP id t8so4498074uaj.5; Thu, 12 Jan 2023 05:32:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=b90uY1tINGubQVwG2LQl1lHPCT85Rh7FFa83TuqSjwk=; b=XhuTl5pycSxKXMXtfyyfTpfCOjl0kreaphnLM8gKvhRDVD/CU4cMDUe2Q5vK1rP233 4KvyCFqGiTIGt+PC1moa4JGRz2yuNlyLSZyw35C/9I0LEGwzKx1yuvQRiD+9CvqK0TRR FZKQD5kwzU1m24HrPL7kNlYvZ6WIVi3g5iVDjhjEYUljJPu2Dcl7Jg1UqqkCdD/3VJaU FeUd3jMPguPOcYJToJn0xk7cUMYWLwT0md/F3k49WpbCS9f81LnuL9RjfJWaALE8+/S6 4bBXRERE1VGYo01/6cjrR+Axv0riHnkhbFyu6YeM8f7Daw+wfr5FK3V2ga/76TQLyA4q 8liw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b90uY1tINGubQVwG2LQl1lHPCT85Rh7FFa83TuqSjwk=; b=il6QrWuo7m8a8SgDpUw/Lqgb4AiWC8m+OqEVBz0HnN/npoHyxWt2IMKcFwwCdxveLo 5iOx50LbCjQml93TcE8eizbnx7kaKMYpLHduobgarVgw1rxBeycZN0GmFVXw0+2SmwZc e/xru+oN05SeHVtg2+HmNSVct572/h5g4LNsxGDEMmz6Q8TderzqyvOY0KChdbiTlvg9 351Wfh38KW4JcNLntVBSipWDcnFiwk4rjG5z5G0nipKTKOD9nmNhZO/+OQGP934l/wBm U7eeiU3D3g2VoQpPPucMivnzN9HVqL0SESc7ykVpRbWWMRN6zsU4JJW+0p3+4BCeD3Rk w31w== X-Gm-Message-State: AFqh2kqPFRLCgTsulqfNIO5mPcMSE60Fb6cvcpexsu4Mc17gDfKyj/q9 da7stbvt4RKBrGlHS9wfjOyOb9yXIwIROZlAyfIMb9I0318= X-Google-Smtp-Source: AMrXdXvUFi42maVly0Sa5WJtSq8C/YKrf1vAzoz0h/86HR8fgRTGI8Ez/HN58kmHOVkhWioy1UHw+94LYHkn/Bl5YrU= X-Received: by 2002:ab0:917:0:b0:419:23:73b5 with SMTP id w23-20020ab00917000000b00419002373b5mr8909702uag.17.1673530366215; Thu, 12 Jan 2023 05:32:46 -0800 (PST) MIME-Version: 1.0 References: <20230112063620.1057554-1-psatheesh@marvell.com> In-Reply-To: <20230112063620.1057554-1-psatheesh@marvell.com> From: Jerin Jacob Date: Thu, 12 Jan 2023 19:02:19 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH] common/cnxk: fix issue with IPv6 ext matching To: psatheesh@marvell.com Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dev@dpdk.org, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 12, 2023 at 12:06 PM wrote: > > From: Kiran Kumar K > > While configuring ipv6 flow, ipv6 ext ltype should be > matched along with ipv6. Adding changes to fix this issue. > > Fixes: 474e275b1bc6 ("common/cnxk: support extensions attributes in IPv6 item") > Cc: stable@dpdk.org > > Signed-off-by: Kiran Kumar K > Reviewed-by: Satheesh Paul Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks common/cnxk: fix issue with IPv6 ext matching While configuring IPv6 flow, IPv6 ext ltype should be matched along with IPv6. Adding changes to fix this issue. Fixes: 474e275b1bc6 ("common/cnxk: support extensions attributes in IPv6 item") Cc: stable@dpdk.org Signed-off-by: Kiran Kumar K Reviewed-by: Satheesh Paul > --- > drivers/common/cnxk/roc_npc_mcam.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/common/cnxk/roc_npc_mcam.c b/drivers/common/cnxk/roc_npc_mcam.c > index c419ce3a4c..0abd8872b1 100644 > --- a/drivers/common/cnxk/roc_npc_mcam.c > +++ b/drivers/common/cnxk/roc_npc_mcam.c > @@ -727,15 +727,16 @@ npc_set_ipv6ext_ltype_mask(struct npc_parse_state *pst) > * because for AH and ESP, LC LFLAG is zero and we don't want to match > * zero in LFLAG. > */ > - lcflag_offset = > - __builtin_popcount(pst->npc->keyx_supp_nmask[pst->nix_intf] & > - ((1ULL << NPC_LFLAG_LC_OFFSET) - 1)); > - lcflag_offset *= 4; > - > - mask = (0xfULL << lcflag_offset); > - val = pst->flow->mcam_data[0] & mask; > - if (val) > - pst->flow->mcam_mask[0] |= mask; > + if (pst->npc->keyx_supp_nmask[pst->nix_intf] & (1ULL << NPC_LFLAG_LC_OFFSET)) { > + lcflag_offset = __builtin_popcount(pst->npc->keyx_supp_nmask[pst->nix_intf] & > + ((1ULL << NPC_LFLAG_LC_OFFSET) - 1)); > + lcflag_offset *= 4; > + > + mask = (0xfULL << lcflag_offset); > + val = pst->flow->mcam_data[0] & mask; > + if (val) > + pst->flow->mcam_mask[0] |= mask; > + } > } > > int > -- > 2.35.3 >