From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13057A2EEB for ; Thu, 12 Sep 2019 18:25:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 29DAB1EC1E; Thu, 12 Sep 2019 18:25:29 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 8E1A71EBE6 for ; Thu, 12 Sep 2019 18:25:27 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id m11so56219694ioo.0 for ; Thu, 12 Sep 2019 09:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5fA0m/+xwIF9vdkijJ+4QXidef5eQOPYPTQ8yS+atJY=; b=Sx0y7Qw5IY/t6LUPN3hi6sXss/14TILJoGIR4mhsbe6LDhxN1k8xqm3AmJQc//KHjb jidmqxE10o8F7sRsODo0lo1aklJd0mCrGEHruQxPU8+D+Rt6KYhOszVIveTVv/MelqV4 v14n6ejXpV+A9UY0KwlK8yjx8S9LwRjlruEGay3QbkdYTr6YMeyRZBoc6fUfUWUc+9rd a83rz93dW8bVpKajZUcVklQIimtJgM/svypvEHTznt+E3sazDtF/dYK3Cr5cFRE4I5YA VqyUJ08qmTNqGaSRgVRi6VPt/M7/OezuW6SbPf42EppEKxDNfZj2m+8/8koDg+FUhXuO lhew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5fA0m/+xwIF9vdkijJ+4QXidef5eQOPYPTQ8yS+atJY=; b=PnkqmHXWRpuEvd1fKIPnQhjwZ8vG74CNVWnryzE7FX5UDYVV/x0yPojyi2ortPJFud 8s9Iwxv+6jfCfzdO9BIqRu5FURjUfrTjOlhqAKcUr4A5aGRpUb6UqGPr6yTDg+wz+sTV j6twBeOhAkqUUueHHyleuBx+rb79OHTindKxKKlI8xCbehhME49WtMLNcizVOeQZE4L+ 8svD+6tsLhPW9tizckyLT1uoNeKUzzSpTBiPFrDVsKq1fa1j+SDJxZqw0AnLJer1lykj bbucudaiGFW3iml086wXCtNFU2VDes74riBX9ieANUjp950LruFKPGWfDpZ5YgzKbleu MoRA== X-Gm-Message-State: APjAAAWNZphnnOUY21pe3fZzl9cW7iXrTZvaUurgDJyob6eick6scbJd c0yu1EPRYnKIiH3gMW8N27/TyZTyK7WNvIdH2+E= X-Google-Smtp-Source: APXvYqzaDLkoEfgmVn84ceWbkjh3N+I5be6s0fD+WhvYE5DhuO8+RugmICEa0kxoiywYXehwKO3ZbdOfkVF1BruEBUc= X-Received: by 2002:a6b:fa14:: with SMTP id p20mr5044238ioh.15.1568305526796; Thu, 12 Sep 2019 09:25:26 -0700 (PDT) MIME-Version: 1.0 References: <20190912085119.27171-1-jerryhao@os.amperecomputing.com> <20190912085119.27171-2-jerryhao@os.amperecomputing.com> In-Reply-To: From: Jerin Jacob Date: Thu, 12 Sep 2019 21:55:15 +0530 Message-ID: To: "Gavin Hu (Arm Technology China)" Cc: Jerry Hao OS , "thomas@monjalon.net" , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/1] build: add emag(arm64) platform and default config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 12, 2019 at 3:02 PM Gavin Hu (Arm Technology China) wrote: > > Hi Jerry, > > Please use --in-reply-to and -v options to chain your different versions = of patches and make the old ones "Superseded". > > /Gavin > > > -----Original Message----- > > From: dev On Behalf Of Jerry Hao OS > > Sent: Thursday, September 12, 2019 4:53 PM > > To: thomas@monjalon.net > > Cc: dev@dpdk.org; Jerry Hao OS > > Subject: [dpdk-dev] [PATCH 1/1] build: add emag(arm64) platform and def= ault > > config > > > > This patch is to add the emag default CACHE_LINE_SIZE > > settings and ARCH variable definitions; > > Added the meson build config. Please change the git comment to a more reasonable description. See the example below for a similar config for N1 platform. config: add arm neoverse N1 SDP configuration Arm N1 SDP is an infrastructure segment development platform based on armv8.2-a Neoverse N1 CPU. For more information, refer to: https://community.arm.com/developer/tools-software/oss-platforms/w/docs/440= /neoverse-n1-sdp > > Signed-off-by: Jerry Hao OS With the above change: Acked-by: Jerin Jacob > > --- > > config/arm/arm64_emag_linux_gcc | 15 ++++++++++++ > > config/arm/meson.build | 11 ++++++++- > > config/defconfig_arm64-emag-linux-gcc | 1 + > > config/defconfig_arm64-emag-linuxapp-gcc | 11 +++++++++ > > mk/machine/emag/rte.vars.mk | 31 ++++++++++++++++++++++++ > > 5 files changed, 68 insertions(+), 1 deletion(-) > > create mode 100644 config/arm/arm64_emag_linux_gcc > > create mode 120000 config/defconfig_arm64-emag-linux-gcc > > create mode 100644 config/defconfig_arm64-emag-linuxapp-gcc > > create mode 100644 mk/machine/emag/rte.vars.mk > > > > diff --git a/config/arm/arm64_emag_linux_gcc > > b/config/arm/arm64_emag_linux_gcc > > new file mode 100644 > > index 000000000..bcb147a5a > > --- /dev/null > > +++ b/config/arm/arm64_emag_linux_gcc > > @@ -0,0 +1,15 @@ > > +[binaries] > > +c =3D 'aarch64-linux-gnu-gcc' > > +cpp =3D 'aarch64-linux-gnu-cpp' > > +ar =3D 'aarch64-linux-gnu-gcc-ar' > > +strip =3D 'aarch64-linux-gnu-strip' > > +pcap-config =3D '' > > + > > +[host_machine] > > +system =3D 'linux' > > +cpu_family =3D 'aarch64' > > +cpu =3D 'armv8-a' > > +endian =3D 'little' > > + > > +[properties] > > +implementor_id =3D '0x50' > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > index 979018e16..6c1b85186 100644 > > --- a/config/arm/meson.build > > +++ b/config/arm/meson.build > > @@ -61,6 +61,11 @@ flags_armada =3D [ > > ['RTE_CACHE_LINE_SIZE', 64], > > ['RTE_MAX_NUMA_NODES', 1], > > ['RTE_MAX_LCORE', 16]] > > +flags_emag =3D [ > > + ['RTE_MACHINE', '"emag"'], > > + ['RTE_CACHE_LINE_SIZE', 64], > > + ['RTE_MAX_NUMA_NODES', 1], > > + ['RTE_MAX_LCORE', 32]] > > > > flags_default_extra =3D [] > > flags_thunderx_extra =3D [ > > @@ -98,6 +103,10 @@ machine_args_cavium =3D [ > > ['0xaf', ['-march=3Darmv8.1-a+crc+crypto','-mcpu=3Dthunderx2t99']= , > > flags_thunderx2_extra], > > ['0xb2', ['-mcpu=3Docteontx2'], flags_octeontx2_extra]] > > > > +machine_args_emag =3D [ > > + ['default', ['-march=3Darmv8-a+crc+crypto']], > > + ['native', ['-march=3Dnative']]] > > + > > ## Arm implementer ID (ARM DDI 0487C.a, Section G7.2.106, Page G7-5321= ) > > impl_generic =3D ['Generic armv8', flags_generic, machine_args_generic= ] > > impl_0x41 =3D ['Arm', flags_arm, machine_args_generic] > > @@ -107,7 +116,7 @@ impl_0x44 =3D ['DEC', flags_generic, > > machine_args_generic] > > impl_0x49 =3D ['Infineon', flags_generic, machine_args_generic] > > impl_0x4d =3D ['Motorola', flags_generic, machine_args_generic] > > impl_0x4e =3D ['NVIDIA', flags_generic, machine_args_generic] > > -impl_0x50 =3D ['AppliedMicro', flags_generic, machine_args_generic] > > +impl_0x50 =3D ['Ampere Computing', flags_emag, machine_args_emag] > > impl_0x51 =3D ['Qualcomm', flags_generic, machine_args_generic] > > impl_0x53 =3D ['Samsung', flags_generic, machine_args_generic] > > impl_0x56 =3D ['Marvell ARMADA', flags_armada, machine_args_generic] > > diff --git a/config/defconfig_arm64-emag-linux-gcc b/config/defconfig_a= rm64- > > emag-linux-gcc > > new file mode 120000 > > index 000000000..21894a31a > > --- /dev/null > > +++ b/config/defconfig_arm64-emag-linux-gcc > > @@ -0,0 +1 @@ > > +defconfig_arm64-emag-linuxapp-gcc > > \ No newline at end of file > > diff --git a/config/defconfig_arm64-emag-linuxapp-gcc > > b/config/defconfig_arm64-emag-linuxapp-gcc > > new file mode 100644 > > index 000000000..1db654c89 > > --- /dev/null > > +++ b/config/defconfig_arm64-emag-linuxapp-gcc > > @@ -0,0 +1,11 @@ > > +# SPDX-License-Identifier: BSD-3-Clause > > +# Copyright(c) 2019 Ampere Computing > > +# > > + > > +#include "defconfig_arm64-armv8a-linux-gcc" > > + > > +CONFIG_RTE_MACHINE=3D"emag" > > + > > +CONFIG_RTE_CACHE_LINE_SIZE=3D64 > > +CONFIG_RTE_MAX_NUMA_NODES=3D1 > > +CONFIG_RTE_MAX_LCORE=3D32 > > diff --git a/mk/machine/emag/rte.vars.mk b/mk/machine/emag/rte.vars.mk > > new file mode 100644 > > index 000000000..9ce8b6bc9 > > --- /dev/null > > +++ b/mk/machine/emag/rte.vars.mk > > @@ -0,0 +1,31 @@ > > +# SPDX-License-Identifier: BSD-3-Clause > > +# Copyright(c) 2019 Ampere Computing > > +# > > + > > +# > > +# machine: > > +# > > +# - can define ARCH variable (overridden by cmdline value) > > +# - can define CROSS variable (overridden by cmdline value) > > +# - define MACHINE_CFLAGS variable (overridden by cmdline value) > > +# - define MACHINE_LDFLAGS variable (overridden by cmdline value) > > +# - define MACHINE_ASFLAGS variable (overridden by cmdline value) > > +# - can define CPU_CFLAGS variable (overridden by cmdline value) tha= t > > +# overrides the one defined in arch. > > +# - can define CPU_LDFLAGS variable (overridden by cmdline value) th= at > > +# overrides the one defined in arch. > > +# - can define CPU_ASFLAGS variable (overridden by cmdline value) th= at > > +# overrides the one defined in arch. > > +# - may override any previously defined variable > > +# > > + > > +# ARCH =3D > > +# CROSS =3D > > +# MACHINE_CFLAGS =3D > > +# MACHINE_LDFLAGS =3D > > +# MACHINE_ASFLAGS =3D > > +# CPU_CFLAGS =3D > > +# CPU_LDFLAGS =3D > > +# CPU_ASFLAGS =3D > > + > > +MACHINE_CFLAGS +=3D -march=3Darmv8-a+crc+crypto > > Reviewed-by: Gavin Hu > > > -- > > 2.17.1 > > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you.