From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38C1AA0C47; Tue, 16 Nov 2021 20:09:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF92240141; Tue, 16 Nov 2021 20:09:57 +0100 (CET) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by mails.dpdk.org (Postfix) with ESMTP id B70E940040 for ; Tue, 16 Nov 2021 20:09:56 +0100 (CET) Received: by mail-io1-f41.google.com with SMTP id z26so27471924iod.10 for ; Tue, 16 Nov 2021 11:09:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kDLngZKs6I+G2JlvwhaYfSQBiJW+5jchGBpAMDS21uU=; b=XITOy6RHUsg6Gn92qxiNjmZzr//L2L5rbk1wpnGtnphntCFsNVhtbnLx29zLdqIKuu 8cceiimMJ/MAerRQcKcpIVJzuyzpoyfor0zSrIIzEFFveifDxOU9R6wwzfucVyTmylFh pijXADAH52pfUEafjtmm59FwDZeiQ2dqsv47nf7uoO9wyxHd7o6bp0pMxKWvSacYAr3Z LQBIQuxwuTOQitHB0Uxl/1N8eW4L64bi4oPdUkfgQCjWjU8UZ0VEqyK4P4FJnhIncCey McL95Yt49kPMqO172XuHSar0y5lFnUX9yrcrDmY9tZTug09Y5wuW4B3y5ybI3Xlzux7a f/mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kDLngZKs6I+G2JlvwhaYfSQBiJW+5jchGBpAMDS21uU=; b=HaLEoBdcEN25YjKB3qKNEwIW6EBxKfOwNvGc09YfgnXbznNqRwYEVnJGJA8vMcfqAI SUSmzLsf2wI7k2gmxTfXfx7YYHPD3dmNGFUHq5KOlVkCVg0ti2AA7FTjK/p5EbHUyOZy 4Yi/TRVth1kPXRWEVUl98myP9nQE1pqirylV9PzwWfDQanmrKxBoXOTvUUi4PepZ75Yq mPapyvWFZjO8YDoT9x/tB9cgx511fB5rsbAw8EE2/J7TU2wZ0NcTY4K0tJOZoF5XlPRK TdQNpIjdVaoRAvLF9LvX1S81YAyLprLHdaPsikqlER0QnvPj1mpyHsHN7UtijgwLfLbT 2C8A== X-Gm-Message-State: AOAM532HhQmbkS1BizbcSF8JHdAi7tpW4LnyrqXRQyJobKed61sUVwbh +/mlj/5mWwEq17wkpQ5c2OUvJ9X0khoGe7SIcts= X-Google-Smtp-Source: ABdhPJxcdXYxPBJ0zMnbkG3lJir6b5ZH7BVsmzhj4skx4jIMcXZytKdX48d7+KLHBLG1bZz0f/rUrJK1WPdDeVwwe10= X-Received: by 2002:a02:b790:: with SMTP id f16mr7714212jam.2.1637089796090; Tue, 16 Nov 2021 11:09:56 -0800 (PST) MIME-Version: 1.0 References: <20211029204909.21318-1-eagostini@nvidia.com> <20211111214141.26612-1-eagostini@nvidia.com> <20211111214141.26612-2-eagostini@nvidia.com> <569619d5-12fc-4338-3042-3581074ad3a9@intel.com> In-Reply-To: From: Jerin Jacob Date: Wed, 17 Nov 2021 00:39:29 +0530 Message-ID: Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine To: Ferruh Yigit Cc: Elena Agostini , "dev@dpdk.org" , Slava Ovsiienko Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 16, 2021 at 11:42 PM Ferruh Yigit wrote: > > On 11/16/2021 6:06 PM, Elena Agostini wrote: > > > From: Ferruh Yigit > > > > > Date: Tuesday, 16 November 2021 at 19:00 > > > > > To: Elena Agostini > > > > > Cc: dev@dpdk.org , Slava Ovsiienko > > > > > Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine > > > > > External email: Use caution opening links or attachments> > > > > > > > > > > On 11/11/2021 9:41 PM, eagostini@nvidia.com wrote: > > > > > > --- a/app/test-pmd/meson.build > > > > > > +++ b/app/test-pmd/meson.build > > > > > > @@ -32,7 +32,7 @@ if dpdk_conf.has('RTE_HAS_JANSSON') > > > > > > ext_deps += jansson_dep > > > > > > endif > > > > > > > > > > > > -deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'bus_pci'] > > > > > > +deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'bus_pci', 'gpudev']> > > > > > I didn't review the set, but in a very high level do we want to add > > > > > 'gpudev' as dependency? Isn't this like adding 'rawdev' as dependency. > > > > gpudev is a library that can be built without a gpu driver as all the other libraries > > > > and itis actually used only in case of GPU memory mempool. > > > > Reasons for this patch are: > > > > - Have an upstreamed benchmark tool to measure network metrics using GPU memory > > > > - Test some DPDK features not really tested anywhere like the external memory mempool feature > > > > I can see the reason, that is obvious, yet again why we are not adding rawdev > testing to the testpmd? But adding gpudev. > It is easier to add it to the testpmd, and for some testing perspective it > makes sense, but still I am not quite sure about this new dependency, I would > like to get more feedback. I had the similar concern earlier. IMO, It is better to have a separate test application for gpudev like other device classes. For eventdev cases when it needs to work with ethdev for Rx adapter cases, We have enabled such code in app/test-eventdev to make testpmd focus on ethdev.