From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B260A04B0; Sat, 24 Oct 2020 15:06:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 747DDBE3F; Sat, 24 Oct 2020 15:05:58 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 4DCA85953 for ; Sat, 24 Oct 2020 15:05:56 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id r9so5304282ioo.7 for ; Sat, 24 Oct 2020 06:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=gFOsysHBDE0ygbJVpycphRiyrvDLisCZrAjjT9/z3X0=; b=V//jPWgo1w1PHjI8/c7MYC9r7wiF1CGAkdk1Wj91yForEgPtd8xuMfdoGazSnzJBUT 3PsC7/bZW0lnMEeNPZznWyQ4soxHWCaTM/1OEm14u3LjhjiKe2N6F0jeblauDl+fwLt1 ycLEZ04xZiCB/iYjhw5zxkKzSAa8zpuGJda6JmKJBT00H9KQjuciNZSJHP/vtunymCD4 w5Qickeb3jS2cvucYieREcSln//2QjCrXHrSUrCNC9k0PUJVOMg4nZjmloizLloEtPsh NHo++IT+9tVbUTiI445b8/HO56RcCJTQTknK0sIPDXOt1nojt/bekVTXX2JaBsdjuxpa Mp0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gFOsysHBDE0ygbJVpycphRiyrvDLisCZrAjjT9/z3X0=; b=j55wNyCQZ+argzrSKnuzFP3f7KF0f3DKBz2l41uKH999VgAwB0RyrSel6snU0gAvtt 68i4ffvS52+SboXFBNYQc4j14UdWJkbxJFVwvBx4pTRXBw+NTdWMd4jMkD1Tww+q2iN1 AsYksMUc1qqz2sWr3k1zw4lPzhCzd4hhtfkiCj9jOdFw1NMfK7Rs0b7PYgjWfca4HqCl I58AQ1mGY44xlh8Fix4cnDEgOuVjSH0NtxLKg9aDjTdLFxh27skRqdMdEi6YRgibCcRg 6xnVfC/EbkCc25K/SxIUpHJqswTyaMZdrX/RJGNDFNWeGdGL4nRv3Psh1kVl/T45JbJA nJQg== X-Gm-Message-State: AOAM532IFT48ql5UwmZsDtUjgD3UVoKjpjh4B30Tp0897t+y2asvuO6l D7y0ax7kHHUcOcmUWH9aKG0KVS83FMeF1xbxdXI= X-Google-Smtp-Source: ABdhPJzFVFY2sr08HjM+x5/FIuFHp8N5hQvQb7fu9iYx9ZlelmTutBBiiWsC1WpGDt0PyISIV9ddbedAtbPWA25EBwI= X-Received: by 2002:a02:a83:: with SMTP id 125mr5303153jaw.133.1603544755368; Sat, 24 Oct 2020 06:05:55 -0700 (PDT) MIME-Version: 1.0 References: <1596138614-17409-2-git-send-email-timothy.mcdaniel@intel.com> <1603477952-583-1-git-send-email-timothy.mcdaniel@intel.com> <1603477952-583-2-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1603477952-583-2-git-send-email-timothy.mcdaniel@intel.com> From: Jerin Jacob Date: Sat, 24 Oct 2020 18:35:39 +0530 Message-ID: To: Timothy McDaniel Cc: Thomas Monjalon , Bruce Richardson , John McNamara , Marko Kovacevic , Ray Kinsella , Neil Horman , dpdk-dev , Erik Gabriel Carrillo , Gage Eads , "Van Haaren, Harry" , Jerin Jacob Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v6 01/23] event/dlb: add documentation and meson infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Oct 24, 2020 at 12:08 AM Timothy McDaniel wrote: > > Increased RTE_EVENT_MAX_QUEUES_PER_DEV config option > from 64 to 255. Please send a separate patch for changing this value with reason. > > Note that config/rte_config.h contains several configuration > switches, providing for fine control of the PMD's > runtime behaviour. > > The meson infrastructure is expanded as additional files are > added to this patchset. Also, there are similar build errors[1] found as reported by DLB2. [1] Message: Disabling mlx5 [drivers/vdpa/mlx5]: missing internal dependency "common_mlx5" drivers/meson.build:179: WARNING: Custom target input '/export/dpdk-next-eventdev/drivers/event/dlb/version.map' can't be converted to File object(s). This will become a hard error in the future. drivers/meson.build:184: WARNING: Custom target input '/export/dpdk-next-eventdev/drivers/event/dlb/version.map' can't be converted to File object(s). This will become a hard error in the future. drivers/meson.build:207:3: ERROR: File /export/dpdk-next-eventdev/drivers/event/dlb/version.map does not exist. A full log can be found at /export/dpdk-next-eventdev/build-gcc-static/meson-logs/meson-log.txt > > Signed-off-by: Timothy McDaniel > --- > MAINTAINERS | 5 ++++ > config/rte_config.h | 8 +++++- > doc/guides/eventdevs/dlb.rst | 36 +++++++++++++++++++= ++++++ > doc/guides/eventdevs/index.rst | 1 + > drivers/event/dlb/meson.build | 13 +++++++++ > drivers/event/dlb/rte_pmd_dlb_event_version.map | 3 +++ > drivers/event/meson.build | 2 +- > 7 files changed, 66 insertions(+), 2 deletions(-) > create mode 100644 doc/guides/eventdevs/dlb.rst > create mode 100644 drivers/event/dlb/meson.build > create mode 100644 drivers/event/dlb/rte_pmd_dlb_event_version.map > > diff --git a/MAINTAINERS b/MAINTAINERS > index c0abbe0..2ca4a4f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1188,6 +1188,11 @@ M: Peter Mccarthy > F: drivers/event/opdl/ > F: doc/guides/eventdevs/opdl.rst > > +Intel DLB Eventdev PMD > +M: Timothy McDaniel > +F: drivers/event/dlb/ > +F: doc/guides/eventdevs/dlb.rst > + > > Rawdev Drivers > -------------- > diff --git a/config/rte_config.h b/config/rte_config.h > index 0bae630..4262339 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -70,7 +70,7 @@ > > /* eventdev defines */ > #define RTE_EVENT_MAX_DEVS 16 > -#define RTE_EVENT_MAX_QUEUES_PER_DEV 64 > +#define RTE_EVENT_MAX_QUEUES_PER_DEV 255 > #define RTE_EVENT_TIMER_ADAPTER_NUM_MAX 32 > #define RTE_EVENT_ETH_INTR_RING_SIZE 1024 > #define RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE 32 > @@ -131,4 +131,10 @@ > /* QEDE PMD defines */ > #define RTE_LIBRTE_QEDE_FW "" > > +/* DLB PMD defines */ > +#define RTE_LIBRTE_PMD_DLB_POLL_INTERVAL 1000 > +#define RTE_LIBRTE_PMD_DLB_UMWAIT_CTL_STATE 0 > +#undef RTE_LIBRTE_PMD_DLB_QUELL_STATS > +#define RTE_LIBRTE_PMD_DLB_SW_CREDIT_QUANTA 32 > + > #endif /* _RTE_CONFIG_H_ */ > diff --git a/doc/guides/eventdevs/dlb.rst b/doc/guides/eventdevs/dlb.rst > new file mode 100644 > index 0000000..92341c0 > --- /dev/null > +++ b/doc/guides/eventdevs/dlb.rst > @@ -0,0 +1,36 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Copyright(c) 2020 Intel Corporation. > + > +Driver for the Intel=C2=AE Dynamic Load Balancer (DLB) > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > + > +The DPDK dlb poll mode driver supports the Intel=C2=AE Dynamic Load Bala= ncer. > + > +Prerequisites > +------------- > + > +Follow the DPDK :ref:`Getting Started Guide for Linux ` to se= tup > +the basic DPDK environment. > + > +Configuration > +------------- > + > +The DLB PF PMD is a user-space PMD that uses VFIO to gain direct > +device access. To use this operation mode, the PCIe PF device must be bo= und > +to a DPDK-compatible VFIO driver, such as vfio-pci. > + > +Eventdev API Notes > +------------------ > + > +The DLB provides the functions of a DPDK event device; specifically, it > +supports atomic, ordered, and parallel scheduling events from queues to = ports. > +However, the DLB hardware is not a perfect match to the eventdev API. So= me DLB > +features are abstracted by the PMD (e.g. directed ports), some are only > +accessible as vdev command-line parameters, and certain eventdev feature= s are > +not supported (e.g. the event flow ID is not maintained during schedulin= g). > + > +In general the dlb PMD is designed for ease-of-use and does not require = a > +detailed understanding of the hardware, but these details are important = when > +writing high-performance code. This section describes the places where t= he > +eventdev API and DLB misalign. > + > diff --git a/doc/guides/eventdevs/index.rst b/doc/guides/eventdevs/index.= rst > index bb66a5e..4b915bf 100644 > --- a/doc/guides/eventdevs/index.rst > +++ b/doc/guides/eventdevs/index.rst > @@ -11,6 +11,7 @@ application through the eventdev API. > :maxdepth: 2 > :numbered: > > + dlb > dpaa > dpaa2 > dsw > diff --git a/drivers/event/dlb/meson.build b/drivers/event/dlb/meson.buil= d > new file mode 100644 > index 0000000..5324043 > --- /dev/null > +++ b/drivers/event/dlb/meson.build > @@ -0,0 +1,13 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2019-2020 Intel Corporation > + > +if not is_linux or not dpdk_conf.has('RTE_ARCH_X86_64') > + build =3D false > + reason =3D 'only supported on ARCH_X86_64 Linux' > + subdir_done() > +endif > + > +sources =3D files( > +) > + > +deps +=3D ['mbuf', 'mempool', 'ring', 'pci', 'bus_pci'] > diff --git a/drivers/event/dlb/rte_pmd_dlb_event_version.map b/drivers/ev= ent/dlb/rte_pmd_dlb_event_version.map > new file mode 100644 > index 0000000..4a76d1d > --- /dev/null > +++ b/drivers/event/dlb/rte_pmd_dlb_event_version.map > @@ -0,0 +1,3 @@ > +DPDK_21 { > + local: *; > +}; > diff --git a/drivers/event/meson.build b/drivers/event/meson.build > index ebe76a7..5030764 100644 > --- a/drivers/event/meson.build > +++ b/drivers/event/meson.build > @@ -5,7 +5,7 @@ if is_windows > subdir_done() > endif > > -drivers =3D ['dpaa', 'dpaa2', 'octeontx2', 'opdl', 'skeleton', 'sw', 'ds= w'] > +drivers =3D ['dlb', 'dpaa', 'dpaa2', 'octeontx2', 'opdl', 'skeleton', 's= w', 'dsw'] > if not (toolchain =3D=3D 'gcc' and cc.version().version_compare('<4.8.6'= ) and > dpdk_conf.has('RTE_ARCH_ARM64')) > drivers +=3D 'octeontx' > -- > 2.6.4 >