From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E90C642CA7; Tue, 13 Jun 2023 18:02:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7BA5840C35; Tue, 13 Jun 2023 18:02:03 +0200 (CEST) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by mails.dpdk.org (Postfix) with ESMTP id B2B0A40A8A for ; Tue, 13 Jun 2023 18:02:01 +0200 (CEST) Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-6b2041315a5so3033929a34.0 for ; Tue, 13 Jun 2023 09:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686672121; x=1689264121; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rijc0fzLtOEUCBr7r4HGKbdqBTKT6/WKDH69VWLYf+s=; b=CrsJBlMyjKoyGPPPyMU1EDR0dQ5F/KI/c6Ud1HfgARofSBMXAZYRhRS0+288wK0Iq9 wBrcABZ88XdE0CtcOiZV7s/PjpzUEjrdI+ChzKXiszDedJ4j5W8lYBRwbzCnlJmj939I K7OLQD9W6d1Dy0fI5AccMx6XebTMvM6MoG9omNvR4VwTZ6G88RGL2Z06ohjkquLPiM93 hgUkBm9J0CEOex0USCiGCsQPOq2F2zwpkDvhnHJJF98ppP6P30Scxf1iLhwYot9gOnCF sEJ9A2bhYnSC2uQyVAOTo05kmj87IjmzJcvSaYMQ5O0ADWRmNxcw5HDSHQaWeOXtToyI e+XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686672121; x=1689264121; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rijc0fzLtOEUCBr7r4HGKbdqBTKT6/WKDH69VWLYf+s=; b=SSksecyUGXGx+6JMy2O8sK2Od4OSy27XQVDK6FdlgWqd4j69RNU50XbsCFw7sMsIi1 3ybVChPYHoNsSshe12Cs0gqabn94G457VZMC4zv08iKD7hj67KeWzNkx5TAOCFxAGSZR hn+rqTs0JWYXwYpiyXkRJsD7CcJBZhgIVHf531lHT0NKZrrWwsX4NMk91CTqOpGvxMKq sIW7PnDpLrNwbHuoKQjwd2JFSOEP/waw6niZoJnbtHjF+5dxT2pMZRMeG8Ru3KGlm4Qy hPIqIYpAgVRJ+PQv9lkXnVoT/cd8XDlMan5f5P4Ovzy91S8btLxoKSSG2PTSLMs/vY9V AhZA== X-Gm-Message-State: AC+VfDwmCVZ6fX9ORR+SqLExyqI6EGwOreOqglC17upx7vn2Jka1GDrB w3QoxIglE9Cfp54DvtZTQJPiBmrh4DpMCA4dj/ZsdwlSeMo= X-Google-Smtp-Source: ACHHUZ6kjmodL15VoTuoTSUJEsD7e43iKCejZi5LfHUVGOmDuBBqawAyNwvlXo28eu6MOeqmK5g+7eOU/P+6r2dViLM= X-Received: by 2002:a05:6358:704a:b0:12b:d261:4ac with SMTP id 10-20020a056358704a00b0012bd26104acmr4165958rwp.23.1686672120675; Tue, 13 Jun 2023 09:02:00 -0700 (PDT) MIME-Version: 1.0 References: <20230420100803.494-1-viacheslavo@nvidia.com> <20230420100803.494-3-viacheslavo@nvidia.com> In-Reply-To: From: Jerin Jacob Date: Tue, 13 Jun 2023 21:31:34 +0530 Message-ID: Subject: Re: [RFC 2/5] common/mlx5: introduce tracepoints for mlx5 drivers To: Slava Ovsiienko Cc: "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 13, 2023 at 9:29=E2=80=AFPM Slava Ovsiienko wrote: > > Hi, > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Tuesday, June 13, 2023 6:53 PM > > To: Slava Ovsiienko > > Cc: dev@dpdk.org > > Subject: Re: [RFC 2/5] common/mlx5: introduce tracepoints for mlx5 driv= ers > > > > On Tue, Jun 13, 2023 at 9:20=E2=80=AFPM Slava Ovsiienko > > wrote: > > > > > > Hi, > > > > > > <..snip..> > > > > > > > > > > mlx5_os_interrupt_handler_create; # WINDOWS_NO_EXPORT > > > > > mlx5_os_interrupt_handler_destroy; # WINDOWS_NO_EXPORT > > > > > + > > > > > + __rte_pmd_mlx5_trace_tx_entry; > > > > > + __rte_pmd_mlx5_trace_tx_exit; > > > > > + __rte_pmd_mlx5_trace_tx_wqe; > > > > > + __rte_pmd_mlx5_trace_tx_wait; > > > > > + __rte_pmd_mlx5_trace_tx_push; > > > > > + __rte_pmd_mlx5_trace_tx_complete; > > > > > > > > No need to expose these symbols. It is getting removed from rest of= DPDK. > > > > Application can do rte_trace_lookup() to get this address. > > > > > > > > > > > It is not for application, it is for PMD itself, w/o exposing the sym= bols build > > failed. > > > > PMD is implementing this trace endpoints, not consuming this trace poin= t. > > Right? If so, Why to expose these symbols? > > As far as understand: > The tracepoint routines are defined in dedicated common/mlx5_trace.c file= . > The tx_burst in mlx5 is implemented as template in header file, and this > template is used in multiple .c files under net/mlx5 filder. > So, common/mlx5 should expose its symbols to net/mlx5 to allow successful > linkage. OK. I missed the fact the these are in common code and net driver is depened on that. So changes makes sense. > > With best regards, > Slava