From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1888B459BF; Tue, 17 Sep 2024 17:51:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 041AD40280; Tue, 17 Sep 2024 17:51:08 +0200 (CEST) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by mails.dpdk.org (Postfix) with ESMTP id 485FF40261 for ; Tue, 17 Sep 2024 17:51:07 +0200 (CEST) Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-457ce5fda1aso49438971cf.1 for ; Tue, 17 Sep 2024 08:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726588266; x=1727193066; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=f/t8Plc5eGkrY3rdBqMeK8nD0eQYgEGXe9q0SOcaJWI=; b=BidVYYT4WZBMugt9mwvoBXkvxYNScXSK6bfFKlk6Kp9tJSnQn5P9MPUJsWuSfISBbk Ho6riJS1NOSoCHR2QA3Oqvxt6BQQzmx+DszYUWSDI35kOREMLpzUlGHOpsyq7E6gCzcQ JquzqVs66mihfH3FBXh0Sq0n9W8zsk7Pr/2xPcBqbCYSFxrB/4UBEvndCE2gaR9oORdh 0qIIffl1e+Qrjs8BnGQquuRde8Ui4c9rKlAgf+CzhRRQl3Lvr3b6rbHOqGeuhFd4Na91 8+JRHXFgUTOfo14yONcTuw9VV9tRvGSjAQ6hDDMPRwIkcyO5isYsfC3wMTx7IlX/guV4 q6/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726588266; x=1727193066; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f/t8Plc5eGkrY3rdBqMeK8nD0eQYgEGXe9q0SOcaJWI=; b=SQW/SyffI3veKLQmBZyBWh74SXsZnJHlE9YdrG2pjxaLUqtHI+v4sbjCNCnYCxaO6i kTbQwTs/0CWPK2BKHwDtkMio3rtPMXSsvdzpcwQnegK6JHCQoN3aEjH0EWqYIX21+eRN CHzjC/1RyYGRBls7VFDhU9m9EuRBMWvdUMPS67LILQdom+nhFdg4kHwZR9B/KfzzfQjt wsMPccmLbIz9gBlWNRjUxt/XI7X8ddMtmwJL8/jb05xnnTK13d8dZhCDOpVg59U9bH8X SSwsmW8R7beLgwbR3G3EhomkOT82Qk7Cm1zaNzoHURTBiqMJMcThT9sR42UQb9nD3Cp8 mOYQ== X-Forwarded-Encrypted: i=1; AJvYcCVvYonvE5KT0eiL8KbGA6SlkfNLNYgLTGyjpE9egElRgmuKrqVxamnAyxWRhEXr+rtd0Ns=@dpdk.org X-Gm-Message-State: AOJu0Ywv15HUuRMqUsTPho0TUzX8TNsqCPVZ5QIyN9ywKfQWDhb5mHde 4C5zeGTDBTPUkkJf/ijH6hz+DJSsbTEeABsJeTVF+68LKu6+8vD7tmoT7IKe8brEDtqXauKypRK PzGQD8oyErQbKFaVn/Tf0IBGbMuKVQ/5lJJY= X-Google-Smtp-Source: AGHT+IG1Yl7jhUy7UI111srFFEnGQYsf3SHsnyNli7PrXCLpzAdk9SXzEjQmSVTxjHcAv1b6L56yq1Vyx/Uz69BZub4= X-Received: by 2002:a05:622a:82:b0:458:2607:d5a7 with SMTP id d75a77b69052e-458603e745dmr269434001cf.43.1726588266507; Tue, 17 Sep 2024 08:51:06 -0700 (PDT) MIME-Version: 1.0 References: <20240801111120.5380-1-fengchengwen@huawei.com> In-Reply-To: <20240801111120.5380-1-fengchengwen@huawei.com> From: Jerin Jacob Date: Tue, 17 Sep 2024 21:20:40 +0530 Message-ID: Subject: Re: [PATCH] examples/eventdev: fix segment fault with generic pipeline To: Chengwen Feng Cc: thomas@monjalon.net, dev@dpdk.org, harry.van.haaren@intel.com, wangchenxingyu@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 1, 2024 at 4:54=E2=80=AFPM Chengwen Feng wrote: > > There was a segmentation fault when executing eventdev_pipeline with > command [1] with ConnectX-5 NIC card: > > 0x000000000079208c in rte_eth_tx_buffer (tx_pkt=3D0x16f8ed300, buffer=3D0= x100, queue_id=3D11, port_id=3D0) at ../lib/ethdev/rte_ethdev.h:6636 > txa_service_tx (txa=3D0x17b19d080, ev=3D0xffffffffe500, n=3D4) at ../lib/= eventdev/rte_event_eth_tx_adapter.c:631 > 0x0000000000792234 in txa_service_func (args=3D0x17b19d080) at ../lib/eve= ntdev/rte_event_eth_tx_adapter.c:666 > 0x00000000008b0784 in service_runner_do_callback (s=3D0x17fffe100, cs=3D0= x17ffb5f80, service_idx=3D2) at ../lib/eal/common/rte_service.c:405 > 0x00000000008b0ad8 in service_run (i=3D2, cs=3D0x17ffb5f80, service_mask= =3D18446744073709551615, s=3D0x17fffe100, serialize_mt_unsafe=3D0) > at ../lib/eal/common/rte_service.c:441 > 0x00000000008b0c68 in rte_service_run_iter_on_app_lcore (id=3D2, serializ= e_mt_unsafe=3D0) at ../lib/eal/common/rte_service.c:477 > 0x000000000057bcc4 in schedule_devices (lcore_id=3D0) at ../examples/even= tdev_pipeline/pipeline_common.h:138 > 0x000000000057ca94 in worker_generic_burst (arg=3D0x17b131e80) at ../exam= ples/eventdev_pipeline/pipeline_worker_generic.c:83 > 0x00000000005794a8 in main (argc=3D11, argv=3D0xfffffffff470) at ../examp= les/eventdev_pipeline/main.c:449 > > The root cause is that the queue_id (11) is invalid, the queue_id comes > from mbuf.hash.txadapter.txq which may pre-write by NIC driver when > receiving packets (e.g. pre-write mbuf.hash.fdir.hi field). > > Because this example only enabled one ethdev queue, so fixes it by reset > txq to zero in the first worker stage. > > [1] dpdk-eventdev_pipeline -l 0-48 --vdev event_sw0 -- -r1 -t1 -e1 -w ff0= -s5 -n0 -c32 -W1000 -D > When launch eventdev_pipeline with command [1], event_sw > > Fixes: 81fb40f95c82 ("examples/eventdev: add generic worker pipeline") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > Reported-by: Chenxingyu Wang Lot of check patch issues Line too long: 0x000000000079208c in rte_eth_tx_buffer (tx_pkt=3D0x16f8ed300, buffer=3D0x100, queue_id=3D11, port_id=3D0) at ../lib/ethdev/rte_ethdev.h:6636 txa_service_tx (txa=3D0x17b19d080, ev=3D0xffffffffe500, n=3D4) at ../lib/eventdev/rte_event_eth_tx_adapter.c:631 0x0000000000792234 in txa_service_func (args=3D0x17b19d080) at ../lib/eventdev/rte_event_eth_tx_adapter.c:666 0x00000000008b0784 in service_runner_do_callback (s=3D0x17fffe100, cs=3D0x17ffb5f80, service_idx=3D2) at ../lib/eal/common/rte_service.c:405 0x00000000008b0ad8 in service_run (i=3D2, cs=3D0x17ffb5f80, service_mask=3D18446744073709551615, s=3D0x17fffe100, serialize_mt_unsafe=3D0) 0x00000000008b0c68 in rte_service_run_iter_on_app_lcore (id=3D2, serialize_mt_unsafe=3D0) at ../lib/eal/common/rte_service.c:477 0x000000000057bcc4 in schedule_devices (lcore_id=3D0) at ../examples/eventdev_pipeline/pipeline_common.h:138 0x000000000057ca94 in worker_generic_burst (arg=3D0x17b131e80) at ../examples/eventdev_pipeline/pipeline_worker_generic.c:83 0x00000000005794a8 in main (argc=3D11, argv=3D0xfffffffff470) at ../examples/eventdev_pipeline/main.c:449 [1] dpdk-eventdev_pipeline -l 0-48 --vdev event_sw0 -- -r1 -t1 -e1 -w ff0 -s5 -n0 -c32 -W1000 -D Contributor name/email mismatch with .mailmap: Chenxingyu Wang is unknown in .mailmap Invalid patch(es) found - checked 1 patch check-git-log failed ### [PATCH] examples/eventdev: fix segment fault with generic pipeline WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #9: 0x000000000079208c in rte_eth_tx_buffer (tx_pkt=3D0x16f8ed300, buffer=3D0x100, queue_id=3D11, port_id=3D0) at ../lib/ethdev/rte_ethdev.h:6636 WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report #34: Reported-by: Chenxingyu Wang Acked-by: Pavan Nikhilesh