From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32EA7A31F3 for ; Sat, 19 Oct 2019 11:48:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 772DF1BF9D; Sat, 19 Oct 2019 11:48:12 +0200 (CEST) Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id 6ED281BEE6 for ; Sat, 19 Oct 2019 11:48:10 +0200 (CEST) Received: by mail-il1-f195.google.com with SMTP id m16so1356489iln.13 for ; Sat, 19 Oct 2019 02:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=53qcbsAd/6I1Q/5hL3aAcQnNlpMwYIhOitj2n4KcYvE=; b=odcCr+L7+hWfJAnbA1NrEDklk4+ST9b5c+z+tI0NQeOmP0G0i5605ea3Es5zKp4JQm Xrr1LOZGmzoRloWJ4890r0GQwJfUOoW8X6W/BVXoNxIsi6oKGqrJz0/ufQjUPvzlX850 xWFSHCuUqF4rISfuthGH/VwEuHae4WhyF5+1EeAvZUTyfh6XkhW+ON8ns1zsRBIF5Dcr pphesxZeKMR8/e+G+zEZwMqgqxFDlieBo2EhW2Uila0h2VgJqXICDObaNYJPfxB2ddg9 HHdYdmXB3zMOnwMthnF2R51qGXwggkCkoe4z3RMCuoQ42naqBYlyVxGtNwPpIgHe2lhA 8H8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=53qcbsAd/6I1Q/5hL3aAcQnNlpMwYIhOitj2n4KcYvE=; b=JR5KUL3z8SiCOVgoQRVknGNzaj+vqES5nuBVLv1sXbWqOUaB41hHmnhtDGqqRAi+2x ctHL05md9t0A1wwsNDx0HWyaQZkWlRhx+f+lS+LtfR3LE5ITvv7QAgi/IvoA9wavCN4a I9XvOiz1djRKJU/fGZhDDriseJA3bycyePrYjr1JhvdPC0rwHY8Q3WpjvY/vuMY97xcb JO/JejApIYavf2DWY133IkGW/MpznZmfQJqC6UOTEDIKLHNmSTb241SrcucZUY0l++ta ZIr7NkgbMJlQstfrc3M61AIpqyBbGh1c2vWBJzOurJcwRn4ZyXW06ihrKdP5HFgkPIhX qjsQ== X-Gm-Message-State: APjAAAU/YupgHzJbEfdJoqWZhvvKJAVwI2og2FYdtHTjIHQD7Jg1fraP Tknyj+tY97u4l9gut+1ttDkgI409UNJXje4PzcM= X-Google-Smtp-Source: APXvYqzDFbEyLx+lZlgVqTeAfhOv3f9iO1rlnrzNzdbGaIw5y9GojMP0FBBtpwqPMXW/PTO/cK5FnvGaVSEAIaIeJDU= X-Received: by 2002:a92:ce12:: with SMTP id b18mr384368ilo.130.1571478489545; Sat, 19 Oct 2019 02:48:09 -0700 (PDT) MIME-Version: 1.0 References: <20191018041300.22290-1-kirankumark@marvell.com> <20191019045657.399-1-kirankumark@marvell.com> In-Reply-To: <20191019045657.399-1-kirankumark@marvell.com> From: Jerin Jacob Date: Sat, 19 Oct 2019 15:17:53 +0530 Message-ID: To: Kiran Kumar K Cc: Adrien Mazarguil , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Olivier Matz , dpdk-dev , Ajit Khaparde Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6] ethdev: add HIGIG2 key field to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Oct 19, 2019 at 10:27 AM wrote: > > From: Kiran Kumar K > > Add new rte_flow_item_higig2_hdr in order to match higig2 header. > It is a layer 2.5 protocol and used in Broadcom switches. > Header format is based on the following document. > http://read.pudn.com/downloads558/doc/comm/2301468/HiGig_protocol.pdf > > Signed-off-by: Kiran Kumar K > index 000000000..7c0dec449 > --- /dev/null > +++ b/lib/librte_net/rte_higig.h > @@ -0,0 +1,138 @@ [snip] > +/** > + * RTE_FLOW_ITEM_TYPE_HIGIG2 > + * Matches higig2 header. > + */ rte_higig.h is a generic file, it should not have any reference to rte_flow Doxygen comment could be "higig2 frc header" > +struct rte_higig2_frc { > +}; Missing doxygen comments here. > +struct rte_higig2_ppt_type0 { > +#if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN > +#endif > +}; Missing Doxygen comments here. > +struct rte_higig2_ppt_type1 { > +#endif > +}; > + Missing Doxygen comments here. > +RTE_STD_C11 > +struct rte_flow_item_higig2_hdr { Change to rte_higig2_hdr and see below. > + struct rte_higig2_frc fcr; > + union { > + struct rte_higig2_ppt_type0 ppt0; > + struct rte_higig2_ppt_type1 ppt1; > + }; > +}; > +/** Default mask for RTE_FLOW_ITEM_TYPE_HIGIG2. */ > +#ifndef __cplusplus > +static const struct rte_flow_item_higig2_hdr rte_flow_item_higig2_hdr_mask = { > + .ppt1.classification = 0xffff, > + .ppt1.vid = 0xfff, > +}; > +#endif move this to rte_flow.h and add the following rte_flow.h so that rte_higig.h is standalone it can be used for other purposes other than rte_flow. /** * RTE_FLOW_ITEM_TYPE_HIGIG2. * * Matches higig2 header. */ struct rte_flow_item_higig2_hdr { struct rte_higig2_hdr hdr; /**< Higig2 header definition. */ }; See rte_flow_item_tcp and rte_tcp_hdr as reference usage. > + > +#ifdef __cplusplus > +} > +#endif > + > +#endif /* RTE_HIGIG_H_ */ > -- > 2.17.1 >