From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B4BAA0C41; Thu, 16 Sep 2021 06:59:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96E954003F; Thu, 16 Sep 2021 06:59:34 +0200 (CEST) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by mails.dpdk.org (Postfix) with ESMTP id B22364003C for ; Thu, 16 Sep 2021 06:59:33 +0200 (CEST) Received: by mail-io1-f43.google.com with SMTP id n128so6419345iod.5 for ; Wed, 15 Sep 2021 21:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xBWuFat74p6k/UeLcqa5H3mJX/kxxsVZCHeo3qwE+0U=; b=VnWdQ4oNqvf5VAD/bemWIFDotXP0NW0ySiKT3WsA0ptglGs0j4h/mPX60mtCRt5D0M QdbRpxfhUI5IyEm+ye6l821OhlxxuulFNI0oo7xBRjSQGQGg+F2cr4imwzt6trxDtpbu /HJc2ixBw5dcWsmwNE/X3yTittx6eN2VxSOnHtoKWqXc6PKJLFiYGMi599rrt1SgHFOk st5AXDUR75yck2gLfiNN9rODunoL3YSp5hFFjforQ0rz8hq4H6ci2n2TrICk0JQzYIfZ rCewPZ/WGgo1t54qqzRUlyreMgylQWZz2OBe/KgUBvXkRYzNeVFxcyNGtIjRQaY1bRSh HC/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xBWuFat74p6k/UeLcqa5H3mJX/kxxsVZCHeo3qwE+0U=; b=4/CN3z7g/QgpuYpnWmyQqgkRO3aqhi/0112ToKL2bFKYqOMQR2Nwl3qEhZQmSztGd6 UvqagJmKnbuNFMedAH2s9mZPOdWDSkCVcLvBhcHgMLTciTJuPDf0PX+l/pzJPQ0HSHk/ Zf3pxxUOrUtCS9IS+hP8jN1SqQI6wzGAYG4rX4oF5Z1tRwp+XmiuAknvtOp6zeQKy9nN /IpdL1vdShqvNE3vFqhQzeT+ScjNaVWnduclBH4ChXVJJeH0LYIoED3iJh27oMm6VMrD xKxYizXO3s5AZaryAf8GbDYu/HNt/1HxBDcYJHsgiNrgOcSF0Y18mD32w0s09o6Lc/vx T+Sg== X-Gm-Message-State: AOAM533xKdsZvkTtWyy5AB0Xajk4dOd7zh4FIGNH+Sw9tXB0615TIPm2 BzdcneiX8a9HQUveTFQCEhxrjj9wqLFH4aTUZ3sli5Lh3tGUIA== X-Google-Smtp-Source: ABdhPJxiezi9z3qgxJ6lagQmtAPIOEqpu5YB/a5ir5PUZumih3XLgUCAsO1+BwvEapkzg0fxyBMFBiH9+tuWwA/s5Pk= X-Received: by 2002:a02:7160:: with SMTP id n32mr1982349jaf.99.1631768372952; Wed, 15 Sep 2021 21:59:32 -0700 (PDT) MIME-Version: 1.0 References: <20210909125422.31144-1-harry.van.haaren@intel.com> <20210909125422.31144-2-harry.van.haaren@intel.com> In-Reply-To: <20210909125422.31144-2-harry.van.haaren@intel.com> From: Jerin Jacob Date: Thu, 16 Sep 2021 10:29:06 +0530 Message-ID: To: Harry van Haaren Cc: dpdk-dev , pravin.pathak@intel.com, "McDaniel, Timothy" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/2] lib/eventdev: add usage hints to port configure API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 9, 2021 at 6:24 PM Harry van Haaren wrote: > > This commit introduces 3 flags to the port configuration flags. > These flags allow the application to indicate what type of work > is expected to be performed by an eventdev port. > > The three new flags are > - RTE_EVENT_PORT_CFG_HINT_PRODUCER (mostly RTE_EVENT_OP_NEW events) > - RTE_EVENT_PORT_CFG_HINT_CONSUMER (mostly RTE_EVENT_OP_RELEASE events) > - RTE_EVENT_PORT_CFG_HINT_WORKER (mostly RTE_EVENT_OP_FORWARD events) > > These flags are only hints, and the PMDs must operate under the > assumption that any port can enqueue an event with any type of op. This change looks good to me. + @Mattias R=C3=B6nnblom @Erik Gabriel Carrillo @Gujjar, Abhinandan S @Pavan Nikhilesh @Hemant Agrawal @Nipun Gupta @Liang Ma @McDaniel, Timothy # Please change subject to evendev: .... # Please submit the driver changes as well and updated performance gain with the scheme. # Please find below one comment > > Signed-off-by: Harry van Haaren > --- > lib/eventdev/rte_eventdev.h | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > index a9c496fb62..159b580938 100644 > --- a/lib/eventdev/rte_eventdev.h > +++ b/lib/eventdev/rte_eventdev.h > @@ -709,6 +709,29 @@ rte_event_queue_attr_get(uint8_t dev_id, uint8_t que= ue_id, uint32_t attr_id, > * > * @see rte_event_port_setup(), rte_event_port_link() > */ > +#define RTE_EVENT_PORT_CFG_HINT_PRODUCER (1ULL << 2) > +/**< Hint that this event port will primarily enqueue events to the syst= em. > + * A PMD can optimize its internal workings by assuming that this port i= s > + * primarily going to enqueue NEW events. Note that this flag is only a = hint. IMO, We can explicitly add the following line in each comment. PMDs must operate under the assumption that any port can enqueue an event with any type of op. > + * > + * @see rte_event_port_setup() > + */ > +#define RTE_EVENT_PORT_CFG_HINT_CONSUMER (1ULL << 3) > +/**< Hint that this event port will primarily dequeue events from the sy= stem. > + * A PMD can optimize its internal workings by assuming that this port i= s > + * primarily going to consume events, and not enqueue FORWARD or RELEASE= events. > + * Note that this flag is only a hint. > + * > + * @see rte_event_port_setup() > + */ > +#define RTE_EVENT_PORT_CFG_HINT_WORKER (1ULL << 4) > +/**< Hint that this event port will primarily events to the system. > + * A PMD can optimize its internal workings by assuming that this port i= s > + * primarily going to FORWARD events, and not enqueue NEW or RELEASE eve= nts > + * often. Note that this flag is only a hint. > + * > + * @see rte_event_port_setup() > + */ > > /** Event port configuration structure */ > struct rte_event_port_conf { > -- > 2.30.2 >