From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/5] event/octeontx2: fix TIM HW race condition
Date: Thu, 21 Nov 2019 08:39:05 +0530 [thread overview]
Message-ID: <CALBAE1Mr0KAacCtiPF=CuxWNtHKRbuncVp_oSSxoZvJ2QwgfAQ@mail.gmail.com> (raw)
In-Reply-To: <20191120045626.10886-1-pbhagavatula@marvell.com>
On Wed, Nov 20, 2019 at 10:26 AM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Fix HW race condition observed when timeout resolution is low (<5us).
> When HW traverses a given TIM bucket it will clear chunk_remainder,
> but since SW always decreases the chunk_remainder at the start of the
> arm routine it might cause a race where SW updates chunk_remainder
> after HW has cleared it that lead to nasty side effects.
>
> Fixes: 95e4e4ec7469 ("event/octeontx2: add timer arm timeout burst")
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Please fix the build issue with x86_32 with this series.
https://travis-ci.com/ovsrobot/dpdk/jobs/258482444
drivers/event/octeontx2/otx2_tim_worker.h: In function ‘tim_add_entry_sp’:
drivers/common/octeontx2/otx2_common.h:31:26: error: left shift count
>= width of type [-Werror=shift-count-overflow]
31 | #define BIT(nr) (1UL << (nr))
| ^~
drivers/event/octeontx2/otx2_tim_worker.h:265:25: note: in expansion
of macro ‘BIT’
265 | } while (hbt_state & BIT(33));
| ^~~
drivers/common/octeontx2/otx2_common.h:31:26: error: left shift count
>= width of type [-Werror=shift-count-overflow]
31 | #define BIT(nr) (1UL << (nr))
| ^~
drivers/event/octeontx2/otx2_tim_worker.h:268:22: note: in expansion
of macro ‘BIT’
268 | if (!(hbt_state & BIT(34))) {
| ^~~
drivers/event/octeontx2/otx2_tim_worker.h: In function ‘tim_add_entry_mp’:
drivers/common/octeontx2/otx2_common.h:31:26: error: left shift count
>= width of type [-Werror=shift-count-overflow]
31 | #define BIT(nr) (1UL << (nr))
next prev parent reply other threads:[~2019-11-21 3:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 4:56 pbhagavatula
2019-11-20 4:56 ` [dpdk-dev] [PATCH 2/5] event/octeontx2: use opposite bucket to store current chunk pbhagavatula
2019-11-20 4:56 ` [dpdk-dev] [PATCH 3/5] event/octeontx2: improve chunk pool performance pbhagavatula
2019-11-20 4:56 ` [dpdk-dev] [PATCH 4/5] event/octeontx2: update SSO buffers based on timer count pbhagavatula
2019-11-20 4:56 ` [dpdk-dev] [PATCH 5/5] event/octeontx2: update start timestamp periodically pbhagavatula
2019-11-21 3:09 ` Jerin Jacob [this message]
2019-11-21 7:13 ` [dpdk-dev] [PATCH v2 1/5] event/octeontx2: fix TIM HW race condition pbhagavatula
2019-11-21 7:13 ` [dpdk-dev] [PATCH v2 2/5] event/octeontx2: use opposite bucket to store current chunk pbhagavatula
2019-11-21 7:13 ` [dpdk-dev] [PATCH v2 3/5] event/octeontx2: improve chunk pool performance pbhagavatula
2019-11-21 7:13 ` [dpdk-dev] [PATCH v2 4/5] event/octeontx2: update SSO buffers based on timer count pbhagavatula
2019-11-21 7:13 ` [dpdk-dev] [PATCH v2 5/5] event/octeontx2: update start timestamp periodically pbhagavatula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1Mr0KAacCtiPF=CuxWNtHKRbuncVp_oSSxoZvJ2QwgfAQ@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).