From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A675A04C2; Thu, 21 Nov 2019 04:09:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8A19727D; Thu, 21 Nov 2019 04:09:24 +0100 (CET) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id C743E235 for ; Thu, 21 Nov 2019 04:09:22 +0100 (CET) Received: by mail-io1-f66.google.com with SMTP id k13so1653665ioa.9 for ; Wed, 20 Nov 2019 19:09:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=tAbwqK/wz7zZWlD0w1ms9wp18w0twYhcL9ueLtM6uw0=; b=c6zGmuvPnqrWJ9pKsXCjR1Zl83DIQfdNNvBkMjQNh+thyf4i9WISSTQNy0ZrcF00Eg TL49sIiHQREagwUx9yY3ei+F01Ah3cXgy2Wnrx8/W77aAQCPgs+6YNEpLF5Pv/z2NdY8 Yyoo9kSXZh2LSSt9noruKsvn3uRdElPOTzAYsM4uteQ/YOW+3xCjMgG0fhjNJlZ899h+ uXVFpZbZGLgkWo08fMKaoR1ZYhqnZk64QwkJ3P2TXm8EX2toHL1IJYF+rwVw0oFAWtdO uy+kPL4vldimPq/3tlffpUmSEA/VvlyNp99kIYrd0z6lG4OwVu9yNioOrqueYX1BoaEI Tsgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tAbwqK/wz7zZWlD0w1ms9wp18w0twYhcL9ueLtM6uw0=; b=fM++PeWlKKqfEevPvsWFehzgaFbWEzywDHQ0w7WKF/KjwD0oZj/VgW5KcVGgbNskIs uSh7N4WcvPKf5zyHm6bQVVQ5mDNSgN243eTkf7XX/zAaNB1ZG0a99qiestsv+Pzsrb7d od5anqbUq+/i1Vb38oTmOgraDV/Xe4m32DxegRtv6ImKRkVWTFp6GxlztHzXbm22GxHJ n2d69l8TMXvdW2ikc/u0ZLGfzmX1Ky++Hjkjfx2J/sR3BS38V/5aTpMAmxg9/F6ddskb ObmTmSZRiwTbL20KKBwOttif8CsbJES+ccyoVa9mE8BZvZfTo8lj4ufeuKhOF8Uz0rPi zlmw== X-Gm-Message-State: APjAAAXU8WzPYRzxIWcFd8ff4gdsXgaVoNPn7uHRPokZ6U9ju7OTQoaH /866I+GR0XigQs/PX4UVrN3hKBSRm9r5z9ufMsaqBgR+IxQOYw== X-Google-Smtp-Source: APXvYqwHqK9I5fD//Pbu2Q5fXh4u6nwHtHEAU5MUlnN7Fl3TNzozslovRlhdOqeC0T4CO4xxIYAOiSobramoda/wMHY= X-Received: by 2002:a6b:7f03:: with SMTP id l3mr5488373ioq.271.1574305761776; Wed, 20 Nov 2019 19:09:21 -0800 (PST) MIME-Version: 1.0 References: <20191120045626.10886-1-pbhagavatula@marvell.com> In-Reply-To: <20191120045626.10886-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Thu, 21 Nov 2019 08:39:05 +0530 Message-ID: To: Pavan Nikhilesh Cc: Jerin Jacob , dpdk-dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/5] event/octeontx2: fix TIM HW race condition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 20, 2019 at 10:26 AM wrote: > > From: Pavan Nikhilesh > > Fix HW race condition observed when timeout resolution is low (<5us). > When HW traverses a given TIM bucket it will clear chunk_remainder, > but since SW always decreases the chunk_remainder at the start of the > arm routine it might cause a race where SW updates chunk_remainder > after HW has cleared it that lead to nasty side effects. > > Fixes: 95e4e4ec7469 ("event/octeontx2: add timer arm timeout burst") > > Signed-off-by: Pavan Nikhilesh Please fix the build issue with x86_32 with this series. https://travis-ci.com/ovsrobot/dpdk/jobs/258482444 drivers/event/octeontx2/otx2_tim_worker.h: In function =E2=80=98tim_add_ent= ry_sp=E2=80=99: drivers/common/octeontx2/otx2_common.h:31:26: error: left shift count >=3D width of type [-Werror=3Dshift-count-overflow] 31 | #define BIT(nr) (1UL << (nr)) | ^~ drivers/event/octeontx2/otx2_tim_worker.h:265:25: note: in expansion of macro =E2=80=98BIT=E2=80=99 265 | } while (hbt_state & BIT(33)); | ^~~ drivers/common/octeontx2/otx2_common.h:31:26: error: left shift count >=3D width of type [-Werror=3Dshift-count-overflow] 31 | #define BIT(nr) (1UL << (nr)) | ^~ drivers/event/octeontx2/otx2_tim_worker.h:268:22: note: in expansion of macro =E2=80=98BIT=E2=80=99 268 | if (!(hbt_state & BIT(34))) { | ^~~ drivers/event/octeontx2/otx2_tim_worker.h: In function =E2=80=98tim_add_ent= ry_mp=E2=80=99: drivers/common/octeontx2/otx2_common.h:31:26: error: left shift count >=3D width of type [-Werror=3Dshift-count-overflow] 31 | #define BIT(nr) (1UL << (nr))