From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13890A0C4E; Tue, 2 Nov 2021 12:11:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 929BA40689; Tue, 2 Nov 2021 12:11:50 +0100 (CET) Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by mails.dpdk.org (Postfix) with ESMTP id B50484003F for ; Tue, 2 Nov 2021 12:11:49 +0100 (CET) Received: by mail-io1-f51.google.com with SMTP id b203so9728986iof.1 for ; Tue, 02 Nov 2021 04:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XQctWgvrXn2QT0lkocKksQahxB/w3IVPWFObADJsb3A=; b=WeM1GSlw34awZVS3gO2Bv/Fb8OSQm6OJe78vp976k0/LeIUr4Bm/HgYOaujhL5Nyaw i9uTAAU3I43zcSrst0zQApZMFFJEKrl+iavQApjXRL4Og71nTrgsWIeDyMhmb1IHYtGE ALLkJen/rJ/LYjYRxpTaz+fXHbQ9lI/hOcPbuszjrSiPrb5Oo+NJQA4NGw/Meqciw1wa UN5ltMbq6aDGbXcVSt/KaPnjktIFPOVb0c4Yjk471hKykW7IgNBWmXSXoDvp41Vn+v8N iT9bo2/+N3++CPWTLmYZhiiooewe8BIwTixaGaGYvQfS/x0RX16gksPHzeu9KfvhZygA Ux6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XQctWgvrXn2QT0lkocKksQahxB/w3IVPWFObADJsb3A=; b=CigX2CmXLJynOVGf4LQXeddIIN8q4qlSWmvFOXZMO6KIu4aojJxN9bzzVIjjlUBWOU rMJJQ6HoRrgM/0tfksyjvgP5x0wquG/dCe1yIPhKaNTEjVm9G+U64ofwVCKLdTB85v4N 1zEYHMZegHy7ygS4/1QRSrPZvfTYT3sUXZESoFB2jPCFaMFo8Fi76tVGj8d7K1XxZ3KJ uMDrCm/s/paRlP8Ntg7AD+CaSd3/fvkwPFoVvjCFTkYnwN4yN990M0H5nlDfZhHe9e25 jEP5J9RIbgOXfa8NRaphQkZRtD4qog53d68twuBBsjTD8RZpUocKXGFGhGwqGchPLak8 LlJA== X-Gm-Message-State: AOAM533f/NPxAf3RzCO9KWttezsVLnKZDrumaY6XzVpihksgv/vcOCoi moH6I6nua8Ax+6U3CiAmFiMFqknnokYtoLsyvNw= X-Google-Smtp-Source: ABdhPJwv8XConkLtKSJKTfejgdGFKAcY3S7Lrq4FCCyKOq28YVpvrepMLYhR+hpJnWHk7VqTtIU7eE5McbB0cgw8IbU= X-Received: by 2002:a6b:14cb:: with SMTP id 194mr25051810iou.185.1635851509103; Tue, 02 Nov 2021 04:11:49 -0700 (PDT) MIME-Version: 1.0 References: <20211005074620.2224968-1-tduszynski@marvell.com> <20211022115625.1956708-1-tduszynski@marvell.com> <4832f0a8-67a4-ec48-30b6-01aa7d80ab1a@intel.com> <69b20079-c079-1d7b-a850-70de757c1343@intel.com> In-Reply-To: <69b20079-c079-1d7b-a850-70de757c1343@intel.com> From: Jerin Jacob Date: Tue, 2 Nov 2021 16:41:23 +0530 Message-ID: To: Ferruh Yigit Cc: Tomasz Duszynski , dpdk-dev , Jerin Jacob , Harman Kalra , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Jakub Palider Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] common/cnxk: support BPHY telemetry X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 2, 2021 at 3:58 PM Ferruh Yigit wrote: > > On 11/2/2021 4:32 AM, Jerin Jacob wrote: > > On Mon, Nov 1, 2021 at 8:32 PM Ferruh Yigit wrote: > >> > >> On 10/22/2021 12:56 PM, Tomasz Duszynski wrote: > >>> Add initial support for baseband telemetry. > >>> > >>> Signed-off-by: Tomasz Duszynski > >>> --- > >>> v2: > >>> - make bphy telemetry available only on platforms supporting baseband > >>> - use platform types where possible > >>> - remove unused header > >>> > >>> drivers/common/cnxk/cnxk_telemetry_bphy.c | 52 +++++++++++++++++++++++ > >> > >> Since the telemetry support is for 'raw/cnxk_bphy', why it is implemented > >> in common code, instead of driver? > > > > It can be raw/cnxk_bphy, thought of keeping it in common due to > > 1) To reuse it for another common code consumer > > Is it reusable, since the code is to get telemetry data from raw device? Yes. I meant, common code is reused on another library that has telemetry support too. > > > 2) roc_bphy_sso_pf_func_get() and roc_bphy_npa_pf_func_get() manged by > > common code. aka there is no reverse dependency on the raw driver framework > > in common code. > > If telemetry code moved to raw driver, dependency will be from driver to > common code, which is correct dependency order I think. > > It just looks wrong to have rawdev related telemetry function in the common > code, but I may be missing details, trying to understand. Currently, we are doing like this: - implementing HW specific telemetry endpoints in driver/common/cnxk - ethdev/mempool/eventdev/cryptodev driver-specific telemetry endpoint in driver/.../cnxk. The criteria for deciding what is the second category is, if it uses any ethdev/mempool/eventdev/cryptodev/rawdev symbols or if telemetry-related raw dev driver implementation details. i.e common code does not have any raw driver dependency. > > thanks, > ferruh