From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B3FE41BA1; Wed, 1 Feb 2023 18:33:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 060C242D35; Wed, 1 Feb 2023 18:33:51 +0100 (CET) Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) by mails.dpdk.org (Postfix) with ESMTP id 53F444113F for ; Wed, 1 Feb 2023 18:33:49 +0100 (CET) Received: by mail-vs1-f45.google.com with SMTP id e9so12636204vsj.3 for ; Wed, 01 Feb 2023 09:33:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zdpV5EQ0TjvGeajt6CL6PMW19DIPLalg6XmPtR+7hos=; b=PFYIpO6wZEW2pj8FYdhXJV83Qv4pCbYTLzcFD/iOoXWJgvEOomEepNFzuKd81sMN4e wynr95y3xvk6TtATvDEjIVohiVOkYFGDhcJ6qWkY4vVif0xk/tvratWIgfSoK8/qdWOG yvOR/y6OX2+Kb54lgEkfVqtI/g7In7XlipLbFWNUpbE7XrBwWaxw5isQsubfBgcyKee3 ICWVeVAknXmeCC43EiJVa+nc+SCCvx3fV+qwjcnAG7vwb88C21E23dThR1p6zYrLmM44 tsyq70OpJZGjySpxh6PV4HsMMRPqo1yE7y9k8UfcLyPi157c0qVzWo1VYhkTP2dtHFsS kDeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zdpV5EQ0TjvGeajt6CL6PMW19DIPLalg6XmPtR+7hos=; b=AeReTLoWE/MoQz1gB1BKQRKtBCrK9GE9jizGXbjJ9jZFLwuMt70VdFvb1rbAeGQkZu YMzwu84eNFaG771CkAUGGOXRmR41ca/b81D883n1whziOFdWSq/7lvb5byIdxcad3MS2 CuTsLcBwaSvDxb+6LNGZ1xPFqUf/DBxh9+Bhfwb5jZMIHe9lnXBCnUmGQlYbIcQikRtD 5+DFqu8e1cEPDsEypJjscGokMjokM8POmK59qVXtPPrva71iONBg06w9g1hToPq0Bmsq NtyKQZXKQhOLSHbBSYexo5KJAhJ+rxyP7d08UbQhwVDo+U/7sSKxVYrdvaphEWBl8LAZ 0wsA== X-Gm-Message-State: AO0yUKWzYo9J3F0BTygEk5Pegf09djsYjHeuC3YxAEWzTQepJaTWnWVm 8q7FYFcLFp8VPHo8V/nCn5wDPubaBW8SKqYx1ss= X-Google-Smtp-Source: AK7set+fgpriKotdqglIiFlkAcs4BCPkS7XBrnO8EfXsEF8tDEfoi3fZUq/MMdkyxpVpLnMrhRYyYJfvRHG4pkw/hAY= X-Received: by 2002:a67:f94c:0:b0:3fa:5334:55bd with SMTP id u12-20020a67f94c000000b003fa533455bdmr581235vsq.31.1675272828636; Wed, 01 Feb 2023 09:33:48 -0800 (PST) MIME-Version: 1.0 References: <20220803132839.2747858-2-jerinj@marvell.com> <2871791.H8VbNj7W2P@thomas> <2574934.9Mp67QZiUf@thomas> In-Reply-To: <2574934.9Mp67QZiUf@thomas> From: Jerin Jacob Date: Wed, 1 Feb 2023 23:03:21 +0530 Message-ID: Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v1 00/12] mldev: introduce machine learning device library To: Thomas Monjalon Cc: Shivah Shankar Shankar Narayan Rao , Jerin Jacob Kollanukkaran , "dev@dpdk.org" , "ferruh.yigit@amd.com" , "ajit.khaparde@broadcom.com" , "aboyer@pensando.io" , "andrew.rybchenko@oktetlabs.ru" , "beilei.xing@intel.com" , "bruce.richardson@intel.com" , "chas3@att.com" , "chenbo.xia@intel.com" , "ciara.loftus@intel.com" , Devendra Singh Rawat , "ed.czeck@atomicrules.com" , "evgenys@amazon.com" , "grive@u256.net" , "g.singh@nxp.com" , "zhouguoyang@huawei.com" , "haiyue.wang@intel.com" , Harman Kalra , "heinrich.kuhn@corigine.com" , "hemant.agrawal@nxp.com" , "hyonkim@cisco.com" , "igorch@amazon.com" , Igor Russkikh , "jgrajcia@cisco.com" , "jasvinder.singh@intel.com" , "jianwang@trustnetic.com" , "jiawenwu@trustnetic.com" , "jingjing.wu@intel.com" , "johndale@cisco.com" , "john.miller@atomicrules.com" , "linville@tuxdriver.com" , "keith.wiles@intel.com" , Kiran Kumar Kokkilagadda , "oulijun@huawei.com" , Liron Himi , "longli@microsoft.com" , "mw@semihalf.com" , "spinler@cesnet.cz" , "matan@nvidia.com" , "matt.peters@windriver.com" , "maxime.coquelin@redhat.com" , "mk@semihalf.com" , "humin29@huawei.com" , Pradeep Kumar Nalla , Nithin Kumar Dabilpuram , "qiming.yang@intel.com" , "qi.z.zhang@intel.com" , Radha Chintakuntla , "rahul.lakkireddy@chelsio.com" , Rasesh Mody , "rosen.xu@intel.com" , "sachin.saxena@oss.nxp.com" , Satha Koteswara Rao Kottidi , Shahed Shaikh , "shaibran@amazon.com" , "shepard.siegel@atomicrules.com" , "asomalap@amd.com" , "somnath.kotur@broadcom.com" , "sthemmin@microsoft.com" , "steven.webster@windriver.com" , Sunil Kumar Kori , "mtetsuyah@gmail.com" , Veerasenareddy Burru , "viacheslavo@nvidia.com" , "xiao.w.wang@intel.com" , "cloud.wangxiaoyun@huawei.com" , "yisen.zhuang@huawei.com" , "yongwang@vmware.com" , "xuanziyang2@huawei.com" , Prasun Kapoor , Nadav Haklai , Satananda Burla , Narayana Prasad Raju Athreya , Akhil Goyal , "dmitry.kozliuk@gmail.com" , "anatoly.burakov@intel.com" , "cristian.dumitrescu@intel.com" , "honnappa.nagarahalli@arm.com" , "mattias.ronnblom@ericsson.com" , "ruifeng.wang@arm.com" , "drc@linux.vnet.ibm.com" , "konstantin.ananyev@intel.com" , "olivier.matz@6wind.com" , "jay.jayatheerthan@intel.com" , Ashwin Sekhar T K , Pavan Nikhilesh Bhagavatula , "eagostini@nvidia.com" , Srikanth Yalavarthi , Derek Chickles , "david.marchand@redhat.com" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 1, 2023 at 10:27 PM Thomas Monjalon wrote: > > 28/01/2023 12:27, Jerin Jacob: > > I see main comments are on param update and get the capablities. > > To enable that, please propose the changes around rte_ml_model_params_update(), > > rte_ml_model_info. We should able to take that and send v2. > > Sorry I don't have the bandwidth to work on mldev now. Understandable. > I understand you took the easy path of opaque pointer, I would say not easy path, rather the use case I am not aware of and the model that we are supporting. > and you are OK to refine it if needed. Yes > Because there is not much reviews, I think we should merge it as-is > and keep it experimental the time needed to have more feedbacks > and a second vendor implementing it. Ack.I think, it is reasonable the first patch was pushed on Aug3. It was around 6 months for reviews. https://inbox.dpdk.org/dev/20220803132839.2747858-2-jerinj@marvell.com/ > >