From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 795C1A0562; Wed, 14 Apr 2021 21:52:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A00516195A; Wed, 14 Apr 2021 21:52:53 +0200 (CEST) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 1553B1618B1 for ; Wed, 14 Apr 2021 21:52:52 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id w8so8409016plg.9 for ; Wed, 14 Apr 2021 12:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JXQQu8gDOXbutUscXwOXLI9DkAp4hWbLebkswqyDUyM=; b=bBml7tYus06uETzwzkVc3XClEnM0KJF4kCl9/GWXHLcKyUlYyNHB2/qWn94A2vGQt/ lVQ1VdMfVaDv9dsVElo/fj8yh+rejFBtwh1NF89D68+bfYI+L0i6+N/Bc01IWEBKerbj 6GiBlqc6yyKqMpbN1Nk8iPII7r7eV2uRRZ/53leko20t4x8npiKiIkG5X2YBwABfJA5N NBA6kQlmW+nGEP36nsLW4EEE7x77RPtBytSlNfj9TaTOzYGpJhlUOrZvuM1grV8moN7f tAXiDFn14lo9R3KiebHRf/VHLIXttof2PoUOabh9zSxQoXzNk/oh8yqVPplt5v8kjEdB hO+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JXQQu8gDOXbutUscXwOXLI9DkAp4hWbLebkswqyDUyM=; b=ltzEV11GVy20+04TNW4JYlrkf6EZjX7SBmkHnM7YP7rms75vit1CweEfuatqoJ0ItB ZGTkCTfGVy/kJlIIQlF9gCGiVcTIoYpKYq/9UJsaHcjav6341g0cXAXIZmcPkkLIqzkT YcuEOpM4S7ZkwDsOrUxET316ThPWvJg8ENU5mKLHLRCgy6hGwIbGlGkHYVQQm+B9VRFY 0RWz/dbs+zgKcmpq7p30qHzlST60jhgbyFZMYCuKzKSOkogu4a0KmTr4It7B0VjF4kAp eMxfwDNEFUmd4RzdO+eJvrMU8RoSIfgbLdwrr5T2+wNAkxvEUFYjgLsLND3ar3Z6b4JI tfBg== X-Gm-Message-State: AOAM531jUhjOHTxb+a1QoraD90HMgJYuBQKYZSuNTmIrTuVPT0OisnW8 7lW3bYf3Pzx0fMDkrHrccAxY2dv1+YqbDfEx0b4= X-Google-Smtp-Source: ABdhPJweTNL6ivx0KZLjBwENXQxzYPSesTbzYkDMOcvXMpjlEDphzTnA8dD/A3w4aU1HHcM4jFtWlPvVEovqCSZ2dGY= X-Received: by 2002:a17:903:4106:b029:e9:244f:9aca with SMTP id r6-20020a1709034106b02900e9244f9acamr40373616pld.58.1618429971225; Wed, 14 Apr 2021 12:52:51 -0700 (PDT) MIME-Version: 1.0 References: <20210316221857.2254-2-timothy.mcdaniel@intel.com> <1618344896-2090-1-git-send-email-timothy.mcdaniel@intel.com> <1618344896-2090-27-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: From: Jerin Jacob Date: Thu, 15 Apr 2021 01:22:35 +0530 Message-ID: To: "McDaniel, Timothy" Cc: dpdk-dev , "Carrillo, Erik G" , Gage Eads , "Van Haaren, Harry" , Jerin Jacob , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 26/26] event/dlb: move rte config defines to runtime devargs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 15, 2021 at 1:09 AM McDaniel, Timothy wrote: > > > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Wednesday, April 14, 2021 2:11 PM > > To: McDaniel, Timothy > > Cc: dpdk-dev ; Carrillo, Erik G ; Gage > > Eads ; Van Haaren, Harry > > ; Jerin Jacob ; Thomas > > Monjalon > > Subject: Re: [dpdk-dev] [PATCH v3 26/26] event/dlb: move rte config defines to > > runtime devargs > > > > On Wed, Apr 14, 2021 at 1:49 AM Timothy McDaniel > > wrote: > > > > > > The new devarg names and their default values > > > are listed below. The defaults have not changed, and > > > none of these parameters are accessed in the fast path. > > > > > > poll_interval=1000 > > > sw_credit_quantai=32 > > > default_depth_thresh=256 > > > > > > Signed-off-by: Timothy McDaniel > > > > Please check CI failures. Please make this practice to see the fate of > > the patch by CI after the patch submission to avoid additional delay > > in merging the patch. > > > > http://patches.dpdk.org/project/dpdk/patch/1618344896-2090-27-git-send- > > email-timothy.mcdaniel@intel.com/ > > The failures seems to be > 1) with a reference to dlb2 documentation in the 20.11 release notes Please update the 20.11 release notes to fix the issue. > 2) an apply failure with the dqueue optimization patch. It requires the DLB 25 patches > to have been previously installed. I added a depends-on line to its cover sheet, but that > did not seem to help > 3) there are many false positives reported by check patches, most spelling related. I do > not see any real issues there > > As for the code cleanup, this was very minor, such as not including mbox.h, which we do not use. > Not sure it warrants its own patch, and I'm not sure I can even identify the other minor cleanups, if any. > > Thanks, > Tim >