From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3ED63A0A0A; Thu, 3 Jun 2021 10:47:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22FB740E78; Thu, 3 Jun 2021 10:47:22 +0200 (CEST) Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) by mails.dpdk.org (Postfix) with ESMTP id A64AD40DF6 for ; Thu, 3 Jun 2021 10:47:20 +0200 (CEST) Received: by mail-il1-f180.google.com with SMTP id o9so4809073ilh.6 for ; Thu, 03 Jun 2021 01:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=moXwXDJbaC2rOZJSuTTegxlzKzadmTupuZinibVL7pM=; b=KwNwg7FWQpcTOKb2DsflXQgiowjcS6I2D3yHPafwL2Vs+26EDJlYE1IC8Vl289KkKg 70t49TyqOrpsICgivcOapVpqNtijo0HH83eC3bGLIIToQ4pt/gSuTEoA0i+EUNGlmXC+ ab72No8foKhf+PDjVjMNLwga+aqv814AARmw5zVF5gE1vBmGPuK8KncIBmKh779y6sFG U6x5mjNPIkI7z8mB0jn9nteQOBH9IDftttFrVVy8H7486QGqcQxi1U6m4Z/uAru7b3Lc kzTdIMFPVFsHtrXaUNWRTObPzqFEVknXxpbA8BOzyBbWg/vE49oOVPxXqGx9s59nKvbk iB7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=moXwXDJbaC2rOZJSuTTegxlzKzadmTupuZinibVL7pM=; b=G0RKvpkcWlHEkbCQzrPqkhAwntXXPt4jWaMnsDWsbkb3fK/DxWbv/2se1pwbPgKLZP BJsKJkjmCcZVbg36S2mRBb1SuF/2PJPTlUujY2lnU+fAFR2vvUt9Fgzo8PX/BfSe+rYu jTQLsLNWyjKyHlnUYN+O4KrEwTNKA89AIIZ7+Nd/3zQ81A/6ziWBYFVyYqThmTiy9oem oYi/gXZ01u3kRZEHwqsB0KampxmRymuRcjeS7t11hfahSssLlHDWZVHnHlxn8eKKSLxi lyvx9ZXLSzyDorMHeWyeuAuJ5BPO1S//UuaiAn2LQRWV36VJaJ3t/+9w8nKaTNXy44xj 4ddQ== X-Gm-Message-State: AOAM532WjHQzjObrh5rfCQ2yTTCbExEJWtOdKmQ6rSBsJiYRoOOLri+U 8u83sFDDQ6bOdr/hvimTJYtYdOEi95ThuKkb08k= X-Google-Smtp-Source: ABdhPJzbw/EzuVtGCD+hBUmKTElZ9cdZvXvzRkG3TvprR3xR0XZ0EzKtCvnH3N/KeItGC0spf9f/dThXu3WARNDXFdA= X-Received: by 2002:a92:1310:: with SMTP id 16mr2524284ilt.60.1622710040102; Thu, 03 Jun 2021 01:47:20 -0700 (PDT) MIME-Version: 1.0 References: <20210602203531.2288645-1-thomas@monjalon.net> <2066767.2bDh9DmJd4@thomas> <3058202.9UA1LLGnyJ@thomas> In-Reply-To: <3058202.9UA1LLGnyJ@thomas> From: Jerin Jacob Date: Thu, 3 Jun 2021 14:17:04 +0530 Message-ID: To: Thomas Monjalon Cc: dpdk-dev , Elena Agostini Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] gpudev: introduce memory API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 3, 2021 at 2:13 PM Thomas Monjalon wrote: > > 03/06/2021 10:41, Jerin Jacob: > > On Thu, Jun 3, 2021 at 1:58 PM Thomas Monjalon wrote: > > > > > > 03/06/2021 09:47, Jerin Jacob: > > > > On Thu, Jun 3, 2021 at 2:05 AM Thomas Monjalon wrote: > > > > > --- a/doc/api/doxy-api-index.md > > > > > +++ b/doc/api/doxy-api-index.md > > > > > @@ -21,6 +21,7 @@ The public API headers are grouped by topics: > > > > > [compressdev] (@ref rte_compressdev.h), > > > > > [compress] (@ref rte_comp.h), > > > > > [regexdev] (@ref rte_regexdev.h), > > > > > + [gpudev] (@ref rte_gpudev.h), > > > > > > > > Since this device does not have a queue etc? Shouldn't make it a > > > > library like mempool with vendor-defined ops? > > > > Any specific reason for making it a device? The reason why I am asking > > > > this is, as other DPDK devices as symmetry in queue(s), configure, > > > > start, stop operation etc. > > > > > > > > > > > > > + > > > > > +struct rte_gpu_dev { > > > > > + /* Backing device. */ > > > > > + struct rte_device *device; > > > > > > > > See above? > > > > > > There is a PCI device probed. > > > I don't understand why it would not be represented as a device. > > > > All other DPDK device has symmetry in structures like queue and > > symmetry in operation like it has configure, start, stop etc. > > This one seems more like mempool to me all we want set of > > vendor-defined ops. So any justification on > > make it a device ? why not like mempool library? > > (driver/mempool/octeontx2 Mempool HW is also PCI device, but > > we don't take device path for mempool. So I would like to understand > > any technical reason for making it a device). > > I don't understand what you mean by "symmetry". The common attributes. or similarity > > >