From: Jerin Jacob <jerinjacobk@gmail.com>
To: Gavin Hu <Gavin.Hu@arm.com>
Cc: dpdk-dev <dev@dpdk.org>, nd <nd@arm.com>,
David Marchand <david.marchand@redhat.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
Phil Yang <Phil.Yang@arm.com>, Joyce Kong <Joyce.Kong@arm.com>,
Steve Capper <Steve.Capper@arm.com>
Subject: Re: [dpdk-dev] [PATCH v1 3/3] net/i40e: auto-vectorization to speed up Tx free
Date: Mon, 9 Mar 2020 13:05:49 +0530 [thread overview]
Message-ID: <CALBAE1Mtvs60KpxvLRBg82h4Uy5_-Rb6S=gdd95qGPS7prsK=w@mail.gmail.com> (raw)
In-Reply-To: <VI1PR08MB5376DC62F03B8903E9633EAA8FE00@VI1PR08MB5376.eurprd08.prod.outlook.com>
On Sat, Mar 7, 2020 at 8:34 PM Gavin Hu <Gavin.Hu@arm.com> wrote:
>
> Hi Jerin,
>
> > -----Original Message-----
> > From: Jerin Jacob <jerinjacobk@gmail.com>
> > Sent: Friday, March 6, 2020 3:45 PM
> > To: Gavin Hu <Gavin.Hu@arm.com>
> > Cc: dpdk-dev <dev@dpdk.org>; nd <nd@arm.com>; David Marchand
> > <david.marchand@redhat.com>; thomas@monjalon.net;
> > jerinj@marvell.com; Ye, Xiaolong <xiaolong.ye@intel.com>; Honnappa
> > Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> > <Ruifeng.Wang@arm.com>; Phil Yang <Phil.Yang@arm.com>; Joyce Kong
> > <Joyce.Kong@arm.com>; Steve Capper <Steve.Capper@arm.com>
> > Subject: Re: [dpdk-dev] [PATCH v1 3/3] net/i40e: auto-vectorization to
> > speed up Tx free
> >
> > On Fri, Mar 6, 2020 at 10:35 AM Gavin Hu <gavin.hu@arm.com> wrote:
> > >
> > > Tx mbuf free is a hotspot for i40e on aarch64, as there are no
> > > inter-loop dependencies, it is safe to enable auto-vectorization
> > > to speed up.
> > >
> > > This patch showed 2~3% performance lift on ThunderX2 and no
> > degradation
> > > on Arm N1SDP. The test case is single core RFC2544 zero-loss test.
> > >
> > > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > > Reviewed-by: Steve Capper <steve.capper@arm.com>
> > > ---
> > > drivers/net/i40e/i40e_rxtx_vec_common.h | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h
> > b/drivers/net/i40e/i40e_rxtx_vec_common.h
> > > index 0e6ffa007..fc0fa45d4 100644
> > > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h
> > > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
> > > @@ -98,6 +98,11 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)
> > > if (likely(m != NULL)) {
> > > free[0] = m;
> > > nb_free = 1;
> > > +#if defined(__clang__)
> > > +#pragma clang loop vectorize(assume_safety)
> > > +#elif defined(__GNUC__)
> > > +#pragma GCC ivdep
> > > +#endif
> >
> > IMO, It is better to abstract the compiler features (above compiler
> > feature and __restrict__) as macros in
> > rte_common.h or so. It will help to support other compilers(ICC or
> > Windows) and enable them to have "changes" in one place.
>
> How about defining RTE_LOOP_AUTO_VECTORIZATION in the rte_common.h?
Other compiler stuff in rte_common.h are starting with __rte in small
letter(__rte_packed, __rte_unused) etc.
I think, a better name would be __rte_loop_auto_vectorize or so.
No strong opinion for the name though.
# Probably it is worth checking and add performance result of x86
testing in git commit as well as it
is common code.
> #if defined(__clang__)
> define RTE_LOOP_AUTO_VECTORIZATION \
> #pragma clang loop vectorize(assume_safety)
> #elif defined(__GNUC__)
> define RTE_LOOP_AUTO_VECTORIZATION \
> #pragma GCC ivdep
> #else
> define RTE_LOOP_AUTO_VECTORIZATION
> #endif
> If you agree, I will submit a v2. Thanks for your comments!
> /Gavin
> >
> >
> >
> > > for (i = 1; i < n; i++) {
> > > m = rte_pktmbuf_prefree_seg(txep[i].mbuf);
> > > if (likely(m != NULL)) {
> > > --
> > > 2.17.1
> > >
next prev parent reply other threads:[~2020-03-09 7:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 5:04 [dpdk-dev] [PATCH v1 0/3] i40e vPMD optimization on aarch64 Gavin Hu
2020-03-06 5:04 ` [dpdk-dev] [PATCH v1 1/3] net/i40e: relax barrier in the Tx fastpath of vPMD Gavin Hu
2020-03-06 9:11 ` Jerin Jacob
2020-03-06 5:04 ` [dpdk-dev] [PATCH v1 2/3] net/i40e: restrict pointer aliasing for neon vec Gavin Hu
2020-03-06 5:04 ` [dpdk-dev] [PATCH v1 3/3] net/i40e: auto-vectorization to speed up Tx free Gavin Hu
2020-03-06 7:44 ` Jerin Jacob
2020-03-06 9:06 ` Thomas Monjalon
2020-03-07 15:03 ` Gavin Hu
2020-03-09 7:35 ` Jerin Jacob [this message]
2020-03-09 9:23 ` Gavin Hu
2020-04-13 15:56 ` [dpdk-dev] [PATCH v2 0/2] i40e NEON vPMD optimization on aarch64 Gavin Hu
2020-04-13 15:56 ` [dpdk-dev] [PATCH v2 1/2] net/i40e: relax barrier in Tx fastpath for NEON vPMD Gavin Hu
2020-04-13 15:56 ` [dpdk-dev] [PATCH v2 2/2] net/i40e: restrict pointer aliasing " Gavin Hu
2020-04-20 14:51 ` Ferruh Yigit
2020-04-21 9:51 ` Gavin Hu
2020-04-13 16:40 ` [dpdk-dev] [PATCH v3 0/2] i40e NEON vPMD optimization on aarch64 Gavin Hu
2020-04-15 6:50 ` Ye Xiaolong
2020-04-13 16:40 ` [dpdk-dev] [PATCH v3 1/2] net/i40e: relax barrier in Tx fastpath for NEON vPMD Gavin Hu
2020-04-13 16:40 ` [dpdk-dev] [PATCH v3 2/2] net/i40e: restrict pointer aliasing " Gavin Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1Mtvs60KpxvLRBg82h4Uy5_-Rb6S=gdd95qGPS7prsK=w@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Joyce.Kong@arm.com \
--cc=Phil.Yang@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=Steve.Capper@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).