* [dpdk-dev] [PATCH] test/event_crypto: no service core for HW options
@ 2019-09-06 10:44 Hemant Agrawal
2019-09-17 3:27 ` Gujjar, Abhinandan S
0 siblings, 1 reply; 3+ messages in thread
From: Hemant Agrawal @ 2019-09-06 10:44 UTC (permalink / raw)
To: dev; +Cc: jerinj, abhinandan.gujjar, Hemant Agrawal
If HW support is available, service core shall not come
into play by default. This shall be for both FWD/NEW modes.
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
app/test/test_event_crypto_adapter.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c
index e7bf80978..ed8a58d32 100644
--- a/app/test/test_event_crypto_adapter.c
+++ b/app/test/test_event_crypto_adapter.c
@@ -293,7 +293,8 @@ test_sessionless_with_op_forward_mode(void)
ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap);
TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
- if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD))
+ if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
+ !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
map_adapter_service_core();
TEST_ASSERT_SUCCESS(rte_event_crypto_adapter_start(TEST_ADAPTER_ID),
@@ -313,7 +314,8 @@ test_session_with_op_forward_mode(void)
ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap);
TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
- if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD))
+ if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
+ !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
map_adapter_service_core();
TEST_ASSERT_SUCCESS(rte_event_crypto_adapter_start(TEST_ADAPTER_ID
@@ -441,7 +443,7 @@ test_sessionless_with_op_new_mode(void)
ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap);
TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
- if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) ||
+ if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
map_adapter_service_core();
@@ -463,7 +465,7 @@ test_session_with_op_new_mode(void)
ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap);
TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
- if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) ||
+ if (!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
!(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
map_adapter_service_core();
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] test/event_crypto: no service core for HW options
2019-09-06 10:44 [dpdk-dev] [PATCH] test/event_crypto: no service core for HW options Hemant Agrawal
@ 2019-09-17 3:27 ` Gujjar, Abhinandan S
2019-09-23 7:17 ` Jerin Jacob
0 siblings, 1 reply; 3+ messages in thread
From: Gujjar, Abhinandan S @ 2019-09-17 3:27 UTC (permalink / raw)
To: Hemant Agrawal, dev; +Cc: jerinj
Acked-by: abhinandan.gujjar@intel.com
> -----Original Message-----
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> Sent: Friday, September 6, 2019 4:15 PM
> To: dev@dpdk.org
> Cc: jerinj@marvell.com; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>
> Subject: [PATCH] test/event_crypto: no service core for HW options
>
> If HW support is available, service core shall not come into play by default. This
> shall be for both FWD/NEW modes.
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> app/test/test_event_crypto_adapter.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index e7bf80978..ed8a58d32 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -293,7 +293,8 @@ test_sessionless_with_op_forward_mode(void)
> ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev,
> &cap);
> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
>
> - if (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD))
> + if (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
> + !(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
> map_adapter_service_core();
>
>
> TEST_ASSERT_SUCCESS(rte_event_crypto_adapter_start(TEST_ADAPTE
> R_ID),
> @@ -313,7 +314,8 @@ test_session_with_op_forward_mode(void)
> ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev,
> &cap);
> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
>
> - if (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD))
> + if (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
> + !(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
> map_adapter_service_core();
>
>
> TEST_ASSERT_SUCCESS(rte_event_crypto_adapter_start(TEST_ADAPTE
> R_ID
> @@ -441,7 +443,7 @@ test_sessionless_with_op_new_mode(void)
> ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev,
> &cap);
> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
>
> - if (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) ||
> + if (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
> !(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
> map_adapter_service_core();
>
> @@ -463,7 +465,7 @@ test_session_with_op_new_mode(void)
> ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev,
> &cap);
> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
>
> - if (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) ||
> + if (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) &&
> !(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
> map_adapter_service_core();
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] test/event_crypto: no service core for HW options
2019-09-17 3:27 ` Gujjar, Abhinandan S
@ 2019-09-23 7:17 ` Jerin Jacob
0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2019-09-23 7:17 UTC (permalink / raw)
To: Gujjar, Abhinandan S; +Cc: Hemant Agrawal, dev, jerinj
On Tue, Sep 17, 2019 at 9:01 AM Gujjar, Abhinandan S
<abhinandan.gujjar@intel.com> wrote:
>
> Acked-by: abhinandan.gujjar@intel.com
Changed to Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
and Applied to dpdk-next-eventdev/master. Thanks.
>
>
> > -----Original Message-----
> > From: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Sent: Friday, September 6, 2019 4:15 PM
> > To: dev@dpdk.org
> > Cc: jerinj@marvell.com; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> > Hemant Agrawal <hemant.agrawal@nxp.com>
> > Subject: [PATCH] test/event_crypto: no service core for HW options
> >
> > If HW support is available, service core shall not come into play by default. This
> > shall be for both FWD/NEW modes.
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> > app/test/test_event_crypto_adapter.c | 10 ++++++----
> > 1 file changed, 6 insertions(+), 4 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-23 7:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-06 10:44 [dpdk-dev] [PATCH] test/event_crypto: no service core for HW options Hemant Agrawal
2019-09-17 3:27 ` Gujjar, Abhinandan S
2019-09-23 7:17 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).