From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CD53A00C2; Mon, 2 May 2022 20:33:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D2BD40F35; Mon, 2 May 2022 20:33:58 +0200 (CEST) Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by mails.dpdk.org (Postfix) with ESMTP id 578C140E28 for ; Mon, 2 May 2022 20:33:57 +0200 (CEST) Received: by mail-il1-f174.google.com with SMTP id l15so3063407ilh.3 for ; Mon, 02 May 2022 11:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V7B/D2hD81t9zmRMX5JQBJaHI5f1smkuQ/n1k2c6Qs4=; b=cX90UtyRVMad2kDk+tcGdeGuwF57EBMkIyVOFGOFRtTj9F3hShrLBSIxpwAuoikbyu 16jTKRTE2Vj5qR5RqVzWfUD7xadDwH/5ZpSOeK/AQc8AuosTpDT+y3+GWHYM0NF/XyDu fvrajxlsxDiAWVIh1heSB3/zvJzhF2ffNuOE7Jpp35mCooV3lnYx8zsnK9/ZNTSg8Ain 47UpCS7+/Jwrc60t7bPDmMjcfgoqq6UxbtQa+55GqQA82u3hUgQOCLgsf1SYPPjAKSEL bWuORKDRgsb3gmCxJtE7kqdEcHahjtLBGnpJLHqK9tC+Yi3jWpnzlzyVp1rMYC4+tdCa 6QOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V7B/D2hD81t9zmRMX5JQBJaHI5f1smkuQ/n1k2c6Qs4=; b=fVG3pEhNKB9HuClheTRgsvNVdmZFr+XcSb8Nh4q/CodhyRdwNB32dq+a1nffGbv0/O jtIy24amFd4ui2QIvERXC9FRLK/rMBcW578Q+04nzg8RsQDIzGnlABWSkXtxwWVMzVJt H7q8pyQTChNcqFJegTcxiFrxJmO40D9GuR9EJREOPr0Gd7kVa7/3hL+6r16JuxwEGa+X G+Ia1IZ6fcQcS0Fv+YNoT36ash3XFRHEBRMTlyvg6igaEo5fyuFm72JZlT7beBlySH9y ovbunCu5c5IBZIPt0hFN69IVfS27D6LPQCfKcoVlFDEVuZxzUmRsstajNJjAAaQOq3Vr CEfA== X-Gm-Message-State: AOAM5302ZIxAlQnn1hb9ACDMeVE54npAWd4NHgXqAM3Q3keIIvnJqrwq Zj1Ywfkq4y7AjXEPAy5lBIzyrpBMubXxUHkAIQU= X-Google-Smtp-Source: ABdhPJyQ84FCeaQo9f4ynNVyAdEFHhNZPDRPyz14Ge+jnmdrO6PBQrR7ec8a8vkZTWHZNTI6brpaZ2l7WXQPL6F0HFA= X-Received: by 2002:a05:6e02:1d8a:b0:2cd:fa75:6395 with SMTP id h10-20020a056e021d8a00b002cdfa756395mr5007312ila.294.1651516436539; Mon, 02 May 2022 11:33:56 -0700 (PDT) MIME-Version: 1.0 References: <20220330084356.3614662-1-rbhansali@marvell.com> <20220330084356.3614662-2-rbhansali@marvell.com> In-Reply-To: <20220330084356.3614662-2-rbhansali@marvell.com> From: Jerin Jacob Date: Tue, 3 May 2022 00:03:30 +0530 Message-ID: Subject: Re: [PATCH 2/2] net/cnxk: use ROC errata API To: Rahul Bhansali , Ferruh Yigit , Andrew Rybchenko Cc: dpdk-dev , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Jerin Jacob Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 30, 2022 at 2:14 PM Rahul Bhansali wrote: > > Used errata APIs roc_errata_nix_has_no_drop_re() and > roc_errata_nix_has_cq_min_size_4k() instead of direct > ROC model check. > > Signed-off-by: Rahul Bhansali Series Acked-by: Jerin Jacob Series applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/net/cnxk/cn10k_ethdev.c | 4 +--- > drivers/net/cnxk/cn9k_ethdev.c | 2 +- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/cnxk/cn10k_ethdev.c b/drivers/net/cnxk/cn10k_ethdev.c > index 15dbea2180..6f37bf5a4b 100644 > --- a/drivers/net/cnxk/cn10k_ethdev.c > +++ b/drivers/net/cnxk/cn10k_ethdev.c > @@ -778,9 +778,7 @@ cn10k_nix_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) > /* DROP_RE is not supported with inline IPSec for CN10K A0 and > * when vector mode is enabled. > */ > - if ((roc_model_is_cn10ka_a0() || roc_model_is_cnf10ka_a0() || > - roc_model_is_cnf10kb_a0()) && > - !roc_env_is_asim()) { > + if (roc_errata_nix_has_no_drop_re() && !roc_env_is_asim()) { > dev->ipsecd_drop_re_dis = 1; > dev->vec_drop_re_dis = 1; > } > diff --git a/drivers/net/cnxk/cn9k_ethdev.c b/drivers/net/cnxk/cn9k_ethdev.c > index eda33dc8c5..be1276180c 100644 > --- a/drivers/net/cnxk/cn9k_ethdev.c > +++ b/drivers/net/cnxk/cn9k_ethdev.c > @@ -737,7 +737,7 @@ cn9k_nix_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) > roc_nix_ptp_info_cb_register(&dev->nix, cn9k_nix_ptp_info_update_cb); > > /* Update HW erratas */ > - if (roc_model_is_cn96_a0() || roc_model_is_cn95_a0()) > + if (roc_errata_nix_has_cq_min_size_4k()) > dev->cq_min_4k = 1; > return 0; > } > -- > 2.25.1 >