From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8402A0509; Sun, 1 May 2022 14:53:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DD4E4069D; Sun, 1 May 2022 14:53:04 +0200 (CEST) Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) by mails.dpdk.org (Postfix) with ESMTP id 8F1EF4003F for ; Sun, 1 May 2022 14:53:03 +0200 (CEST) Received: by mail-il1-f180.google.com with SMTP id o5so6575446ils.11 for ; Sun, 01 May 2022 05:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sw9l30MdenMp2wMtp0qtCDABz9S0EDg71SvMYuGoOoU=; b=KNDwrXsZeCInzA92OdGOkKK2VHmDV3RRMqXJtUyaTIEK3nTee4BLdfDxB+DmPPnEu2 DeGmhWkJdnSpwKqC7xMEnwJ4ycNVt3FlMsTpPZlgcjvsl3iZ1/zKwSw9HqojHKpJaVzs Dheb0oIk5dKLD45/W92+O8KmsJF9qafWPxkeGFRSlxQl6WKE91qNWK5RcMqG9Uo8lWCM nDd3PxcaxCpWifo8DNZjyTGhxN8WSH3yxDrgrpBJRoudPxA855A9tZ7JUU2cFCnugptz 7p5uyNnmdvWJYuM775GaZRSv+LO8ZE1oQZCb6C8h+QYC2vqTHnNMOc2F/1KxhKC0CLSS bcoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sw9l30MdenMp2wMtp0qtCDABz9S0EDg71SvMYuGoOoU=; b=znV0/g9iDlCHwcIgguIywt1UtwBs4M+1LKSzDP7mo4OUaqwRphsfghL8WZMOi/TCTj +6joNj5a9a+oz/7Qh675Lkow/Wz0521fA0ufyfM2zURmgPzB7yCgc5YNWQpeahpn7VNT EdMTUfw0CoHsT+QxMB2/Zb5TM6LRqlPd3BZQTzdcBSEJfrYtSDrFZGqGozVUC2OyVpoI sp/JWh83YjRG41UkkCbLCzkbSVpWk3fN651gSukdeHPuNfG/mkDGReqO90zE33P/aZk8 qtwHcZd44YK88sWvPdnsVGGPRr+RiGMlo1RmNQkCw9duN49sGjyRa/RY1DaCNLd8IIQy vciA== X-Gm-Message-State: AOAM533opWjdI6FYV8mSB5+3LoUqc0980Z/XVNcwvWdJYOgMXCi0hIEn d+I+MKOpjpWIIFz5D9PkFSmCyr2/YSNpd7ek+qQ= X-Google-Smtp-Source: ABdhPJz4ulwCsXFhzI1Jn4g5b/z1Ks4tG+NEF1OdgSvhLuA6OghBMloYqJnrUTLIRBGaI/XXweTZ6Rm/oFveuOFS2yQ= X-Received: by 2002:a05:6e02:1d8a:b0:2cd:fa75:6395 with SMTP id h10-20020a056e021d8a00b002cdfa756395mr3027064ila.294.1651409582782; Sun, 01 May 2022 05:53:02 -0700 (PDT) MIME-Version: 1.0 References: <20220301085824.1041009-1-skori@marvell.com> <20220421180241.514767-1-jerinj@marvell.com> <87ilqwm9ju.fsf@mdr78.vserver.site> In-Reply-To: <87ilqwm9ju.fsf@mdr78.vserver.site> From: Jerin Jacob Date: Sun, 1 May 2022 18:22:36 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH v4] ethdev: mtr: support protocol based input color selection To: Ray Kinsella Cc: Jerin Jacob , dpdk-dev , Cristian Dumitrescu , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Ajit Khaparde , Andrew Boyer , Beilei Xing , "Richardson, Bruce" , Chas Williams , "Xia, Chenbo" , Ciara Loftus , Devendra Singh Rawat , Ed Czeck , Evgeny Schemeilin , Gaetan Rivet , Gagandeep Singh , Guoyang Zhou , Haiyue Wang , Harman Kalra , heinrich.kuhn@corigine.com, Hemant Agrawal , Hyong Youb Kim , Igor Chauskin , Igor Russkikh , Jakub Grajciar , Jasvinder Singh , Jian Wang , Jiawen Wu , Jingjing Wu , John Daley , John Miller , "John W. Linville" , "Wiles, Keith" , Kiran Kumar K , Lijun Ou , Liron Himi , Long Li , Marcin Wojtas , Martin Spinler , Matan Azrad , Matt Peters , Maxime Coquelin , Michal Krawczyk , "Min Hu (Connor" , Pradeep Kumar Nalla , Nithin Dabilpuram , Qiming Yang , Qi Zhang , Radha Mohan Chintakuntla , Rahul Lakkireddy , Rasesh Mody , Rosen Xu , Sachin Saxena , Satha Koteswara Rao Kottidi , Shahed Shaikh , Shai Brandes , Shepard Siegel , Somalapuram Amaranath , Somnath Kotur , Stephen Hemminger , Steven Webster , Sunil Kumar Kori , Tetsuya Mukawa , Veerasenareddy Burru , Viacheslav Ovsiienko , Xiao Wang , Xiaoyun Wang , Yisen Zhuang , Yong Wang , Ziyang Xuan Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Apr 26, 2022 at 3:49 PM Ray Kinsella wrote: > > > jerinj@marvell.com writes: > > > From: Jerin Jacob > > > > Currently, meter object supports only DSCP based on input color table, > > The patch enhance that to support VLAN based input color table, > > color table based on inner field for the tunnel use case, and > > support for fallback color per meter if packet based on a different field. > > > > All of the above features are exposed through capability and added > > additional capability to specify the implementation supports > > more than one input color table per ethdev port. > > > > Suggested-by: Cristian Dumitrescu > > Signed-off-by: Jerin Jacob > > --- > > v4..v3: > > > > - Aligned with community meeting call which is documented in > > https://patches.dpdk.org/project/dpdk/patch/20220301085824.1041009-1-skori@marvell.com/ > > as last message. With following exception, > > - Used RTE_MTR_COLOR_IN_*_DSCP instead of RTE_MTR_COLOR_IN_*_IP as > > there is already dscp_table and rte_mtr_meter_dscp_table_update() API. > > Changing above symbols break existing application for no good. > > - Updated 22.07 release notes > > - Remove testpmd changes from series to finalize the API spec first and > > then we can send testpmd changes. > > > > v3..v2: > > > > - Fix input color flags as a bitmask > > - Add definitions for newly added API > > > > v2..v1: > > - Fix seperate typo > > > > v1..RFC: > > > > Address the review comments by Cristian at > > https://patches.dpdk.org/project/dpdk/patch/20210820082401.3778736-1-jerinj@marvell.com/ > > > > diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map > > index 20391ab29e..cccbf6dee5 100644 > > --- a/lib/ethdev/version.map > > +++ b/lib/ethdev/version.map > > @@ -279,6 +279,10 @@ EXPERIMENTAL { > > rte_flow_async_action_handle_create; > > rte_flow_async_action_handle_destroy; > > rte_flow_async_action_handle_update; > > + > > + # added in 22.07 > > Symbols are not in alphabetical order. Thanks. Will fix it in v5 > > > + rte_mtr_meter_vlan_table_update; > > + rte_mtr_color_in_protocol_priority_set; > > }; > > > > INTERNAL { > > > -- > Regards, Ray K