From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: "Jerin Jacob" <jerinj@marvell.com>,
"Shijith Thotton" <sthotton@marvell.com>,
"Timothy McDaniel" <timothy.mcdaniel@intel.com>,
"Hemant Agrawal" <hemant.agrawal@nxp.com>,
"Nipun Gupta" <nipun.gupta@nxp.com>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
"Liang Ma" <liangma@liangbit.com>,
"Peter Mccarthy" <peter.mccarthy@intel.com>,
"Harry van Haaren" <harry.van.haaren@intel.com>,
"Abhinandan Gujjar" <abhinandan.gujjar@intel.com>,
"Ray Kinsella" <mdr@ashroe.eu>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 01/14] eventdev: make driver interface as internal
Date: Wed, 20 Oct 2021 09:31:48 +0530 [thread overview]
Message-ID: <CALBAE1Mwm9zNNqPJ4mABRg0o83KJZWchgTXqZF2ViVbV6FiAXQ@mail.gmail.com> (raw)
In-Reply-To: <20211018233610.5694-1-pbhagavatula@marvell.com>
On Tue, Oct 19, 2021 at 5:06 AM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Mark all the driver specific functions as internal, remove
> `rte` prefix from `struct rte_eventdev_ops`.
> Remove experimental tag from internal functions.
> Remove `eventdev_pmd.h` from non-internal header files.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Series applied to dpdk-next-net-eventdev/for-main. Thanks
> ---
> v5 Changes:
> - Move doc updates to respective patches. (Jerin)
>
> v4 Changes:
> - Update release notes. (Jerin)
> - Rearrange fp_ops fields. (Jerin)
> - Free timer array memory when freeing the last adapter. (Erik)
> - Rebase onto next-event.
> - Fix spell checks.
> - Rearrange version.map (David)
>
> v3 Changes:
> - Reset fp_ops when device is torndown.
> - Add `event_dev_probing_finish()` this function is used for
> post-initialization processing. In current usecase we use it to
> initialize fastpath ops.
>
> v2 Changes:
> - Rework inline flat array by adding port data into it.
> - Rearrange rte_event_timer elements.
>
>
> drivers/event/cnxk/cn10k_eventdev.c | 6 ++---
> drivers/event/cnxk/cn9k_eventdev.c | 10 ++++-----
> drivers/event/dlb2/dlb2.c | 2 +-
> drivers/event/dpaa/dpaa_eventdev.c | 2 +-
> drivers/event/dpaa2/dpaa2_eventdev.c | 2 +-
> drivers/event/dsw/dsw_evdev.c | 2 +-
> drivers/event/octeontx/ssovf_evdev.c | 2 +-
> drivers/event/octeontx/ssovf_worker.c | 4 ++--
> drivers/event/octeontx2/otx2_evdev.c | 26 +++++++++++-----------
> drivers/event/opdl/opdl_evdev.c | 2 +-
> drivers/event/skeleton/skeleton_eventdev.c | 2 +-
> drivers/event/sw/sw_evdev.c | 2 +-
> lib/eventdev/eventdev_pmd.h | 6 ++++-
> lib/eventdev/eventdev_pmd_pci.h | 4 +++-
> lib/eventdev/eventdev_pmd_vdev.h | 2 ++
> lib/eventdev/meson.build | 6 +++++
> lib/eventdev/rte_event_crypto_adapter.h | 1 -
> lib/eventdev/rte_eventdev.h | 25 ++++++++++++---------
> lib/eventdev/version.map | 17 +++++++-------
> 19 files changed, 70 insertions(+), 53 deletions(-)
>
> diff --git a/drivers/event/cnxk/cn10k_eventdev.c b/drivers/event/cnxk/cn10k_eventdev.c
> index bfd470cffd..612c299b59 100644
> --- a/drivers/event/cnxk/cn10k_eventdev.c
> +++ b/drivers/event/cnxk/cn10k_eventdev.c
> @@ -380,7 +380,7 @@ cn10k_sso_fp_fns_set(struct rte_eventdev *event_dev)
> };
>
> /* Tx modes */
> - const event_tx_adapter_enqueue
> + const event_tx_adapter_enqueue_t
> sso_hws_tx_adptr_enq[2][2][2][2][2][2][2] = {
> #define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) \
> [f6][f5][f4][f3][f2][f1][f0] = cn10k_sso_hws_tx_adptr_enq_##name,
> @@ -388,7 +388,7 @@ cn10k_sso_fp_fns_set(struct rte_eventdev *event_dev)
> #undef T
> };
>
> - const event_tx_adapter_enqueue
> + const event_tx_adapter_enqueue_t
> sso_hws_tx_adptr_enq_seg[2][2][2][2][2][2][2] = {
> #define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) \
> [f6][f5][f4][f3][f2][f1][f0] = cn10k_sso_hws_tx_adptr_enq_seg_##name,
> @@ -788,7 +788,7 @@ cn10k_crypto_adapter_qp_del(const struct rte_eventdev *event_dev,
> return cnxk_crypto_adapter_qp_del(cdev, queue_pair_id);
> }
>
> -static struct rte_eventdev_ops cn10k_sso_dev_ops = {
> +static struct eventdev_ops cn10k_sso_dev_ops = {
> .dev_infos_get = cn10k_sso_info_get,
> .dev_configure = cn10k_sso_dev_configure,
> .queue_def_conf = cnxk_sso_queue_def_conf,
> diff --git a/drivers/event/cnxk/cn9k_eventdev.c b/drivers/event/cnxk/cn9k_eventdev.c
> index 806dcb0a45..d757da7c37 100644
> --- a/drivers/event/cnxk/cn9k_eventdev.c
> +++ b/drivers/event/cnxk/cn9k_eventdev.c
> @@ -514,7 +514,7 @@ cn9k_sso_fp_fns_set(struct rte_eventdev *event_dev)
> };
>
> /* Tx modes */
> - const event_tx_adapter_enqueue
> + const event_tx_adapter_enqueue_t
> sso_hws_tx_adptr_enq[2][2][2][2][2][2][2] = {
> #define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) \
> [f6][f5][f4][f3][f2][f1][f0] = cn9k_sso_hws_tx_adptr_enq_##name,
> @@ -522,7 +522,7 @@ cn9k_sso_fp_fns_set(struct rte_eventdev *event_dev)
> #undef T
> };
>
> - const event_tx_adapter_enqueue
> + const event_tx_adapter_enqueue_t
> sso_hws_tx_adptr_enq_seg[2][2][2][2][2][2][2] = {
> #define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) \
> [f6][f5][f4][f3][f2][f1][f0] = cn9k_sso_hws_tx_adptr_enq_seg_##name,
> @@ -530,7 +530,7 @@ cn9k_sso_fp_fns_set(struct rte_eventdev *event_dev)
> #undef T
> };
>
> - const event_tx_adapter_enqueue
> + const event_tx_adapter_enqueue_t
> sso_hws_dual_tx_adptr_enq[2][2][2][2][2][2][2] = {
> #define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) \
> [f6][f5][f4][f3][f2][f1][f0] = cn9k_sso_hws_dual_tx_adptr_enq_##name,
> @@ -538,7 +538,7 @@ cn9k_sso_fp_fns_set(struct rte_eventdev *event_dev)
> #undef T
> };
>
> - const event_tx_adapter_enqueue
> + const event_tx_adapter_enqueue_t
> sso_hws_dual_tx_adptr_enq_seg[2][2][2][2][2][2][2] = {
> #define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) \
> [f6][f5][f4][f3][f2][f1][f0] = \
> @@ -1060,7 +1060,7 @@ cn9k_crypto_adapter_qp_del(const struct rte_eventdev *event_dev,
> return cnxk_crypto_adapter_qp_del(cdev, queue_pair_id);
> }
>
> -static struct rte_eventdev_ops cn9k_sso_dev_ops = {
> +static struct eventdev_ops cn9k_sso_dev_ops = {
> .dev_infos_get = cn9k_sso_info_get,
> .dev_configure = cn9k_sso_dev_configure,
> .queue_def_conf = cnxk_sso_queue_def_conf,
> diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
> index 252bbd8d5e..c8742ddb2c 100644
> --- a/drivers/event/dlb2/dlb2.c
> +++ b/drivers/event/dlb2/dlb2.c
> @@ -4384,7 +4384,7 @@ dlb2_entry_points_init(struct rte_eventdev *dev)
> struct dlb2_eventdev *dlb2;
>
> /* Expose PMD's eventdev interface */
> - static struct rte_eventdev_ops dlb2_eventdev_entry_ops = {
> + static struct eventdev_ops dlb2_eventdev_entry_ops = {
> .dev_infos_get = dlb2_eventdev_info_get,
> .dev_configure = dlb2_eventdev_configure,
> .dev_start = dlb2_eventdev_start,
> diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c
> index ec74160325..9f14390d28 100644
> --- a/drivers/event/dpaa/dpaa_eventdev.c
> +++ b/drivers/event/dpaa/dpaa_eventdev.c
> @@ -925,7 +925,7 @@ dpaa_eventdev_txa_enqueue(void *port,
> return nb_events;
> }
>
> -static struct rte_eventdev_ops dpaa_eventdev_ops = {
> +static struct eventdev_ops dpaa_eventdev_ops = {
> .dev_infos_get = dpaa_event_dev_info_get,
> .dev_configure = dpaa_event_dev_configure,
> .dev_start = dpaa_event_dev_start,
> diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c
> index 5ccf22f77f..d577f64824 100644
> --- a/drivers/event/dpaa2/dpaa2_eventdev.c
> +++ b/drivers/event/dpaa2/dpaa2_eventdev.c
> @@ -1015,7 +1015,7 @@ dpaa2_eventdev_txa_enqueue(void *port,
> return nb_events;
> }
>
> -static struct rte_eventdev_ops dpaa2_eventdev_ops = {
> +static struct eventdev_ops dpaa2_eventdev_ops = {
> .dev_infos_get = dpaa2_eventdev_info_get,
> .dev_configure = dpaa2_eventdev_configure,
> .dev_start = dpaa2_eventdev_start,
> diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c
> index 2301a4b7a0..01f060fff3 100644
> --- a/drivers/event/dsw/dsw_evdev.c
> +++ b/drivers/event/dsw/dsw_evdev.c
> @@ -398,7 +398,7 @@ dsw_crypto_adapter_caps_get(const struct rte_eventdev *dev __rte_unused,
> return 0;
> }
>
> -static struct rte_eventdev_ops dsw_evdev_ops = {
> +static struct eventdev_ops dsw_evdev_ops = {
> .port_setup = dsw_port_setup,
> .port_def_conf = dsw_port_def_conf,
> .port_release = dsw_port_release,
> diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c
> index b93f6ec8c6..4a8c6a13a5 100644
> --- a/drivers/event/octeontx/ssovf_evdev.c
> +++ b/drivers/event/octeontx/ssovf_evdev.c
> @@ -790,7 +790,7 @@ ssovf_crypto_adapter_qp_del(const struct rte_eventdev *dev,
> }
>
> /* Initialize and register event driver with DPDK Application */
> -static struct rte_eventdev_ops ssovf_ops = {
> +static struct eventdev_ops ssovf_ops = {
> .dev_infos_get = ssovf_info_get,
> .dev_configure = ssovf_configure,
> .queue_def_conf = ssovf_queue_def_conf,
> diff --git a/drivers/event/octeontx/ssovf_worker.c b/drivers/event/octeontx/ssovf_worker.c
> index 8b056ddc5a..2df940f0f1 100644
> --- a/drivers/event/octeontx/ssovf_worker.c
> +++ b/drivers/event/octeontx/ssovf_worker.c
> @@ -343,11 +343,11 @@ ssovf_fastpath_fns_set(struct rte_eventdev *dev)
>
> dev->ca_enqueue = ssow_crypto_adapter_enqueue;
>
> - const event_tx_adapter_enqueue ssow_txa_enqueue[2][2][2][2] = {
> + const event_tx_adapter_enqueue_t ssow_txa_enqueue[2][2][2][2] = {
> #define T(name, f3, f2, f1, f0, sz, flags) \
> [f3][f2][f1][f0] = sso_event_tx_adapter_enqueue_ ##name,
>
> -SSO_TX_ADPTR_ENQ_FASTPATH_FUNC
> + SSO_TX_ADPTR_ENQ_FASTPATH_FUNC
> #undef T
> };
>
> diff --git a/drivers/event/octeontx2/otx2_evdev.c b/drivers/event/octeontx2/otx2_evdev.c
> index 38a6b651d9..f26bed334f 100644
> --- a/drivers/event/octeontx2/otx2_evdev.c
> +++ b/drivers/event/octeontx2/otx2_evdev.c
> @@ -178,41 +178,41 @@ SSO_RX_ADPTR_ENQ_FASTPATH_FUNC
> };
>
> /* Tx modes */
> - const event_tx_adapter_enqueue
> + const event_tx_adapter_enqueue_t
> ssogws_tx_adptr_enq[2][2][2][2][2][2][2] = {
> #define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) \
> [f6][f5][f4][f3][f2][f1][f0] = \
> otx2_ssogws_tx_adptr_enq_ ## name,
> -SSO_TX_ADPTR_ENQ_FASTPATH_FUNC
> + SSO_TX_ADPTR_ENQ_FASTPATH_FUNC
> #undef T
> - };
> + };
>
> - const event_tx_adapter_enqueue
> + const event_tx_adapter_enqueue_t
> ssogws_tx_adptr_enq_seg[2][2][2][2][2][2][2] = {
> #define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) \
> [f6][f5][f4][f3][f2][f1][f0] = \
> otx2_ssogws_tx_adptr_enq_seg_ ## name,
> -SSO_TX_ADPTR_ENQ_FASTPATH_FUNC
> + SSO_TX_ADPTR_ENQ_FASTPATH_FUNC
> #undef T
> - };
> + };
>
> - const event_tx_adapter_enqueue
> + const event_tx_adapter_enqueue_t
> ssogws_dual_tx_adptr_enq[2][2][2][2][2][2][2] = {
> #define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) \
> [f6][f5][f4][f3][f2][f1][f0] = \
> otx2_ssogws_dual_tx_adptr_enq_ ## name,
> -SSO_TX_ADPTR_ENQ_FASTPATH_FUNC
> + SSO_TX_ADPTR_ENQ_FASTPATH_FUNC
> #undef T
> - };
> + };
>
> - const event_tx_adapter_enqueue
> + const event_tx_adapter_enqueue_t
> ssogws_dual_tx_adptr_enq_seg[2][2][2][2][2][2][2] = {
> #define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) \
> [f6][f5][f4][f3][f2][f1][f0] = \
> otx2_ssogws_dual_tx_adptr_enq_seg_ ## name,
> -SSO_TX_ADPTR_ENQ_FASTPATH_FUNC
> + SSO_TX_ADPTR_ENQ_FASTPATH_FUNC
> #undef T
> - };
> + };
>
> event_dev->enqueue = otx2_ssogws_enq;
> event_dev->enqueue_burst = otx2_ssogws_enq_burst;
> @@ -1596,7 +1596,7 @@ otx2_sso_close(struct rte_eventdev *event_dev)
> }
>
> /* Initialize and register event driver with DPDK Application */
> -static struct rte_eventdev_ops otx2_sso_ops = {
> +static struct eventdev_ops otx2_sso_ops = {
> .dev_infos_get = otx2_sso_info_get,
> .dev_configure = otx2_sso_configure,
> .queue_def_conf = otx2_sso_queue_def_conf,
> diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c
> index cfa9733b64..739dc64c82 100644
> --- a/drivers/event/opdl/opdl_evdev.c
> +++ b/drivers/event/opdl/opdl_evdev.c
> @@ -609,7 +609,7 @@ set_do_test(const char *key __rte_unused, const char *value, void *opaque)
> static int
> opdl_probe(struct rte_vdev_device *vdev)
> {
> - static struct rte_eventdev_ops evdev_opdl_ops = {
> + static struct eventdev_ops evdev_opdl_ops = {
> .dev_configure = opdl_dev_configure,
> .dev_infos_get = opdl_info_get,
> .dev_close = opdl_close,
> diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c
> index 6fd1102596..c9e17e7cb1 100644
> --- a/drivers/event/skeleton/skeleton_eventdev.c
> +++ b/drivers/event/skeleton/skeleton_eventdev.c
> @@ -320,7 +320,7 @@ skeleton_eventdev_dump(struct rte_eventdev *dev, FILE *f)
>
>
> /* Initialize and register event driver with DPDK Application */
> -static struct rte_eventdev_ops skeleton_eventdev_ops = {
> +static struct eventdev_ops skeleton_eventdev_ops = {
> .dev_infos_get = skeleton_eventdev_info_get,
> .dev_configure = skeleton_eventdev_configure,
> .dev_start = skeleton_eventdev_start,
> diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
> index a5e6ca22e8..9b72073322 100644
> --- a/drivers/event/sw/sw_evdev.c
> +++ b/drivers/event/sw/sw_evdev.c
> @@ -945,7 +945,7 @@ static int32_t sw_sched_service_func(void *args)
> static int
> sw_probe(struct rte_vdev_device *vdev)
> {
> - static struct rte_eventdev_ops evdev_sw_ops = {
> + static struct eventdev_ops evdev_sw_ops = {
> .dev_configure = sw_dev_configure,
> .dev_infos_get = sw_info_get,
> .dev_close = sw_close,
> diff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h
> index 7ac31e9f92..688f30d45e 100644
> --- a/lib/eventdev/eventdev_pmd.h
> +++ b/lib/eventdev/eventdev_pmd.h
> @@ -99,6 +99,7 @@ extern struct rte_eventdev *rte_eventdevs;
> * @return
> * - The rte_eventdev structure pointer for the given device ID.
> */
> +__rte_internal
> static inline struct rte_eventdev *
> rte_event_pmd_get_named_dev(const char *name)
> {
> @@ -127,6 +128,7 @@ rte_event_pmd_get_named_dev(const char *name)
> * @return
> * - If the device index is valid (1) or not (0).
> */
> +__rte_internal
> static inline unsigned
> rte_event_pmd_is_valid_dev(uint8_t dev_id)
> {
> @@ -1056,7 +1058,7 @@ typedef int (*eventdev_eth_tx_adapter_stats_reset_t)(uint8_t id,
> const struct rte_eventdev *dev);
>
> /** Event device operations function pointer table */
> -struct rte_eventdev_ops {
> +struct eventdev_ops {
> eventdev_info_get_t dev_infos_get; /**< Get device info. */
> eventdev_configure_t dev_configure; /**< Configure device. */
> eventdev_start_t dev_start; /**< Start device. */
> @@ -1173,6 +1175,7 @@ struct rte_eventdev_ops {
> * @return
> * - Slot in the rte_dev_devices array for a new device;
> */
> +__rte_internal
> struct rte_eventdev *
> rte_event_pmd_allocate(const char *name, int socket_id);
>
> @@ -1184,6 +1187,7 @@ rte_event_pmd_allocate(const char *name, int socket_id);
> * @return
> * - 0 on success, negative on error
> */
> +__rte_internal
> int
> rte_event_pmd_release(struct rte_eventdev *eventdev);
>
> diff --git a/lib/eventdev/eventdev_pmd_pci.h b/lib/eventdev/eventdev_pmd_pci.h
> index 1545b240f2..2f12a5eb24 100644
> --- a/lib/eventdev/eventdev_pmd_pci.h
> +++ b/lib/eventdev/eventdev_pmd_pci.h
> @@ -31,7 +31,7 @@ typedef int (*eventdev_pmd_pci_callback_t)(struct rte_eventdev *dev);
> * interface. Same as rte_event_pmd_pci_probe, except caller can specify
> * the name.
> */
> -__rte_experimental
> +__rte_internal
> static inline int
> rte_event_pmd_pci_probe_named(struct rte_pci_driver *pci_drv,
> struct rte_pci_device *pci_dev,
> @@ -85,6 +85,7 @@ rte_event_pmd_pci_probe_named(struct rte_pci_driver *pci_drv,
> * Wrapper for use by pci drivers as a .probe function to attach to a event
> * interface.
> */
> +__rte_internal
> static inline int
> rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv,
> struct rte_pci_device *pci_dev,
> @@ -108,6 +109,7 @@ rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv,
> * Wrapper for use by pci drivers as a .remove function to detach a event
> * interface.
> */
> +__rte_internal
> static inline int
> rte_event_pmd_pci_remove(struct rte_pci_device *pci_dev,
> eventdev_pmd_pci_callback_t devuninit)
> diff --git a/lib/eventdev/eventdev_pmd_vdev.h b/lib/eventdev/eventdev_pmd_vdev.h
> index 2d33924e6c..d9ee7277dd 100644
> --- a/lib/eventdev/eventdev_pmd_vdev.h
> +++ b/lib/eventdev/eventdev_pmd_vdev.h
> @@ -37,6 +37,7 @@
> * - Eventdev pointer if device is successfully created.
> * - NULL if device cannot be created.
> */
> +__rte_internal
> static inline struct rte_eventdev *
> rte_event_pmd_vdev_init(const char *name, size_t dev_private_size,
> int socket_id)
> @@ -74,6 +75,7 @@ rte_event_pmd_vdev_init(const char *name, size_t dev_private_size,
> * @return
> * - 0 on success, negative on error
> */
> +__rte_internal
> static inline int
> rte_event_pmd_vdev_uninit(const char *name)
> {
> diff --git a/lib/eventdev/meson.build b/lib/eventdev/meson.build
> index 32abeba794..523ea9ccae 100644
> --- a/lib/eventdev/meson.build
> +++ b/lib/eventdev/meson.build
> @@ -27,5 +27,11 @@ headers = files(
> 'rte_event_crypto_adapter.h',
> 'rte_event_eth_tx_adapter.h',
> )
> +driver_sdk_headers += files(
> + 'eventdev_pmd.h',
> + 'eventdev_pmd_pci.h',
> + 'eventdev_pmd_vdev.h',
> +)
> +
> deps += ['ring', 'ethdev', 'hash', 'mempool', 'mbuf', 'timer', 'cryptodev']
> deps += ['telemetry']
> diff --git a/lib/eventdev/rte_event_crypto_adapter.h b/lib/eventdev/rte_event_crypto_adapter.h
> index edbd5c61a3..1a8ff75384 100644
> --- a/lib/eventdev/rte_event_crypto_adapter.h
> +++ b/lib/eventdev/rte_event_crypto_adapter.h
> @@ -171,7 +171,6 @@ extern "C" {
> #include <stdint.h>
>
> #include "rte_eventdev.h"
> -#include "eventdev_pmd.h"
>
> /**
> * Crypto event adapter mode
> diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
> index a9c496fb62..0c701888d5 100644
> --- a/lib/eventdev/rte_eventdev.h
> +++ b/lib/eventdev/rte_eventdev.h
> @@ -1324,7 +1324,7 @@ int
> rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint16_t eth_port_id,
> uint32_t *caps);
>
> -struct rte_eventdev_ops;
> +struct eventdev_ops;
> struct rte_eventdev;
>
> typedef uint16_t (*event_enqueue_t)(void *port, const struct rte_event *ev);
> @@ -1342,18 +1342,21 @@ typedef uint16_t (*event_dequeue_burst_t)(void *port, struct rte_event ev[],
> uint16_t nb_events, uint64_t timeout_ticks);
> /**< @internal Dequeue burst of events from port of a device */
>
> -typedef uint16_t (*event_tx_adapter_enqueue)(void *port,
> - struct rte_event ev[], uint16_t nb_events);
> +typedef uint16_t (*event_tx_adapter_enqueue_t)(void *port,
> + struct rte_event ev[],
> + uint16_t nb_events);
> /**< @internal Enqueue burst of events on port of a device */
>
> -typedef uint16_t (*event_tx_adapter_enqueue_same_dest)(void *port,
> - struct rte_event ev[], uint16_t nb_events);
> +typedef uint16_t (*event_tx_adapter_enqueue_same_dest_t)(void *port,
> + struct rte_event ev[],
> + uint16_t nb_events);
> /**< @internal Enqueue burst of events on port of a device supporting
> * burst having same destination Ethernet port & Tx queue.
> */
>
> -typedef uint16_t (*event_crypto_adapter_enqueue)(void *port,
> - struct rte_event ev[], uint16_t nb_events);
> +typedef uint16_t (*event_crypto_adapter_enqueue_t)(void *port,
> + struct rte_event ev[],
> + uint16_t nb_events);
> /**< @internal Enqueue burst of events on crypto adapter */
>
> #define RTE_EVENTDEV_NAME_MAX_LEN (64)
> @@ -1421,15 +1424,15 @@ struct rte_eventdev {
> /**< Pointer to PMD dequeue function. */
> event_dequeue_burst_t dequeue_burst;
> /**< Pointer to PMD dequeue burst function. */
> - event_tx_adapter_enqueue_same_dest txa_enqueue_same_dest;
> + event_tx_adapter_enqueue_same_dest_t txa_enqueue_same_dest;
> /**< Pointer to PMD eth Tx adapter burst enqueue function with
> * events destined to same Eth port & Tx queue.
> */
> - event_tx_adapter_enqueue txa_enqueue;
> + event_tx_adapter_enqueue_t txa_enqueue;
> /**< Pointer to PMD eth Tx adapter enqueue function. */
> struct rte_eventdev_data *data;
> /**< Pointer to device data */
> - struct rte_eventdev_ops *dev_ops;
> + struct eventdev_ops *dev_ops;
> /**< Functions exported by PMD */
> struct rte_device *dev;
> /**< Device info. supplied by probing */
> @@ -1438,7 +1441,7 @@ struct rte_eventdev {
> uint8_t attached : 1;
> /**< Flag indicating the device is attached */
>
> - event_crypto_adapter_enqueue ca_enqueue;
> + event_crypto_adapter_enqueue_t ca_enqueue;
> /**< Pointer to PMD crypto adapter enqueue function. */
>
> uint64_t reserved_64s[4]; /**< Reserved for future fields */
> diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
> index 7de18497a6..cd72f45d29 100644
> --- a/lib/eventdev/version.map
> +++ b/lib/eventdev/version.map
> @@ -55,12 +55,6 @@ DPDK_22 {
> rte_event_eth_tx_adapter_stats_get;
> rte_event_eth_tx_adapter_stats_reset;
> rte_event_eth_tx_adapter_stop;
> - rte_event_pmd_allocate;
> - rte_event_pmd_pci_probe;
> - rte_event_pmd_pci_remove;
> - rte_event_pmd_release;
> - rte_event_pmd_vdev_init;
> - rte_event_pmd_vdev_uninit;
> rte_event_port_attr_get;
> rte_event_port_default_conf_get;
> rte_event_port_link;
> @@ -136,8 +130,6 @@ EXPERIMENTAL {
>
> # changed in 20.11
> __rte_eventdev_trace_port_setup;
> - # added in 20.11
> - rte_event_pmd_pci_probe_named;
> # added in 21.11
> rte_event_eth_rx_adapter_create_with_params;
>
> @@ -152,4 +144,13 @@ INTERNAL {
> global:
>
> rte_event_pmd_selftest_seqn_dynfield_offset;
> + rte_event_pmd_allocate;
> + rte_event_pmd_get_named_dev;
> + rte_event_pmd_is_valid_dev;
> + rte_event_pmd_pci_probe;
> + rte_event_pmd_pci_probe_named;
> + rte_event_pmd_pci_remove;
> + rte_event_pmd_release;
> + rte_event_pmd_vdev_init;
> + rte_event_pmd_vdev_uninit;
> };
> --
> 2.17.1
>
prev parent reply other threads:[~2021-10-20 4:02 UTC|newest]
Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 19:40 [dpdk-dev] [RFC 01/15] " pbhagavatula
2021-08-23 19:40 ` [dpdk-dev] [RFC 02/15] eventdev: separate internal structures pbhagavatula
2021-10-14 9:11 ` Jerin Jacob
2021-08-23 19:40 ` [dpdk-dev] [RFC 03/15] eventdev: move eventdevs globals to hugepage mem pbhagavatula
2021-08-23 19:40 ` [dpdk-dev] [RFC 04/15] eventdev: move inline APIs into separate structure pbhagavatula
2021-09-08 12:03 ` Kinsella, Ray
2021-08-23 19:40 ` [dpdk-dev] [RFC 05/15] eventdev: add helper functions for new driver API pbhagavatula
2021-09-08 12:04 ` Kinsella, Ray
2021-08-23 19:40 ` [dpdk-dev] [RFC 06/15] eventdev: use new API for inline functions pbhagavatula
2021-08-30 14:41 ` Jayatheerthan, Jay
2021-08-30 14:46 ` David Marchand
2021-10-02 20:32 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-08-23 19:40 ` [dpdk-dev] [RFC 07/15] eventdev: make drivers to use new API pbhagavatula
2021-09-08 6:43 ` Hemant Agrawal
2021-08-23 19:40 ` [dpdk-dev] [RFC 08/15] eventdev: hide event device related structures pbhagavatula
2021-08-23 19:40 ` [dpdk-dev] [RFC 09/15] eventdev: hide timer adapter pmd file pbhagavatula
2021-08-23 19:40 ` [dpdk-dev] [RFC 10/15] eventdev: remove rte prefix for internal structs pbhagavatula
2021-08-30 14:42 ` Jayatheerthan, Jay
2021-08-23 19:40 ` [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer object pbhagavatula
2021-08-23 20:42 ` Carrillo, Erik G
2021-08-24 5:16 ` Pavan Nikhilesh Bhagavatula
2021-08-24 15:10 ` Stephen Hemminger
2021-09-01 6:48 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-09-07 21:02 ` Carrillo, Erik G
2021-09-07 21:31 ` [dpdk-dev] " Stephen Hemminger
2021-08-23 19:40 ` [dpdk-dev] [RFC 12/15] eventdev: move timer adapters memory to hugepage pbhagavatula
2021-08-24 13:50 ` Carrillo, Erik G
2021-09-01 6:30 ` Pavan Nikhilesh Bhagavatula
2021-08-23 19:40 ` [dpdk-dev] [RFC 13/15] eventdev: promote event vector API to stable pbhagavatula
2021-08-30 14:43 ` Jayatheerthan, Jay
2021-09-08 12:05 ` Kinsella, Ray
2021-08-23 19:40 ` [dpdk-dev] [RFC 14/15] eventdev: make trace APIs internal pbhagavatula
2021-08-30 14:47 ` Jayatheerthan, Jay
2021-08-23 19:40 ` [dpdk-dev] [RFC 15/15] eventdev: promote trace variables to stable pbhagavatula
2021-09-08 12:06 ` Kinsella, Ray
2021-08-24 7:43 ` [dpdk-dev] [RFC 01/15] eventdev: make driver interface as internal Mattias Rönnblom
2021-08-24 7:47 ` Pavan Nikhilesh Bhagavatula
2021-08-24 8:05 ` Pavan Nikhilesh Bhagavatula
2021-08-30 10:25 ` Mattias Rönnblom
2021-08-30 16:00 ` [dpdk-dev] [RFC] eventdev: uninline inline API functions Mattias Rönnblom
2021-08-31 12:28 ` Jerin Jacob
2021-08-31 12:34 ` Mattias Rönnblom
2021-09-28 9:56 ` [dpdk-dev] [RFC 01/15] eventdev: make driver interface as internal Jerin Jacob
2021-10-03 8:26 ` [dpdk-dev] [PATCH v2 01/13] " pbhagavatula
2021-10-03 8:26 ` [dpdk-dev] [PATCH v2 02/13] eventdev: separate internal structures pbhagavatula
2021-10-03 8:26 ` [dpdk-dev] [PATCH v2 03/13] eventdev: allocate max space for internal arrays pbhagavatula
2021-10-03 8:27 ` [dpdk-dev] [PATCH v2 04/13] eventdev: move inline APIs into separate structure pbhagavatula
2021-10-03 8:27 ` [dpdk-dev] [PATCH v2 05/13] eventdev: use new API for inline functions pbhagavatula
2021-10-03 8:27 ` [dpdk-dev] [PATCH v2 06/13] eventdev: hide event device related structures pbhagavatula
2021-10-03 8:27 ` [dpdk-dev] [PATCH v 07/13] eventdev: hide timer adapter PMD file pbhagavatula
2021-10-03 8:27 ` [dpdk-dev] [PATCH v2 " pbhagavatula
2021-10-03 8:27 ` [dpdk-dev] [PATCH v2 08/13] eventdev: remove rte prefix for internal structs pbhagavatula
2021-10-03 8:27 ` [dpdk-dev] [PATCH v2 09/13] eventdev: rearrange fields in timer object pbhagavatula
2021-10-03 8:27 ` [dpdk-dev] [PATCH v2 10/13] eventdev: move timer adapters memory to hugepage pbhagavatula
2021-10-03 8:27 ` [dpdk-dev] [PATCH v2 11/13] eventdev: promote event vector API to stable pbhagavatula
2021-10-03 8:27 ` [dpdk-dev] [PATCH v2 12/13] eventdev: make trace APIs internal pbhagavatula
2021-10-03 8:27 ` [dpdk-dev] [PATCH v2 13/13] eventdev: mark trace variables as internal pbhagavatula
2021-10-06 6:49 ` [dpdk-dev] [PATCH v3 01/14] eventdev: make driver interface " pbhagavatula
2021-10-06 6:49 ` [dpdk-dev] [PATCH v3 02/14] eventdev: separate internal structures pbhagavatula
2021-10-06 6:50 ` [dpdk-dev] [PATCH v3 03/14] eventdev: allocate max space for internal arrays pbhagavatula
2021-10-06 6:50 ` [dpdk-dev] [PATCH v3 04/14] eventdev: move inline APIs into separate structure pbhagavatula
2021-10-14 9:20 ` Jerin Jacob
2021-10-06 6:50 ` [dpdk-dev] [PATCH v3 05/14] drivers/event: invoke probing finish function pbhagavatula
2021-10-14 9:22 ` Jerin Jacob
2021-10-06 6:50 ` [dpdk-dev] [PATCH v3 06/14] eventdev: use new API for inline functions pbhagavatula
2021-10-11 9:51 ` Gujjar, Abhinandan S
2021-10-06 6:50 ` [dpdk-dev] [PATCH v3 07/14] eventdev: hide event device related structures pbhagavatula
2021-10-06 6:50 ` [dpdk-dev] [PATCH v3 08/14] eventdev: hide timer adapter PMD file pbhagavatula
2021-10-06 6:50 ` [dpdk-dev] [PATCH v3 09/14] eventdev: remove rte prefix for internal structs pbhagavatula
2021-10-11 9:58 ` Gujjar, Abhinandan S
2021-10-06 6:50 ` [dpdk-dev] [PATCH v3 10/14] eventdev: rearrange fields in timer object pbhagavatula
2021-10-06 6:50 ` [dpdk-dev] [PATCH v3 11/14] eventdev: move timer adapters memory to hugepage pbhagavatula
2021-10-07 20:49 ` Carrillo, Erik G
2021-10-08 5:38 ` Pavan Nikhilesh Bhagavatula
2021-10-08 15:57 ` Carrillo, Erik G
2021-10-06 6:50 ` [dpdk-dev] [PATCH v3 12/14] eventdev: promote event vector API to stable pbhagavatula
2021-10-06 6:50 ` [dpdk-dev] [PATCH v3 13/14] eventdev: make trace APIs internal pbhagavatula
2021-10-11 9:59 ` Gujjar, Abhinandan S
2021-10-06 6:50 ` [dpdk-dev] [PATCH v3 14/14] eventdev: mark trace variables as internal pbhagavatula
2021-10-06 7:11 ` David Marchand
2021-10-14 9:28 ` Jerin Jacob
2021-10-14 9:05 ` [dpdk-dev] [PATCH v3 01/14] eventdev: make driver interface " Jerin Jacob
2021-10-14 9:08 ` Jerin Jacob
2021-10-15 19:02 ` [dpdk-dev] [PATCH v4 " pbhagavatula
2021-10-15 19:02 ` [dpdk-dev] [PATCH v4 02/14] eventdev: separate internal structures pbhagavatula
2021-10-15 19:02 ` [dpdk-dev] [PATCH v4 03/14] eventdev: allocate max space for internal arrays pbhagavatula
2021-10-15 19:02 ` [dpdk-dev] [PATCH v4 04/14] eventdev: move inline APIs into separate structure pbhagavatula
2021-10-15 19:02 ` [dpdk-dev] [PATCH v4 05/14] drivers/event: invoke probing finish function pbhagavatula
2021-10-17 15:34 ` Hemant Agrawal
2021-10-15 19:02 ` [dpdk-dev] [PATCH v4 06/14] eventdev: use new API for inline functions pbhagavatula
2021-10-15 19:02 ` [dpdk-dev] [PATCH v4 07/14] eventdev: hide event device related structures pbhagavatula
2021-10-18 7:07 ` Harman Kalra
2021-10-15 19:02 ` [dpdk-dev] [PATCH v4 08/14] eventdev: hide timer adapter PMD file pbhagavatula
2021-10-15 19:02 ` [dpdk-dev] [PATCH v4 09/14] eventdev: remove rte prefix for internal structs pbhagavatula
2021-10-15 19:02 ` [dpdk-dev] [PATCH v4 10/14] eventdev: rearrange fields in timer object pbhagavatula
2021-10-15 19:02 ` [dpdk-dev] [PATCH v4 11/14] eventdev: move timer adapters memory to hugepage pbhagavatula
2021-10-15 19:02 ` [dpdk-dev] [PATCH v4 12/14] eventdev: promote event vector API to stable pbhagavatula
2021-10-15 19:02 ` [dpdk-dev] [PATCH v4 13/14] eventdev: make trace APIs internal pbhagavatula
2021-10-15 19:02 ` [dpdk-dev] [PATCH v4 14/14] eventdev: mark trace variables as internal pbhagavatula
2021-10-17 5:58 ` Jerin Jacob
2021-10-18 15:06 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-10-19 7:01 ` David Marchand
2021-10-17 15:35 ` [dpdk-dev] [PATCH v4 01/14] eventdev: make driver interface " Hemant Agrawal
2021-10-18 23:35 ` [dpdk-dev] [PATCH v5 " pbhagavatula
2021-10-18 23:35 ` [dpdk-dev] [PATCH v5 02/14] eventdev: separate internal structures pbhagavatula
2021-10-18 23:35 ` [dpdk-dev] [PATCH v5 03/14] eventdev: allocate max space for internal arrays pbhagavatula
2021-10-18 23:35 ` [dpdk-dev] [PATCH v5 04/14] eventdev: move inline APIs into separate structure pbhagavatula
2021-10-18 23:36 ` [dpdk-dev] [PATCH v5 05/14] drivers/event: invoke probing finish function pbhagavatula
2021-10-18 23:36 ` [dpdk-dev] [PATCH v5 06/14] eventdev: use new API for inline functions pbhagavatula
2021-10-18 23:36 ` [dpdk-dev] [PATCH v5 07/14] eventdev: hide event device related structures pbhagavatula
2021-10-18 23:36 ` [dpdk-dev] [PATCH v5 08/14] eventdev: hide timer adapter PMD file pbhagavatula
2021-10-18 23:36 ` [dpdk-dev] [PATCH v5 09/14] eventdev: remove rte prefix for internal structs pbhagavatula
2021-10-18 23:36 ` [dpdk-dev] [PATCH v5 10/14] eventdev: rearrange fields in timer object pbhagavatula
2021-10-18 23:36 ` [dpdk-dev] [PATCH v5 11/14] eventdev: move timer adapters memory to hugepage pbhagavatula
2021-10-20 20:24 ` Carrillo, Erik G
2021-10-18 23:36 ` [dpdk-dev] [PATCH v5 12/14] eventdev: promote event vector API to stable pbhagavatula
2021-10-18 23:36 ` [dpdk-dev] [PATCH v5 13/14] eventdev: make trace APIs internal pbhagavatula
2021-10-18 23:36 ` [dpdk-dev] [PATCH v5 14/14] eventdev: mark trace variables as internal pbhagavatula
2021-10-20 4:01 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1Mwm9zNNqPJ4mABRg0o83KJZWchgTXqZF2ViVbV6FiAXQ@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=liangma@liangbit.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=mdr@ashroe.eu \
--cc=nipun.gupta@nxp.com \
--cc=pbhagavatula@marvell.com \
--cc=peter.mccarthy@intel.com \
--cc=sthotton@marvell.com \
--cc=timothy.mcdaniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).