From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 621BA459AC; Mon, 16 Sep 2024 10:25:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E8C224025F; Mon, 16 Sep 2024 10:25:53 +0200 (CEST) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by mails.dpdk.org (Postfix) with ESMTP id F28F040041 for ; Mon, 16 Sep 2024 10:25:51 +0200 (CEST) Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-7a9a3e731f9so372226685a.0 for ; Mon, 16 Sep 2024 01:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726475151; x=1727079951; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=y2og9lBjRndXWESkU25P4zRfebtQ7TYnawn8+qBhLvA=; b=JUWqr/SglRZv0zbFSFb/kiKe6uxND4q3UGHTrPoblzp6SDvOT9nfIIQtIn7eKGVMsP 2GM7G9SShihGSqLVP5P7g380LDw6KTwWgwdqpIxePgTjA2mki36N2FZSUeVTalcEDsvU lJP+GFbFZNlbtaMwWbN+T5FBuynneKKXaHwvyXS9AI0R0TVZLc0sRXhEslnQwZswj8Oh j/4dXdEn1NzjZvVCWueYOgbbL4UyliYSIs//vLsKUR4X8k1djXCDEjF4HkOUk6aolcUG 6ERK4MD2OwGcuWk0KoR28HQAgd0TGLwCqPJJNnp7JUaan1w/gM6hEZ+xIlVyXn9+nlEX 4/7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726475151; x=1727079951; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y2og9lBjRndXWESkU25P4zRfebtQ7TYnawn8+qBhLvA=; b=gaDMyViFBQbxjiZuyHE9FJSupfzQSVvpP3yeGLpY1r9ax0v13oFFqktHoM5Pq/gflw 4CY/oCo2Gt3VaZN3zBuTT1+LGbiBlyGi76wy2QobeKxY5zyTDCmkxscig5JAkiNvD5Jx HCkrxhji/w7STsLtn7axf6u3bLYDrfAm+pAWiO9Z/rPyPlGbXJ7R38k0BT+OddZwQu9m mUfcx0FjxhxuzOMV+U9g5+3rDKqVTma0b2oFVMTdzJ5ugYQWOdzAJ/lnsijdyKty8HPr 69S27eXCo4m1MWiTe4vtvMC1ihgaNfVhxIMYqSXM2TjdKocgDkC/y/aJXRz69a/nwfKQ UoeQ== X-Forwarded-Encrypted: i=1; AJvYcCWd+gZtfkCh2DXAEa+DKcZzm4w/XQuEUfFDKRtzcExzdNw53uozC91qgybJOTpEgeBy3Q8=@dpdk.org X-Gm-Message-State: AOJu0Yy8qV050VLUrJYxhIUatVK4BVlLf598P/Gcxxouty9o4VyTs8Pq +ucODPPif6hlYlE0WcY9aUxMdbR563m4YMuPygAp24MNMIc7Zk6ce6MreEoGTE3PudZMHZEdWN0 Zj5/Q43h63y3rRUh0AhPMoqRPAxc= X-Google-Smtp-Source: AGHT+IEgYNFf85xv+OiKFO2cQddOTrdwBxY8M2t4cZvd0oY5aqtyLX2FbNM2MSLyxX0nyw7xzd21ggQCRmbreSbvvg4= X-Received: by 2002:a05:620a:2801:b0:7a3:7920:5500 with SMTP id af79cd13be357-7a9e5f26733mr2506263885a.32.1726475151231; Mon, 16 Sep 2024 01:25:51 -0700 (PDT) MIME-Version: 1.0 References: <20240913175828.21640-1-adel.belkhiri@gmail.com> In-Reply-To: <20240913175828.21640-1-adel.belkhiri@gmail.com> From: Jerin Jacob Date: Mon, 16 Sep 2024 13:55:25 +0530 Message-ID: Subject: Re: [PATCH] ethdev: optimize activation of fast-path tracepoints To: Adel Belkhiri Cc: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org, Adel Belkhiri Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Sep 14, 2024 at 1:59=E2=80=AFAM Adel Belkhiri wrote: > > From: Adel Belkhiri > > Split the tracepoints rte_ethdev_trace_rx_burst and > rte_eth_trace_call_rx_callbacks into two separate ones > for empty and non-empty calls to avoid saturating > quickly the trace buffer. > > Signed-off-by: Adel Belkhiri > --- > - nb_rx, nb_pkts); > + if (unlikely(nb_rx > 0)) You may consider unlikely(nb_rx) > rte_flow_dev_dump; > > # added in 20.05 > - __rte_ethdev_trace_rx_burst; Removal of a public symbol breaks the ABI. The good news is that 24.11 can break the ABI. IMO, It is OK to break this ABI. Also need to update "Removed items" in doc/guides/rel_notes/release_24_11.r= st > + __rte_ethdev_trace_rx_burst_empty; > + __rte_ethdev_trace_rx_burst_nonempty; > __rte_ethdev_trace_tx_burst; > rte_flow_get_aged_flows; > > -- > 2.34.1 >