From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72B80A0524; Fri, 27 Nov 2020 10:34:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 45817C930; Fri, 27 Nov 2020 10:34:07 +0100 (CET) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 2F411C90E for ; Fri, 27 Nov 2020 10:34:06 +0100 (CET) Received: by mail-io1-f66.google.com with SMTP id z5so4178924iob.11 for ; Fri, 27 Nov 2020 01:34:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fFV0GTFoc3q3o9T6Z/KNUXEqBtEOKpchvYBCQ5mj7Ig=; b=CvkHV6fFgTS335+WLthFvP3hGeCnb/e/hpDp2FhC7hgQTZBwoF4JEVgJ5MPNwe2aik aLij2S/9DzliwO9GCa/XEoNkqv4imXssg1bcnDawZ2Gxezu2jGjTNMrr4A/+HWB8hiXF 0ZN0hUIoqPmPYXSXkz2ehp9BR9ubWW+xOUChSvxsyJcDUvc3Q+erXcNeVoyn+d1oxRCD szZmzzG1UAhJWwkUSJffCxSjX1JmAc98TmYPzCkb+XXf/9V1xTSzB2AieR9FPW61Y/sA ZjmiDvNATsQ746q/M20C+EjIQvLWSPvFEetC7K7kNSzCL2NJuqBJ7uwR2uoPzz+zUERN vYmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fFV0GTFoc3q3o9T6Z/KNUXEqBtEOKpchvYBCQ5mj7Ig=; b=m15PxfV9bmDah+h6IddbO7Xw9etVdEcRLbii6+O+/M22gGlzh0GeXUG9ufSsyewi9J T1nkiaB9PKMO7kFm6Ulp/3jZ8HMNak7fqNATmo4fAkclSWdtZ765ZftndaMesQ7tJIiD +ikXj3rpNvX5TGP/Lx/Y733KAwtlQwlZXmDhX9ZgTu+fq78AhJk3afzAuEmlwiH3AExg pRvMpovUtMYXQ9wjqdsf3ClWrxXU/+HHaGU5o6QJPwBq5GZoIh0U2/FbOhspd8BigcuB M2l7A1Er/+hJg9/xLxPEdn6I3tEyEnRdy7kTOg9WGR/sfRyQQ+9Is9/iPqd/NSjKIaNt immg== X-Gm-Message-State: AOAM532U8NYkZf2Ov1ASuvUM8HrgyCvZ/7dap2oSmYXUe2ouu1ozST+0 RE42RRtUHRx3lfSf3yf3ZnjGvxS9+u7vKt6wzTc= X-Google-Smtp-Source: ABdhPJyFq0MCKk8oqa5RsAU8YoSLKnaY/5rOCpworBcmWMuhauXyc0dohmeuYMQmNZuF/b4Ba5bZzbHtaenK70CLYzo= X-Received: by 2002:a05:6602:8d:: with SMTP id h13mr5395047iob.163.1606469644489; Fri, 27 Nov 2020 01:34:04 -0800 (PST) MIME-Version: 1.0 References: <20201127080903.26817-1-ruifeng.wang@arm.com> <20201127080903.26817-2-ruifeng.wang@arm.com> In-Reply-To: From: Jerin Jacob Date: Fri, 27 Nov 2020 15:03:48 +0530 Message-ID: To: David Marchand Cc: Ruifeng Wang , Andrew Rybchenko , Jerin Jacob , Honnappa Nagarahalli , dev , nd , Feifei Wang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 27, 2020 at 2:56 PM David Marchand wrote: > > On Fri, Nov 27, 2020 at 9:51 AM Jerin Jacob wrote= : > > > > On Fri, Nov 27, 2020 at 2:09 PM David Marchand > > wrote: > > > > > > On Fri, Nov 27, 2020 at 9:10 AM Ruifeng Wang w= rote: > > > > > > > > Gcc build with '-O0' on platforms with RTE_ARM_FEATURE_ATOMICS set > > > > failed for: > > > > ../lib/librte_efd/rte_efd.c > > > > Assembler messages: > > > > 3866: Error: selected processor does not support `crc32cb w0,w0,w1' > > > > 3890: Error: selected processor does not support `crc32ch w0,w0,w1' > > > > 3914: Error: selected processor does not support `crc32cw w0,w0,w1' > > > > 3938: Error: selected processor does not support `crc32cx w0,w0,x1' > > > > > > > > This was caused by an architecture specifier added for Clang. > > > > Unlike Clang, Gcc considers each inline assembly block to be depend= ent > > > > and therefor, the architecture specifier impacts assemble of some > > > > blocks require certain extension support. > > > > > > I reproduced this error with -O0 for config/arm/arm64_octeontx2_linux= _gcc. > > > The patch looks simple enough and it only affects ARM builds. > > > > > > Jerin, > > > Are you okay with this change for 20.11? > > > Or should we wait 21.02? > > > > I could reproduce the issue with meson build -Dbuildtype=3Ddebug > > --cross-file config/arm/arm64_octeontx2_linux_gcc > > > > This fix is OK. Request to merge for 20.11 > > > > Acked-by: Jerin Jacob > > Ruifeng, Andrew, > > I get a compilation error with this patch on sfc using gcc and > config/arm/arm64_octeontx2_linux_gcc config + --buildtype=3Ddebug and/or > -Dc_args=3D-O0 . > > aarch64-linux-gnu-gcc (GNU Toolchain for the A-profile Architecture > 8.2-2019.01 (arm-rel-8.28)) 8.2.1 20180802 > > FAILED: drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_crc32.c.o > aarch64-linux-gnu-gcc > -Idrivers/common/sfc_efx/base/932d09a@@sfc_base@sta > -Idrivers/common/sfc_efx/base -I../../dpdk/drivers/common/sfc_efx/base > -Idrivers/common/sfc_efx -I../../dpdk/drivers/common/sfc_efx -I. > -I../../dpdk/ -Iconfig -I../../dpdk/config -Ilib/librte_eal/include > -I../../dpdk/lib/librte_eal/include -Ilib/librte_eal/linux/include > -I../../dpdk/lib/librte_eal/linux/include -Ilib/librte_eal/arm/include > -I../../dpdk/lib/librte_eal/arm/include -Ilib/librte_eal/common > -I../../dpdk/lib/librte_eal/common -Ilib/librte_eal > -I../../dpdk/lib/librte_eal -Ilib/librte_kvargs > -I../../dpdk/lib/librte_kvargs > -Ilib/librte_telemetry/../librte_metrics > -I../../dpdk/lib/librte_telemetry/../librte_metrics > -Ilib/librte_telemetry -I../../dpdk/lib/librte_telemetry > -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall > -Winvalid-pch -Werror -g -include rte_config.h -Wextra -Wcast-qual > -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security > -Wmissing-declarations -Wmissing-prototypes -Wnested-externs > -Wold-style-definition -Wpointer-arith -Wsign-compare > -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned > -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC > -march=3Darmv8.2-a+crc+crypto+lse -DALLOW_EXPERIMENTAL_API > -DALLOW_INTERNAL_API -Wno-format-truncation -Wdisabled-optimization > -Waggregate-return -Wbad-function-cast -Wno-sign-compare > -Wno-unused-parameter -Wno-unused-variable -Wno-empty-body > -Wno-unused-but-set-variable -MD -MQ > 'drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_crc32.c.o' -MF > 'drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_crc32.c.o.d' -o > 'drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_crc32.c.o' -c > ../../dpdk/drivers/common/sfc_efx/base/efx_crc32.c > In file included from ../../dpdk/lib/librte_eal/arm/include/rte_atomic.h:= 9, > from ../../dpdk/lib/librte_eal/include/generic/rte_pause= .h:19, > from ../../dpdk/lib/librte_eal/arm/include/rte_pause_64.= h:19, > from ../../dpdk/lib/librte_eal/arm/include/rte_pause.h:1= 3, > from > ../../dpdk/lib/librte_eal/include/generic/rte_spinlock.h:25, > from ../../dpdk/lib/librte_eal/arm/include/rte_spinlock.= h:17, > from ../../dpdk/drivers/common/sfc_efx/efsys.h:15, > from ../../dpdk/drivers/common/sfc_efx/base/efx.h:11, > from ../../dpdk/drivers/common/sfc_efx/base/efx_crc32.c:= 7: > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In function > =E2=80=98__cas_128_relaxed=E2=80=99: > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:81:20: error: > function returns an aggregate [-Werror=3Daggregate-return] > __ATOMIC128_CAS_OP(__cas_128_relaxed, "casp") > ^~~~~~~~~~~~~~~~~ > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:57:1: note: in > definition of macro =E2=80=98__ATOMIC128_CAS_OP=E2=80=99 > cas_op_name(rte_int128_t *dst, rte_int128_t old, rte_int128_t updated) = \ > ^~~~~~~~~~~ > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In function > =E2=80=98__cas_128_acquire=E2=80=99: > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:82:20: error: > function returns an aggregate [-Werror=3Daggregate-return] > __ATOMIC128_CAS_OP(__cas_128_acquire, "caspa") > ^~~~~~~~~~~~~~~~~ > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:57:1: note: in > definition of macro =E2=80=98__ATOMIC128_CAS_OP=E2=80=99 > cas_op_name(rte_int128_t *dst, rte_int128_t old, rte_int128_t updated) = \ > ^~~~~~~~~~~ > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In function > =E2=80=98__cas_128_release=E2=80=99: > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:83:20: error: > function returns an aggregate [-Werror=3Daggregate-return] > __ATOMIC128_CAS_OP(__cas_128_release, "caspl") > ^~~~~~~~~~~~~~~~~ > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:57:1: note: in > definition of macro =E2=80=98__ATOMIC128_CAS_OP=E2=80=99 > cas_op_name(rte_int128_t *dst, rte_int128_t old, rte_int128_t updated) = \ > ^~~~~~~~~~~ > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In function > =E2=80=98__cas_128_acq_rel=E2=80=99: > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:84:20: error: > function returns an aggregate [-Werror=3Daggregate-return] > __ATOMIC128_CAS_OP(__cas_128_acq_rel, "caspal") > ^~~~~~~~~~~~~~~~~ > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:57:1: note: in > definition of macro =E2=80=98__ATOMIC128_CAS_OP=E2=80=99 > cas_op_name(rte_int128_t *dst, rte_int128_t old, rte_int128_t updated) = \ > ^~~~~~~~~~~ > cc1: all warnings being treated as errors > > > If I waive those warnings: > - next to fail is net/igc (fixed by next patch so ok) > - and then next to fail is net/sfc. Regarding the net/sfc build, Could try clean build.(I got the warning first= , after the clean build, it is OK) > > > -- > David Marchand >